Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        linux-s390@vger.kernel.org
Cc:     shu wang <malate_wangshu@hotmail.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Peter Xu <peterx@redhat.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Alexey Dobriyan <adobriyan@gmail.com>,
        Matthew Wilcox <willy@infradead.org>,
        Michel Lespinasse <walken@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Mike Kravetz <mike.kravetz@oracle.com>
Subject: [RFC PATCH 3/5] mm proc/task_mmu.c: add soft dirty pte checks for hugetlb
Date:   Wed, 10 Feb 2021 16:03:20 -0800
Message-Id: <20210211000322.159437-4-mike.kravetz@oracle.com>
In-Reply-To: <20210211000322.159437-1-mike.kravetz@oracle.com>
References: <20210211000322.159437-1-mike.kravetz@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from monkey.oracle.com (50.38.35.18) by MWHPR01CA0032.prod.exchangelabs.com (2603:10b6:300:101::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.27 via Frontend Transport; Thu, 11 Feb 2021 00:03:38 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 70cee33d-11b8-4455-0043-08d8ce207bd8
X-MS-TrafficTypeDiagnostic: MWHPR10MB1341:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MWHPR10MB1341E6D557CC558512E939CFE28C9@MWHPR10MB1341.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:854;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: UPuykCYzUl7j+djUECd2t7e2xAzfO5Zd5huSz88FrTC89EiqV9LMVfvqff4BI6T85dBlkYL16aq54zDWad8MWk1YxipuFddM5f4DXN4i7sCzyVpH8eMeNvifnHbHAVwlQE9AudDPhEqttsyDP15FQHNeMtF58Jl0L8clzOAE0DCRquw2y1/U816RJM4y4sYtiNdpyiwi5uxFQDuuQwFLr+2j/SlDRvQbaYs12y2h3Y899I2RCdcThdkMA/9hd9UZhu2dlwvQcRNk2tU1BXWvcKUrimOotBiUfdRfRcazDRhUTfs6a66Ck5Xk6MziqBaNAyslbFByZDhCsDUSGBK3t+KT/1l4esDDaWTFhMXE6VNS05AoYzaK30S34zLNzhAlbAsag/piW0XYKdg6mU3NFvOfi0EdqWOK3DgLwdy1YeeC6Rw2qED2pz0hN1xSiN4xNHwylqD0b1eK/JIopl0jcFmdbqPz6j6x98Rl1g3LVljQkN3q7U9P38SeK5Icf16cv8SoZ/Y/OWP5ZbzuOuuFuxBWe2ERXqSVMlby85cwTGos1nPCnEk0/IufvoCjXBmk
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR10MB1389.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(39860400002)(346002)(366004)(396003)(136003)(107886003)(4326008)(6666004)(2906002)(8676002)(44832011)(7416002)(66556008)(66476007)(54906003)(1076003)(2616005)(956004)(7696005)(5660300002)(26005)(478600001)(52116002)(86362001)(8936002)(6486002)(66946007)(316002)(4744005)(186003)(16526019)(36756003)(14143004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?un5siEY7ATgDBVlI1LqymOBYogAp8COB9gqeODpkOLhLep0ydF38A4NIOWcZ?=
 =?us-ascii?Q?9jbCgSPGs7+hccr3LX88TApQ/72fE5Xs7DScjXVZ5b/Jusr80ZOfWHqIxzz7?=
 =?us-ascii?Q?biY/kWruJqk4tAfMhjX+tf4Ak9j0Rkc3UiJwWMvrbocf1mGFxZX7EhW1a40g?=
 =?us-ascii?Q?hjGOOBz1i6sEaEZ4G5RLOckeUfXzEs7UaQdMjf4vcBibRJ/Q/IFbzT3OHTLn?=
 =?us-ascii?Q?cVZiloCZjETkGtDCgsnDrJvoDjzy7+/l4fDO95ryXVGDkEic8+lsnm77833n?=
 =?us-ascii?Q?wXM7M5GELV7JA00rOlYgkwbEXW1RiP1CZXrFt/OWvo2iZG44BcazkRIIhSkK?=
 =?us-ascii?Q?SmFsR0NbnjhNp5tRN5mwZn3TgI9dD4yaBiYorOZg/WOjpDIob2GJm751EtFs?=
 =?us-ascii?Q?ZSj2RsX3LA8LKw9eTxnVkUSsQpGabueo1qDHEbb8qAkQlSQY2KCD2Zxc3MUA?=
 =?us-ascii?Q?DT4E+tsRnaxZjzchDjYaX1XyBqZv1wELiC1NgDIPQD170kil5gfu/As/ASZ4?=
 =?us-ascii?Q?0a2+BQ+aLmizy1T/ijDfhrZFyp4Ht+VWOgRdRNt10cHZN+UYekM1wxBXc3Qu?=
 =?us-ascii?Q?Pm6duDKnskcblZUGohl2SXC0VzWwx50N916eXvvBgB8scZPOGCSvLJ/9UaU+?=
 =?us-ascii?Q?B4+kuiDzLxy72lr9DR5Fjopy34KI04dljAXbgKoGft4laKUGo1zSP3MK0Rz0?=
 =?us-ascii?Q?EyMYVu/BLUwr7oQ2pubEV+YAgir8EeCIFQvD6iDc87jNkq1OywNXXJrMVN7w?=
 =?us-ascii?Q?TIXqFg0SuwCiuPxYbM/1xyDA7UjQm6xrffVej35dcMhNdoOzK6fHNzDl1nLm?=
 =?us-ascii?Q?ljRRSIcPCRk6Jn2Lic+6/v1t0ehYA5W5qaMUUExkN4WbVLjc6d7RYfZBq+94?=
 =?us-ascii?Q?4tbkn/TXBJlOV8z3BhdxAnb+nvWXPmjtLUKvhnQypULiVdQTCgOSutYXRst+?=
 =?us-ascii?Q?xswKQVSi2rAZ72XroJsD+A4l4jinPA8R/3k1SujtLvqnyaUXdhdcR5rqT74h?=
 =?us-ascii?Q?2FxrFEVF+jxCVWmyimnBvjmncTZO6uCDW2bLLlrfwRb45BjZadTQ2k3AXGvp?=
 =?us-ascii?Q?ijKqj8JAK9QaL5s+45LfboPC9CD3FNzrG7S1p+j+CilFyaSggcplX6LvDhoL?=
 =?us-ascii?Q?4d94bqkEH+fWa3bjr5touxKps9Bvd3WiIJXAxhBAZe08y1a4EVW3qMUrSbYO?=
 =?us-ascii?Q?aoQHrgOn+0Yt32/SI1xxVM3XjbhLeL+0CXDQ6+aYQZj3kHgvLsIWJWL0bb2r?=
 =?us-ascii?Q?Wz17uCRPamu1rD5ZM88oVvpeP2HBpSLF3bvRMscmYlUlzq+b/yIq2GcqfBTF?=
 =?us-ascii?Q?Hco6bcwq2gcx8LD0iXgNQKoE?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 70cee33d-11b8-4455-0043-08d8ce207bd8
X-MS-Exchange-CrossTenant-AuthSource: MWHPR10MB1389.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2021 00:03:38.7762
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5rNgNZ/Ff9agW0QNZFLCoREFojky8E2O/CFGwQsBEACvTxgCpasC1JxTEbUCHFhGbPoxqysX+n45OKEGMXk+JQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1341
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9891 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 adultscore=0
 mlxlogscore=999 phishscore=0 spamscore=0 suspectscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2102100209
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9891 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 impostorscore=0
 priorityscore=1501 bulkscore=0 suspectscore=0 mlxscore=0 phishscore=0
 lowpriorityscore=0 mlxlogscore=999 clxscore=1015 spamscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2102100209
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Pagemap was only using the vma flag PM_SOFT_DIRTY for hugetlb vmas.
This is insufficient.  Check the individual pte entries.

Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
---
 fs/proc/task_mmu.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
index 602e3a52884d..829b35016aaa 100644
--- a/fs/proc/task_mmu.c
+++ b/fs/proc/task_mmu.c
@@ -1507,6 +1507,10 @@ static int pagemap_hugetlb_range(pte_t *ptep, unsigned long hmask,
 		flags |= PM_SOFT_DIRTY;
 
 	pte = huge_ptep_get(ptep);
+
+	if (huge_pte_soft_dirty(pte))
+		flags |= PM_SOFT_DIRTY;
+
 	if (pte_present(pte)) {
 		struct page *page = pte_page(pte);
 
-- 
2.29.2