Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1817585pxb; Wed, 10 Feb 2021 18:32:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJyjnhSyaTAn2sygp2QPKY0zZHwV/RuBOFsvX8DbdYrmORozA8mUZHwEco495/onjh/YpAvU X-Received: by 2002:a50:8466:: with SMTP id 93mr5976753edp.55.1613010743811; Wed, 10 Feb 2021 18:32:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613010743; cv=none; d=google.com; s=arc-20160816; b=oI1jRjVDXRz8Z/zQg+7CxjVz7ZxZ6Xl3jHUFN0cMwchNu3FKF5S2sUMgwYtPMHVRyW 308P3h6TGsF7zfippv5TSR9WhABYc8h8NlHS5vOetX53k6qH6bCdAxqQY3m3cjwAQb7C rELQTTwGjXAp7Lzz6WkQn6fRjb5QhmIIo3A9HZpTURJoGDV6XAqyGaVQIUhmwCtB2wou xLx6C0lxVq2QB5H4zYy+p5/mSs8r11mqKSKwj1PTD1obTf7A0G3bDsLWFiPeZA2bNwaT 941vQA7/dX2nb6sVz0CYVLQNi/sUKV0JbRZTXoMD7ORJSqCsBduYQsAj9Sg2fSHOroKb 7Jhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=v/JR6cxBec2OO4AyQr8LqOFJlkaTALkaG4hkaa3+jH0=; b=taLz4z7HfPjThjusZILS01v+r2WuehvuuAzwuSMTNznZtTMHODviIghISpUJXP37bN KmbE+k4AWpog1M4NwtlGgNDIOvaZA3c5pXVM5tx/zTrle7A/AqkiwZFODh9uf5jPF4Ol Z4nx2bhttCKmwKHv4TUBIH0z37Qt856qTs137GsT7pk8VUcpaKtUUl9tJnoGbdzMhhC9 Zvpn7qBNsjWoEtQ/a4NvImFEgHuae7vbh7AW9lMtHF9pg1Vtr0EWhYVKTZOZCsFZvn4H juZJzzSkzXC/0Hf0YENW9Tx9ttgwFgh1gH5CJ7eunS7xtFORl52BvtekjKIoQOg5sxB4 xBTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@0x0f.com header.s=google header.b=tmRca4PB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hs14si2683921ejc.159.2021.02.10.18.32.00; Wed, 10 Feb 2021 18:32:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@0x0f.com header.s=google header.b=tmRca4PB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229587AbhBKC3d (ORCPT + 99 others); Wed, 10 Feb 2021 21:29:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbhBKC3b (ORCPT ); Wed, 10 Feb 2021 21:29:31 -0500 Received: from mail-qv1-xf29.google.com (mail-qv1-xf29.google.com [IPv6:2607:f8b0:4864:20::f29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2913C061786 for ; Wed, 10 Feb 2021 18:28:51 -0800 (PST) Received: by mail-qv1-xf29.google.com with SMTP id v19so1925037qvl.7 for ; Wed, 10 Feb 2021 18:28:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=0x0f.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=v/JR6cxBec2OO4AyQr8LqOFJlkaTALkaG4hkaa3+jH0=; b=tmRca4PB2kps0fAMgBJNaTQMArARvSx/SfChzgUdm89r1VOxPYGtgjUqVJbGvABQBi b1p0l2nSh7eJd4bBjJyqeqxxzLEQMSvO8U2c8yeds2A1CQZbqXlsRAzJKmGHJukytAFJ m/GJu+/zc7xAK2nEL38pW+FCnNngPCIIy0dc0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=v/JR6cxBec2OO4AyQr8LqOFJlkaTALkaG4hkaa3+jH0=; b=ZLo41lTagGGh7Zfm8lh8eC68S8k5tBBxB3Xa0+/cpq5bCDVcT3YwnSK1YQ8QdvcGMq OMGW6vpxMbyaGwXSBZzsIn+EVP+F5HMO9SMwLLpbc9iDBO6/0ScXuqIpSMZOtzso+LrI Fju1Ysqht6R2bZBonN3SDZ+9pf64f4UQQw5ECWnToRQbF4cd5CYTK1/SPB8g0E2LuEVe 7Ivi9VPFyv4JAqadVfhCXOXyQ3wO9t5pLDwOVVk/+t8GxJdIFnuIwDXyOicqZ5OZtMh6 jVgFkRXO/VOBNczgvmD8c6giWlGFNzTK+8DYDov3ji+9uGMA4ORosMA4LiINNQ2hBIY2 eAww== X-Gm-Message-State: AOAM530i+tT5R0t6aeuKpjE5a49tQNSU5Yc3VwEfVnLdgk/XSMMLghqj M1RkMkWhzoz76hm6j9VXjDgEg2iZan5IT9NXtGsD4SLEs92znA== X-Received: by 2002:a0c:ec83:: with SMTP id u3mr5631558qvo.55.1613010530875; Wed, 10 Feb 2021 18:28:50 -0800 (PST) MIME-Version: 1.0 References: <20201114135044.724385-1-daniel@0x0f.com> <20201114135044.724385-3-daniel@0x0f.com> <160843556037.1580929.13575770228476494246@swboyd.mtv.corp.google.com> <160848984935.1580929.936824086681978646@swboyd.mtv.corp.google.com> <161292417080.418021.13416197091150418216@swboyd.mtv.corp.google.com> In-Reply-To: <161292417080.418021.13416197091150418216@swboyd.mtv.corp.google.com> From: Daniel Palmer Date: Thu, 11 Feb 2021 11:28:40 +0900 Message-ID: Subject: Re: [PATCH 2/6] dt-bindings: clk: mstar msc313 mpll binding description To: Stephen Boyd Cc: DTML , linux-clk@vger.kernel.org, linux-arm-kernel , Linux Kernel Mailing List , Willy Tarreau Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stephen, On Wed, 10 Feb 2021 at 11:29, Stephen Boyd wrote: > The child clks should be using clk_parent_data to point to the parent > clks through DT. That way the name of the clk doesn't matter except for > debug purposes. I think I get it now. I was using of_clk_parent_fill() to get the parent clocks sourced from the mpll but I seems like I should be filling out an array of struct clk_parent_data with the indices of the parents and using clk_register_composite_pdata() etc instead. Thanks! Daniel