Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: linux-next: Tree for Feb 10 (acrn)
To:     "Liu, Shuo A" <shuo.a.liu@intel.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        acrn-dev@lists.projectacrn.org
References: <20210210224220.28657128@canb.auug.org.au>
 <f13e97f3-88b9-294a-71d7-024478c13223@infradead.org>
 <eedf6122-ec76-c25a-8d57-4ee0fa9f55d3@intel.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <2728d6d9-7cb0-c9a3-c5b8-cbc9858e4c10@infradead.org>
Date:   Wed, 10 Feb 2021 20:20:34 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.0
MIME-Version: 1.0
In-Reply-To: <eedf6122-ec76-c25a-8d57-4ee0fa9f55d3@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2/10/21 7:29 PM, Liu, Shuo A wrote:
> 
> 
> On 2/11/2021 01:52, Randy Dunlap wrote:
>> On 2/10/21 3:42 AM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20210209:
>>>
>>
>> ../drivers/virt/acrn/hsm.c: In function ‘remove_cpu_store’:
>> ../drivers/virt/acrn/hsm.c:389:3: error: implicit declaration of function ‘remove_cpu’; did you mean ‘register_cpu’? [-Werror=implicit-function-declaration]
>>    remove_cpu(cpu);
>>
>> ../drivers/virt/acrn/hsm.c:402:2: error: implicit declaration of function ‘add_cpu’; did you mean ‘task_cpu’? [-Werror=implicit-function-declaration]
>>   add_cpu(cpu);
>>
>>
>> Full randconfig file is attached.
>>
> 
> Thanks.
> The vCPU removing depends on CONFIG_HOTPLUG_CPU. Below change could fix.

Yes, it does, thanks.

Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

> ---
> 
> diff --git a/drivers/virt/acrn/hsm.c b/drivers/virt/acrn/hsm.c
> index 1f6b7c54a1a4..e340788aacdf 100644
> --- a/drivers/virt/acrn/hsm.c
> +++ b/drivers/virt/acrn/hsm.c
> @@ -372,6 +372,7 @@ static int acrn_dev_release(struct inode *inode,
> struct file *filp)
>         return 0;
>  }
> 
> +#ifdef CONFIG_HOTPLUG_CPU
>  static ssize_t remove_cpu_store(struct device *dev,
>                                 struct device_attribute *attr,
>                                 const char *buf, size_t count)
> @@ -403,9 +404,12 @@ static ssize_t remove_cpu_store(struct device *dev,
>         return ret;
>  }
>  static DEVICE_ATTR_WO(remove_cpu);
> +#endif
> 
>  static struct attribute *acrn_attrs[] = {
> +#ifdef CONFIG_HOTPLUG_CPU
>         &dev_attr_remove_cpu.attr,
> +#endif
>         NULL
>  };
> 


-- 
~Randy