Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 11 Feb 2021 08:38:07 +0100
From:   Krzysztof Kozlowski <krzk@kernel.org>
To:     Ricardo Rivera-Matos <r-rivera-matos@ti.com>
Cc:     sre@kernel.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] power: supply: bq25980: Move props from battery
 node
Message-ID: <20210211073807.sh6uwv3dt3eqxyy7@kozik-lap>
References: <20210210225646.10055-1-r-rivera-matos@ti.com>
 <20210210225646.10055-2-r-rivera-matos@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210210225646.10055-2-r-rivera-matos@ti.com>
Precedence: bulk

On Wed, Feb 10, 2021 at 04:56:46PM -0600, Ricardo Rivera-Matos wrote:
> Currently POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT and
> 
> POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE are exposed on the battery node
> 
> and this is incorrect.
> 
> This patch exposes POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT and
> 
> POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE on the charger node rather
> 
> than the battery node.

Now it makes sense if you only formatted it in human-readable way.
Please fix your git/editor/email client/desktop unless you used such
formatting intentionally. If it was intentional, then please don't - do
like everyone else in Linux kernel (git log will help).

Best regards,
Krzysztof

> 
> Fixes: 5069185fc18e ("power: supply: bq25980: Add support for the BQ259xx family")
> Signed-off-by: Ricardo Rivera-Matos <r-rivera-matos@ti.com>
> ---
>  drivers/power/supply/bq25980_charger.c | 40 ++++++++------------------
>  1 file changed, 12 insertions(+), 28 deletions(-)