Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1999711pxb; Thu, 11 Feb 2021 01:25:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJwUBnYAlJHk7wSzmCBJZIQ5JFVjf4dX+dC+ZMQN4DomiH+0Uy6O9Ts7G+VHA4ByetmrNagM X-Received: by 2002:a17:907:98f3:: with SMTP id ke19mr7485566ejc.290.1613035509463; Thu, 11 Feb 2021 01:25:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613035509; cv=none; d=google.com; s=arc-20160816; b=G4a9471nbQa4REWTv3wZC0KzjZz6V+uwT0/RG1yyeTUJLKIV2M9pDPBrRY4Eze5tx/ SxSqA7y6fRFPO2LU2KZXFEUlQIFWkS9+xPD88TxQyTo5yNi67CBhoxupOU0eAhZKu2lO fl3ddpslK16MvJaj2J1aGNUMHsehw/2vMoyWpxpECQXQQtBwkoAunZaIlM3NeuzfQqCt gKa29qYjfHKBbXm67NLhWOS7StRJgWDCWQOac1M7sVKRkDu2/JtsmepIP/O4lrwEcpGS f1jaHtRCT04brYw/NdVRX+Qt7l3mseBJJvtcUqd7fybGO8vvJEIfCvliyAC4nr7EQ/EM mFMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:references:in-reply-to :message-id:date:subject:to:from:dkim-signature; bh=LeJkYXCorWtiaP+yCGj+HszRDmiDY/6LzTvN7R0PDJU=; b=mrxVhuPXnsLW4j8bX4sySYGwZ9pE/lSwuulEOM7jbFhtd9k59gl3uQsURzOjMA4V3f EirWUlsuHY0oUoxgP+WhEVTmuXDl9jZX3rKHA/p7GLVGfqjOPfKVxZkJEthD35i/+GXI dm5+98pgr+YbYwDlQdOKtNwe1GSTH9JVqGRjYt3pA5F5Kx6M14X53BChwDAnwTzsAbDG lpgR3mB/CAdkIxMyP6XIXHyZVLh1oqQ2fOZaqikIViigJdJ/5/HSkCldqOW6L6IhhDPV YxGhPYg4np3LNoZzkd7nKxg4jKH5RIZphAmhW3uoZsgHrV1hbS0EPzXQnN7Fu+lzerPH M52A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=PMdFq4l4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ga42si3223985ejc.8.2021.02.11.01.24.45; Thu, 11 Feb 2021 01:25:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=PMdFq4l4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230202AbhBKJXG (ORCPT + 99 others); Thu, 11 Feb 2021 04:23:06 -0500 Received: from smtprelay-out1.synopsys.com ([149.117.87.133]:56850 "EHLO smtprelay-out1.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230127AbhBKJOM (ORCPT ); Thu, 11 Feb 2021 04:14:12 -0500 Received: from mailhost.synopsys.com (mdc-mailhost2.synopsys.com [10.225.0.210]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id 27BDFC00CA; Thu, 11 Feb 2021 09:13:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1613034788; bh=71t8kLn/h4uRT+rZrsVOIM9WjcoyjC97XsyNd4xo0/8=; h=From:To:Subject:Date:In-Reply-To:References:In-Reply-To: References:From; b=PMdFq4l48rHZCDJtuBJTNQu+Z09YXDDTgYeN7vpI3w/vINgyYFu7TLychC9sdaClE 2KttkgdPORb6OQF4hPhnOmE6K/aWimZVQebSWh71RGQVMvCcPx0yBLNfeR0wfeVITa 0FlFviC0OxMGh/vd3GDNqD/pXjf6Urd6LZHZgey4vDfAfYSKoxRY4VWsB98MGr6t/6 CUpkAJXCpAPJkX0r+D5qYoTOlzqWa7JQkrNgSsf+vYIFZ/KgbTRbVvh2znZbTvVYWx 5Kg6BzlkA7pzGBKMspf9bjG5Pq0lxIu38ijtjxmfqz0E73bw39DbG44iB1iY9izJPP OFecFWiVjvLVQ== Received: from de02dwia024.internal.synopsys.com (de02dwia024.internal.synopsys.com [10.225.19.81]) by mailhost.synopsys.com (Postfix) with ESMTP id EC9A9A0063; Thu, 11 Feb 2021 09:13:06 +0000 (UTC) X-SNPS-Relay: synopsys.com From: Gustavo Pimentel To: dmaengine@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Vinod Koul , Dan Williams , Bjorn Helgaas , Gustavo Pimentel Subject: [PATCH v5 12/15] dmaengine: dw-edma: Fix crash on loading/unloading driver Date: Thu, 11 Feb 2021 10:12:45 +0100 Message-Id: <50d35480bcb5a7ea33649bbbcf296e148f5977b5.1613034728.git.gustavo.pimentel@synopsys.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When the driver is compiled as a module and loaded if we try to unload it, the Kernel shows a crash log. This Kernel crash is due to the dma_async_device_unregister() call done after deleting the channels, this patch fixes this issue. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c index 8d8292e..f7a1930 100644 --- a/drivers/dma/dw-edma/dw-edma-core.c +++ b/drivers/dma/dw-edma/dw-edma-core.c @@ -986,22 +986,21 @@ int dw_edma_remove(struct dw_edma_chip *chip) /* Power management */ pm_runtime_disable(dev); + /* Deregister eDMA device */ + dma_async_device_unregister(&dw->wr_edma); list_for_each_entry_safe(chan, _chan, &dw->wr_edma.channels, vc.chan.device_node) { - list_del(&chan->vc.chan.device_node); tasklet_kill(&chan->vc.task); + list_del(&chan->vc.chan.device_node); } + dma_async_device_unregister(&dw->rd_edma); list_for_each_entry_safe(chan, _chan, &dw->rd_edma.channels, vc.chan.device_node) { - list_del(&chan->vc.chan.device_node); tasklet_kill(&chan->vc.task); + list_del(&chan->vc.chan.device_node); } - /* Deregister eDMA device */ - dma_async_device_unregister(&dw->wr_edma); - dma_async_device_unregister(&dw->rd_edma); - /* Turn debugfs off */ dw_edma_v0_core_debugfs_off(chip); -- 2.7.4