Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2000764pxb; Thu, 11 Feb 2021 01:27:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJwUyq7fUstmP8faBZDR87W+S1WqcraacyUb1kMroGtkXQQ/QpIhscNKfpR6/rSKqKxfTew3 X-Received: by 2002:aa7:d60f:: with SMTP id c15mr7528480edr.291.1613035628154; Thu, 11 Feb 2021 01:27:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613035628; cv=none; d=google.com; s=arc-20160816; b=caUHAykZ/8E8bcJVRbWFv/RduqZ3ULeESN0Yz4W5gg7BaUYFy1qoCGJSdI9dBknRhK 7B9kaB5V9Y9+X8j/WsqotdDKtkc6621PxkSbWhoMQ7UWdbffjaTU18/mqjBnpSTMlBMj qb86PQkdU8fT4X0KPMFO21g4rvalhvyq2UdPCi741r+Gm8OeDi1TzxKN/nu2I8t/IRsu NrAscoJc5hVvTM+w2eNJg/YBQPF+Vlp2Ad9XcY/QdC7NwyW4hGEIOiVOjBhPuWKHOMmD 03gG7dQp6qcRCVHmMnd8M0sdvoU82rZsOyLmzjLN9U549cKlcV+DgE7iMM8KyQL9znQx rI9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:references:in-reply-to :message-id:date:subject:to:from:dkim-signature; bh=pCyObRoYs4TuqGUabO/rMbP3htemyH/3g4S6VzT5G0o=; b=QiO9LV/o+bT1Kl/zPobNYPoEyDFgN+q1O66UrrGkntGzDlLsRoyC1+wsMZ3KH/DZmJ wQHuJsoTd/VhnG9QvcemZWZwJ0kbdxqHjbMRq5yU+0CHkqnBYRJ1yP/0nriiOjQvatL8 Kd5BVppBKQ7j5+ia8mLfnGraZAlIbE5J8Mvl38Tu5fhlW7U7PdMQN8OsPZ1JU0reIFDS Ap04Dq0H821teLyDsCflKDsvzN3gRX3A1EmFp82Q9/VS7sm1vj0jXZRxjgzoF/ID2Q5d YDZ8hQBrwtAapUYYywMC4rpMSPYjGLkZ2qcSl0Lcd2vMlC/BjC2Gn/9vRL6CaBxyLjFR c4aQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=coTZadI0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j3si3459508ejy.648.2021.02.11.01.26.45; Thu, 11 Feb 2021 01:27:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=coTZadI0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229890AbhBKJYx (ORCPT + 99 others); Thu, 11 Feb 2021 04:24:53 -0500 Received: from smtprelay-out1.synopsys.com ([149.117.73.133]:34212 "EHLO smtprelay-out1.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230122AbhBKJOM (ORCPT ); Thu, 11 Feb 2021 04:14:12 -0500 Received: from mailhost.synopsys.com (mdc-mailhost2.synopsys.com [10.225.0.210]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id A8549401F1; Thu, 11 Feb 2021 09:13:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1613034790; bh=RPtJq9pnB6c2RL81eMcBv6mkc0ffZocP1N1iwYCqspQ=; h=From:To:Subject:Date:In-Reply-To:References:In-Reply-To: References:From; b=coTZadI0kWag63lGZFPytTbIMupuC0Evzlw8SfWWC17UTAzzdFVbu14TRMLUKd3DL 9t7R7+RVdYGtETu4k6HSi1+QblYB1seDPZcvum3DsRSjOJnqQtRr9FBcAqHD0fN9li IYehJOmU2ARDPU+8noTM3l/7Hjm1Rj/PYhaS2/UIrjQu1Ad9QyRHv6XFfMFTqTkA1H uQ22d4P3kOF3JBrt4S55QUuX3tLiWoAA79vXDa1ExFkLaABOe9j/WWWD0//peKpk3o zas4p8p6QR9HOeenolLpFy45MlRf7Y3DOk4RsNaSY5wodUoJVkZtZiklVj68IGhYsh ooekE1C2lDymQ== Received: from de02dwia024.internal.synopsys.com (de02dwia024.internal.synopsys.com [10.225.19.81]) by mailhost.synopsys.com (Postfix) with ESMTP id 725ACA005D; Thu, 11 Feb 2021 09:13:09 +0000 (UTC) X-SNPS-Relay: synopsys.com From: Gustavo Pimentel To: dmaengine@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Vinod Koul , Dan Williams , Bjorn Helgaas , Gustavo Pimentel Subject: [PATCH v5 15/15] dmaengine: dw-edma: Add pcim_iomap_table return check Date: Thu, 11 Feb 2021 10:12:48 +0100 Message-Id: <9deab3ffcc179c4bddd84459ed2a472ca73019fb.1613034728.git.gustavo.pimentel@synopsys.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Detected by CoverityScan CID 16555 ("Dereference null return") Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-pcie.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c index 686b4ff..7445033 100644 --- a/drivers/dma/dw-edma/dw-edma-pcie.c +++ b/drivers/dma/dw-edma/dw-edma-pcie.c @@ -238,6 +238,9 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, dw->rd_ch_cnt = vsec_data.rd_ch_cnt; dw->rg_region.vaddr = pcim_iomap_table(pdev)[vsec_data.rg.bar]; + if (!dw->rg_region.vaddr) + return -ENOMEM; + dw->rg_region.vaddr += vsec_data.rg.off; dw->rg_region.paddr = pdev->resource[vsec_data.rg.bar].start; dw->rg_region.paddr += vsec_data.rg.off; @@ -250,12 +253,18 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, struct dw_edma_block *dt_block = &vsec_data.dt_wr[i]; ll_region->vaddr = pcim_iomap_table(pdev)[ll_block->bar]; + if (!ll_region->vaddr) + return -ENOMEM; + ll_region->vaddr += ll_block->off; ll_region->paddr = pdev->resource[ll_block->bar].start; ll_region->paddr += ll_block->off; ll_region->sz = ll_block->sz; dt_region->vaddr = pcim_iomap_table(pdev)[dt_block->bar]; + if (!dt_region->vaddr) + return -ENOMEM; + dt_region->vaddr += dt_block->off; dt_region->paddr = pdev->resource[dt_block->bar].start; dt_region->paddr += dt_block->off; @@ -269,12 +278,18 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, struct dw_edma_block *dt_block = &vsec_data.dt_rd[i]; ll_region->vaddr = pcim_iomap_table(pdev)[ll_block->bar]; + if (!ll_region->vaddr) + return -ENOMEM; + ll_region->vaddr += ll_block->off; ll_region->paddr = pdev->resource[ll_block->bar].start; ll_region->paddr += ll_block->off; ll_region->sz = ll_block->sz; dt_region->vaddr = pcim_iomap_table(pdev)[dt_block->bar]; + if (!dt_region->vaddr) + return -ENOMEM; + dt_region->vaddr += dt_block->off; dt_region->paddr = pdev->resource[dt_block->bar].start; dt_region->paddr += dt_block->off; -- 2.7.4