Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2032157pxb; Thu, 11 Feb 2021 02:29:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJwHnW42wDtjcO6V/7FJFhSHaaADzjlUYwfWdqvN3gB2cLVOWyVmKosuaR3ahGxIIsZqIlef X-Received: by 2002:a05:6402:164a:: with SMTP id s10mr7783892edx.37.1613039380901; Thu, 11 Feb 2021 02:29:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613039380; cv=none; d=google.com; s=arc-20160816; b=ZjDMj6q7/hlIW9BXy7OUBVjeXyho88h0/wPn25A9OGgQk0iICgHTlVslsF4EKRdirr uPa+FSePUx6dKPTnGPIp3HGzq0sMvLqrLPSE3KvP69up9JlvnFn060XMzk3vAihhSg4h bD0QTwQbyOA3JAe0vbE2il+BsxdrI/06i+DnZO3Nb3q6LS6q9XEVqTzideiA3MrnVmS9 RIW2+cxYYDlyH5M0tRSk9lguyvoSCYQciUK3u6KFFqDMWXPmVEfqJ0oZ/+xv4/ww32+X vDTtbMnMX/joR5jgxpXjtbIxdb/eBUBGQfbsHJ8HUJsQGGKRTtGMIxPNG8UcA2Xj/cQe FO0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=SljrkEVHDmi6xA8MKmgtTpSTzDd2Vz3b1ust/JTNqig=; b=wp2hp+Cy72CrxceZ4NK2tgVVYke5pZfMYyp39IiACWH8ifeUU/QUqYOMQtGMG0Oi6V CPWh2c22wFv0adMK0vK2Yy6ndKYRboAWmhcHLb5UJWcS4u2Z/lzI2X4YC4PmKu5jxPZq pkWIECnk/PP9CvLZp/ZeMZ0Aw8ICVSnrxtY4fvcoU0ZbdDZqtpdKc44sV+/VrR0KZ/VD ZS9t/lCehibpSraF+5oYMs4Xm0lu9i1X/RPN7mNeLLGeMFaZdReTIFKyl7LXh2UuPfma DC3YhAwKl0DxH0l2Tp4r4XkRwOMsurUs3bwl+a2Ffg7RV+l9vxvWzuvfRA0r4dRHsG/E 7WtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=MMLGArFd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z24si4494712edl.286.2021.02.11.02.29.17; Thu, 11 Feb 2021 02:29:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=MMLGArFd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230097AbhBKK1Z (ORCPT + 99 others); Thu, 11 Feb 2021 05:27:25 -0500 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:10430 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230138AbhBKKVy (ORCPT ); Thu, 11 Feb 2021 05:21:54 -0500 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 11 Feb 2021 02:21:08 -0800 Received: from [10.26.49.8] (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 11 Feb 2021 10:21:05 +0000 Subject: Re: phy_attach_direct()'s use of device_bind_driver() To: Andrew Lunn , Saravana Kannan CC: Heiner Kallweit , Russell King , "David S. Miller" , "Jakub Kicinski" , Android Kernel Team , netdev , LKML , "Thierry Reding" References: From: Jon Hunter Message-ID: <5176f496-facb-d7b0-9f4e-a9e4b8974178@nvidia.com> Date: Thu, 11 Feb 2021 10:21:03 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1613038868; bh=SljrkEVHDmi6xA8MKmgtTpSTzDd2Vz3b1ust/JTNqig=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=MMLGArFdzoF7FHQjCanG/GBKSJ8WlQ7YLkM32dEFhchpZoW9/o101ST5rm75hv+L9 kpnX0wl0z1rcR24xBTLWbP1IPfRFZ3NPSn5uWW3SU4q6T8stbnSXoSFS3U7sBKkgwp 3XER6VJFs/QntXgvrayXvvhvWfjnxMObN3mzLj6Z973RkR2QfFkBdAGmDRtYLYZqRy 43zKexpg8HdHEz7aqtaltdd8KVmkg/1yPetg/56/sRGDSVKe3UnlagVLVYRfBAY0gs d2hVqjzoP/Cj7H2soWLdM3Gk3Wd1XocsYQd/llYk+hn8d6Igk5NkU4tXV9QHsqDI9i 8Q8OxTYNZ+giw== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/02/2021 22:56, Andrew Lunn wrote: > On Wed, Feb 10, 2021 at 02:13:48PM -0800, Saravana Kannan wrote: >> Hi, >> >> This email was triggered by this other email[1]. > > And it appears the Tegra194 Jetson Xavier uses the Marvell 88E1512 > PHY. So ensure the Marvell driver is available, and it should get > probed in the usual way, the fallback driver will not be needed. Yes that is correct. Enabling the Marvell PHY does fix this indeed and so I can enable that as part of our testsuite. We were seeing the same warning on Tegra186 Jetson TX2 and enabling the BRCM PHY resolves that as well. I will ensure that these are enabled going forward. Cheers Jon -- nvpublic