Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Stefan Chulski <stefanc@marvell.com>
To:     Russell King - ARM Linux admin <linux@armlinux.org.uk>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        Nadav Haklai <nadavh@marvell.com>,
        Yan Markman <ymarkman@marvell.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "mw@semihalf.com" <mw@semihalf.com>,
        "andrew@lunn.ch" <andrew@lunn.ch>,
        "atenart@kernel.org" <atenart@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "sebastian.hesselbarth@gmail.com" <sebastian.hesselbarth@gmail.com>,
        "gregory.clement@bootlin.com" <gregory.clement@bootlin.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [EXT] Re: [PATCH v13 net-next 04/15] net: mvpp2: always compare
 hw-version vs MVPP21
Thread-Topic: [EXT] Re: [PATCH v13 net-next 04/15] net: mvpp2: always compare
 hw-version vs MVPP21
Thread-Index: AQHXAGPDLx0+FHN2skmP52dC0FnhKKpSy5SAgAAAS5A=
Date:   Thu, 11 Feb 2021 11:10:23 +0000
Message-ID: <CO6PR18MB3873C8DBA4B12A8E859A7598B08C9@CO6PR18MB3873.namprd18.prod.outlook.com>
References: <1613040542-16500-1-git-send-email-stefanc@marvell.com>
 <1613040542-16500-5-git-send-email-stefanc@marvell.com>
 <20210211110809.GB1463@shell.armlinux.org.uk>
In-Reply-To: <20210211110809.GB1463@shell.armlinux.org.uk>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 367e0795-c1f3-4f69-3787-08d8ce7da100
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2021 11:10:23.9269
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PN31iiREet/Ts1ctJWenz0Ckoeq4RWWEfh4E2EDjrsyoaoARWok1XH2KYKTc2p+LTHlqUveWooBPY4yllRzBUg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR18MB1488
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.737
 definitions=2021-02-11_05:2021-02-10,2021-02-11 signatures=0
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Thu, Feb 11, 2021 at 12:48:51PM +0200, stefanc@marvell.com wrote:
> > @@ -1199,7 +1199,7 @@ static bool mvpp2_port_supports_xlg(struct
> > mvpp2_port *port)
> >
> >  static bool mvpp2_port_supports_rgmii(struct mvpp2_port *port)  {
> > -	return !(port->priv->hw_version =3D=3D MVPP22 && port->gop_id =3D=3D =
0);
> > +	return !(port->priv->hw_version !=3D MVPP21 && port->gop_id =3D=3D 0)=
;
>=20
> I'm still very much of the opinion (as raised several revisions back) tha=
t using
> > MVPP21 or >=3D MVPP22 would be a lot better - especially when we have
> situations like this. Having negatives within negatives does not help
> readability.


Ok, I would update in next series.

Thanks,
Stefan