Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] pinctrl: imx: imx8mm: fix pad offset of SD1_DATA0 pin
To:     Frieder Schrempf <frieder.schrempf@kontron.de>,
        Claudius Heine <ch@denx.de>, Rob Herring <robh+dt@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20210211095413.1043102-1-ch@denx.de>
 <03ac353d-e7a1-5235-a787-21014d0c7607@kontron.de>
From:   Marek Vasut <marex@denx.de>
Message-ID: <675ce5b7-1854-e168-55e4-1db90adce0a1@denx.de>
Date:   Thu, 11 Feb 2021 12:20:48 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.0
MIME-Version: 1.0
In-Reply-To: <03ac353d-e7a1-5235-a787-21014d0c7607@kontron.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/11/21 11:17 AM, Frieder Schrempf wrote:
> On 11.02.21 10:54, Claudius Heine wrote:
>> There is a 0 missing in the pad register offset. This patch adds it.
>>
>> Signed-off-by: Claudius Heine <ch@denx.de>
> 
> I think this should rather be prefixed by "arm64: dts: imx8mm:" as this 
> is no change in the pinctrl driver, but only in the devicetree.
> 
> And I guess this deserves a "Fixes" and "Cc: stable" tag, so:
> 
> Fixes: c1c9d41319c3 ("dt-bindings: imx: Add pinctrl binding doc for 
> imx8mm")
> Cc: stable@vger.kernel.org
> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>

Indeed.

But since this isn't the first such fix, I wonder whether it wouldn't be 
a good idea to regenerate those pinctrl tables and see whether there are 
any other such issues in them. I wonder, is there some sort of register 
and bit list in machine-parseable form for the MX8M ?