Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Stefan Chulski <stefanc@marvell.com>
To:     Russell King - ARM Linux admin <linux@armlinux.org.uk>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        Nadav Haklai <nadavh@marvell.com>,
        Yan Markman <ymarkman@marvell.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "mw@semihalf.com" <mw@semihalf.com>,
        "andrew@lunn.ch" <andrew@lunn.ch>,
        "atenart@kernel.org" <atenart@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "sebastian.hesselbarth@gmail.com" <sebastian.hesselbarth@gmail.com>,
        "gregory.clement@bootlin.com" <gregory.clement@bootlin.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [EXT] Re: [PATCH v13 net-next 05/15] net: mvpp2: add PPv23
 version definition
Thread-Topic: [EXT] Re: [PATCH v13 net-next 05/15] net: mvpp2: add PPv23
 version definition
Thread-Index: AQHXAGPWXLwlpUz4Jka63qgQr+Wit6pS1TYAgAABjpA=
Date:   Thu, 11 Feb 2021 11:49:25 +0000
Message-ID: <CO6PR18MB38739CA874F3748919C8361CB08C9@CO6PR18MB3873.namprd18.prod.outlook.com>
References: <1613040542-16500-1-git-send-email-stefanc@marvell.com>
 <1613040542-16500-6-git-send-email-stefanc@marvell.com>
 <20210211114238.GD1463@shell.armlinux.org.uk>
In-Reply-To: <20210211114238.GD1463@shell.armlinux.org.uk>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e71256e-3fc9-4a7a-9bce-08d8ce831492
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2021 11:49:25.3089
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GjKLNWnJc/6JXYb68QiEIiQpGdaecoXYtHZ4jwINBECyMQcb0OgCR8/SxEywGtP6AlkXwvTxZ1pzl/qMJ9eT/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR18MB3514
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.737
 definitions=2021-02-11_05:2021-02-10,2021-02-11 signatures=0
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> ----------------------------------------------------------------------
> On Thu, Feb 11, 2021 at 12:48:52PM +0200, stefanc@marvell.com wrote:
> > From: Stefan Chulski <stefanc@marvell.com>
> >
> > This patch add PPv23 version definition.
> > PPv23 is new packet processor in CP115.
> > Everything that supported by PPv22, also supported by PPv23.
> > No functional changes in this stage.
> >
> > Signed-off-by: Stefan Chulski <stefanc@marvell.com>
> > Acked-by: Marcin Wojtas <mw@semihalf.com>
>=20
> Reviewed-by: Russell King <rmk+kernel@armlinux.org.uk>
>=20
> > @@ -7049,6 +7049,11 @@ static int mvpp2_probe(struct platform_device
> *pdev)
> >  			priv->port_map |=3D BIT(i);
> >  	}
> >
> > +	if (priv->hw_version !=3D MVPP21) {
> > +		if (mvpp2_read(priv, MVPP2_VER_ID_REG) =3D=3D
> MVPP2_VER_PP23)
> > +			priv->hw_version =3D MVPP23;
> > +	}
> > +
>=20
> The only minor comment I have on this is... the formatting of the above.
> Wouldn't:
>=20
> 	if (priv->hw_version >=3D MVPP22 &&
> 	    mvpp2_read(priv, MVPP2_VER_ID_REG) =3D=3D MVPP2_VER_PP23)
> 		priv->hw_version =3D MVPP23;
>=20
> read better?
>=20
> Do we need to even check priv->hw_version here? Isn't this register
> implemented in PPv2.1 where it contains the value zero?

Yes, we can just:
 	if (mvpp2_read(priv, MVPP2_VER_ID_REG) =3D=3D MVPP2_VER_PP23)
 		priv->hw_version =3D MVPP23;

Thanks,
Stefan.