Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2099688pxb; Thu, 11 Feb 2021 04:29:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJy+b4QNkupLkDWPJZ2gmSNcH97QZ2kWmM0V23LlZZ1jaGixcDpxp4MR7jPSvfb7SZmSVWdB X-Received: by 2002:a17:906:af86:: with SMTP id mj6mr8280853ejb.509.1613046593189; Thu, 11 Feb 2021 04:29:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613046593; cv=none; d=google.com; s=arc-20160816; b=Lh82hETPKl7w1zriYDaVz/yftUjOIU0fzDaBJLJh9zVhNZNVul/udNiNMT/+yIXz5b pvZI00dVM6B0I9MBtDMKiZhy+f8lf3b1gzGJrA1/v0/4jWwoWhwUDAX8ocF3JGnHqjRf 27Hd4zJiwbfroEKhSf0q9MgZCDk8ynD3c31f0IpkZLFNRPwtW0ORRmAloHolAVugUZXZ 5btJXCbUv7GrOkT+5/sYWPWw8uqWLSU6z5RGBOSU+0f3QizVMIn0q27BhgzgI5qaoG4t ebvZ6HfZpPe0yZku6WCYik7fJytaRi+cZhdPhfpRjevCt2GSx4OArM0s68b3r3C6xH8V YifQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=LMR7gu4BhtwJQ85ih0F1WtLfDgjmoVB7dObeuqGXrtQ=; b=XWLbha0By2aOvaXJ0SUBkQkWg1XCy5ZTdpQ0lk9qQxNm/r64wnE3aOnaK/zt7XwayA fos+VhphI/gdRl6zf3OVwHddx0C9T/TfCTQH2I6rKN/GRj0qolIIHuy1WwHg+wOPkDqy X2p3fbzyZ82wgoeW8+6zVYbAbYbfJxuSLHkCSDJe83+shZeDhi8ozT2KCNSJm6PO9l8h vJtXUjVss4rNNczAAwQJIH6HneiJOuSH+QryJikGaXOrEZqzD23BADxLIC1XF+ATc6td ram5Sv4T8XVU95CmapTD0lhk8+37QgMqgbp3XiCoFxKjP1gRs5ASv9u80ugxeSZp4kgz 5n2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=analog.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e1si3521033eja.255.2021.02.11.04.29.29; Thu, 11 Feb 2021 04:29:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=analog.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229683AbhBKM2n (ORCPT + 99 others); Thu, 11 Feb 2021 07:28:43 -0500 Received: from mx0a-00128a01.pphosted.com ([148.163.135.77]:15650 "EHLO mx0a-00128a01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231954AbhBKMXm (ORCPT ); Thu, 11 Feb 2021 07:23:42 -0500 Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 11BCMfr6016212; Thu, 11 Feb 2021 07:22:46 -0500 Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com with ESMTP id 36hr7qg8vg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 Feb 2021 07:22:46 -0500 Received: from SCSQMBX11.ad.analog.com (SCSQMBX11.ad.analog.com [10.77.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 11BCMin5004525 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=FAIL); Thu, 11 Feb 2021 07:22:45 -0500 Received: from SCSQCASHYB6.ad.analog.com (10.77.17.132) by SCSQMBX11.ad.analog.com (10.77.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1779.2; Thu, 11 Feb 2021 04:22:43 -0800 Received: from SCSQMBX10.ad.analog.com (10.77.17.5) by SCSQCASHYB6.ad.analog.com (10.77.17.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.721.2; Thu, 11 Feb 2021 04:22:43 -0800 Received: from zeus.spd.analog.com (10.66.68.11) by scsqmbx10.ad.analog.com (10.77.17.5) with Microsoft SMTP Server id 15.2.721.2 via Frontend Transport; Thu, 11 Feb 2021 04:22:43 -0800 Received: from localhost.localdomain ([10.48.65.12]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 11BCMYWb011557; Thu, 11 Feb 2021 07:22:40 -0500 From: Alexandru Ardelean To: , CC: , , , , , , , Alexandru Ardelean Subject: [PATCH v5 03/17] iio: core-trigger: make iio_device_register_trigger_consumer() an int return Date: Thu, 11 Feb 2021 14:24:38 +0200 Message-ID: <20210211122452.78106-4-alexandru.ardelean@analog.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210211122452.78106-1-alexandru.ardelean@analog.com> References: <20210211122452.78106-1-alexandru.ardelean@analog.com> MIME-Version: 1.0 Content-Type: text/plain X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.737 definitions=2021-02-11_05:2021-02-10,2021-02-11 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 lowpriorityscore=0 malwarescore=0 clxscore=1015 spamscore=0 phishscore=0 suspectscore=0 mlxscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102110110 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Oddly enough the noop function is an int-return. This one seems to be void. This change converts it to int, because we want to change how groups are registered. With that change this function could error out with -ENOMEM. Signed-off-by: Alexandru Ardelean --- drivers/iio/iio_core_trigger.h | 4 +++- drivers/iio/industrialio-trigger.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/iio/iio_core_trigger.h b/drivers/iio/iio_core_trigger.h index 374816bc3e73..e1a56824e07f 100644 --- a/drivers/iio/iio_core_trigger.h +++ b/drivers/iio/iio_core_trigger.h @@ -9,8 +9,10 @@ /** * iio_device_register_trigger_consumer() - set up an iio_dev to use triggers * @indio_dev: iio_dev associated with the device that will consume the trigger + * + * Return 0 if successful, negative otherwise **/ -void iio_device_register_trigger_consumer(struct iio_dev *indio_dev); +int iio_device_register_trigger_consumer(struct iio_dev *indio_dev); /** * iio_device_unregister_trigger_consumer() - reverse the registration process diff --git a/drivers/iio/industrialio-trigger.c b/drivers/iio/industrialio-trigger.c index ea3c9859b258..438d5012e8b8 100644 --- a/drivers/iio/industrialio-trigger.c +++ b/drivers/iio/industrialio-trigger.c @@ -692,10 +692,12 @@ int iio_trigger_validate_own_device(struct iio_trigger *trig, } EXPORT_SYMBOL(iio_trigger_validate_own_device); -void iio_device_register_trigger_consumer(struct iio_dev *indio_dev) +int iio_device_register_trigger_consumer(struct iio_dev *indio_dev) { indio_dev->groups[indio_dev->groupcounter++] = &iio_trigger_consumer_attr_group; + + return 0; } void iio_device_unregister_trigger_consumer(struct iio_dev *indio_dev) -- 2.17.1