Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 55ObIwXXP7Ce+w74u2c3hDjZHO3GcWqkMcBtUfKazDIngzn3bigOULlPiVf33d343Cd0zZqqMH
 iLmcAyNdWchw==
IronPort-SDR: xmlb9NqFgliArX/nIyV1XOP5dZrVm+iMz+ouoHhFVFin0OJO3ifO98hiQVCt3vuiEQ6czA0zcz
 eIuL75rTI65g==
Date:   Thu, 11 Feb 2021 15:04:47 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Maximilian Luz <luzmaximilian@gmail.com>
Cc:     Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <mgross@linux.intel.com>,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-test-robot <lkp@intel.com>
Subject: Re: [PATCH] platform/surface: aggregator: Fix access of unaligned
 value
Message-ID: <YCUrb+yAdBCagxvv@smile.fi.intel.com>
References: <20210210230411.1938660-1-luzmaximilian@gmail.com>
 <YCUFgF9gmyeO+796@smile.fi.intel.com>
 <b68b7547-5be4-c823-d015-febb5e7f84e9@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b68b7547-5be4-c823-d015-febb5e7f84e9@gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Thu, Feb 11, 2021 at 12:58:48PM +0100, Maximilian Luz wrote:
> On 2/11/21 11:22 AM, Andy Shevchenko wrote:
> > On Thu, Feb 11, 2021 at 12:04:11AM +0100, Maximilian Luz wrote:
> > > The raw message frame length is unaligned and explicitly marked as
> > > little endian. It should not be accessed without the appropriatte
> > > accessor functions. Fix this.

...

> > Also it's possible to annotate temporary variable and use it, but it seems not
> > worth to do.
> 
> Now that you mention it, we already have the correct frame length in
> payload.len. Let me draft up a new patch with that.

Good!

> > Side question: Do you think the below is correct (& operator)?
> > 
> >          sp.len = get_unaligned_le16(&((struct ssh_frame *)sf.ptr)->len);
> > 
> > To me seems like you take an address to len member rather its value.
> 
> That's the point though, no? The signature is
> 
>         u16 get_unaligned_le16(const void *p)
> 
> so we do want a pointer to the len member. So I believe that is correct.

Indeed. I messed up with le16_to_cpu().

-- 
With Best Regards,
Andy Shevchenko