Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Stefan Chulski <stefanc@marvell.com>
To:     Russell King - ARM Linux admin <linux@armlinux.org.uk>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        Nadav Haklai <nadavh@marvell.com>,
        Yan Markman <ymarkman@marvell.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "mw@semihalf.com" <mw@semihalf.com>,
        "andrew@lunn.ch" <andrew@lunn.ch>,
        "atenart@kernel.org" <atenart@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "sebastian.hesselbarth@gmail.com" <sebastian.hesselbarth@gmail.com>,
        "gregory.clement@bootlin.com" <gregory.clement@bootlin.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [EXT] Re: [PATCH v13 net-next 13/15] net: mvpp2: add PPv23 RX
 FIFO flow control
Thread-Topic: [EXT] Re: [PATCH v13 net-next 13/15] net: mvpp2: add PPv23 RX
 FIFO flow control
Thread-Index: AQHXAGQqIV7fN4UI+Ey/TvFhB0myCKpS6bwAgAACqfA=
Date:   Thu, 11 Feb 2021 13:06:41 +0000
Message-ID: <CO6PR18MB3873E18A4761D8DCB6D4300FB08C9@CO6PR18MB3873.namprd18.prod.outlook.com>
References: <1613040542-16500-1-git-send-email-stefanc@marvell.com>
 <1613040542-16500-14-git-send-email-stefanc@marvell.com>
 <20210211125606.GH1463@shell.armlinux.org.uk>
In-Reply-To: <20210211125606.GH1463@shell.armlinux.org.uk>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 83380dfd-7ef5-40a8-0f97-08d8ce8de031
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2021 13:06:41.8732
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: h/sfSd0sh6eb3qx+Tm6/+DE5QBwToC3l2mkweyjOI+YcBQiIV4PN9jOgBTOrmYvBczOjRZBKn01KZikX5eT5IA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR18MB3561
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.737
 definitions=2021-02-11_06:2021-02-10,2021-02-11 signatures=0
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> > +/* Configure Rx FIFO Flow control thresholds */ void
> > +mvpp23_rx_fifo_fc_en(struct mvpp2 *priv, int port, bool en) {
> > +	int val;
>=20
> 	u32 ?

OK.

> > +
> > +	val =3D mvpp2_read(priv, MVPP2_RX_FC_REG(port));
> > +
> > +	if (en)
> > +		val |=3D MVPP2_RX_FC_EN;
> > +	else
> > +		val &=3D ~MVPP2_RX_FC_EN;
> > +
> > +	mvpp2_write(priv, MVPP2_RX_FC_REG(port), val);
>=20
> 	if (en)
> 		val =3D MVPP2_RX_FC_EN;
> 	else
> 		val =3D 0;
>=20
> 	mvpp2_modify(priv + MVPP2_RX_FC_REG(port),
> MVPP2_RX_FC_EN, val);
>=20
> ?

OK, I would use mvpp2_modify Here.

Thanks,
Stefan.