Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2180019pxb; Thu, 11 Feb 2021 06:26:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJwgGC0b8PTbkJAioqPS7qHhOomZ7otFIYeTqtOc9FlQRBX9VwerftYjPNmpcD2PP+XKPq6H X-Received: by 2002:a17:906:af41:: with SMTP id ly1mr8435777ejb.525.1613053596412; Thu, 11 Feb 2021 06:26:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613053596; cv=none; d=google.com; s=arc-20160816; b=qDRJmK7gtDEs3CKIf8cRBVvbs07ce7j2SZshagQngUXh9v7TAGuzpWimpnjYZcmCsf zz8K0+PRpIysEJdUPJcynxe43LpXK9MJ3Gqf3VbQSpvrQqa/HYlP53dVfxXavWyie85O duGwpdj0jNZW06U3Bxx47AMRDbXzqk+Z+LBlbwnhqNWKQh2gTmzpguIoIeyoiBdhRZfu bMQ/mn3uNNhE1cF9x75Cqp45WsKp9SIdEeTlHa3XalHJ7gmlY9gR4XChkan6ldU1rMtz znLDSnWnSsl71+xhOcJZAuBueytgvYjm5z/JGXbhc7gtwS1CuDxbUBauU3t+KMPprhEo WU6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:thread-index:content-language :content-transfer-encoding:mime-version:message-id:date:subject :in-reply-to:references:cc:to:reply-to:from:dkim-signature; bh=NqJl+7VgG2HfaF9Ked4qUIjOghassFCSe0BNnEt7qj8=; b=ccOYKz8/Dj8lkFcRG+HmArAeuzURRQZaRILqRfYDSfkiGTuiUTtD4pXVAj9V0uI/6R LzbY8Cxd9H5SPj9o5XyNLnflNmUvDXj8LPoPa41NBjKTULC9pWM8aMFGOa7bC1nGjrdr ZU2R6PospeIDbk8whs5tmGpqq+MycfA7gQfcuQK+aVrhbq2yMYYj6TVLt1X44vnguhIy hFV5kG1p14wLzTNaANfGxMD4Jwi2YDt5XnQvyvoVMhqxLBwX7wj+Z4lBjJ3lVfrKOrxy csZQOH4yzNoCqKLAxtOhwUIyLISp9DdFp0RyADOjOhdVr9/pxtqQ86NpU28XUHL0LBGK yCoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=mPb+s7DI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s15si3812286edq.605.2021.02.11.06.26.05; Thu, 11 Feb 2021 06:26:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=mPb+s7DI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230386AbhBKOZL (ORCPT + 99 others); Thu, 11 Feb 2021 09:25:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232106AbhBKOPq (ORCPT ); Thu, 11 Feb 2021 09:15:46 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 030E2C061574; Thu, 11 Feb 2021 06:15:05 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id u14so5897532wmq.4; Thu, 11 Feb 2021 06:15:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=NqJl+7VgG2HfaF9Ked4qUIjOghassFCSe0BNnEt7qj8=; b=mPb+s7DITo6YbAtQjaqPCEBNGHpfyHFE4s9EjjWPnx5M8SIZYlPQ9vx4O6elsYgKPY +Ej7zP1LSif9NfKboWhGb5BXjisNCMPjXtL6b6THXoqm+F/neJTqbQzUUtQollpmiZdt IUpDSRHAT0zzr2yZuzdKroI87pI9a3TqJ1V/ihNLDVMzh1o79Q3Yfok7RhPlJwGA0Vak jyLyfyiNscakfPrS2GE8hoP64a9C1ODvEonaJRDa/Qqf7MTD3wXuZiVFOvjueTst8tll dZ4VqQdHT0ZLYLZTiuJ0Vy8rhIKV3NfpDzpEK2NmonwJVvCyCILbpuBN7xyALDZbqf9v ZBXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :content-language:thread-index; bh=NqJl+7VgG2HfaF9Ked4qUIjOghassFCSe0BNnEt7qj8=; b=FBHGT0f/H8D3Y4OzzM3y8nTEcxahvd1X80nsX2YaGapOb94SLW2NHYQaVPUVlzAWHO sYsAIFir/kEijn37a9SIR0EkRMNnnMaqBOv+Q2o0zWV76NxKlUQ4z2Sp55iEKlus914x +QpYWggmMs+1AopI/g8xWvos6BDxcDot+HXgel4eqC9ZPIaKMv4R2u40TvJgVz1TnGz3 7hXQwPqoMjSbi1mcz0IVd4OP6VeLBWIbd2aZ5NOG2c/GOnsYd3X7ONB5+ddfQB9mYCcX 60rMmWLNZx226TBhJgYT8Cm8pmlJAM2ajvW/CnIXTpCtAqhPDBHGrbgo1T5ND/dOrXMm WACg== X-Gm-Message-State: AOAM533pL0966mFhTerYWTyBw1m88QXORJ/fVYKM0JjU33Fs5u/M+4/2 Z//lzePGvYQTvsKzK+TR2QLs6CR96aukMw== X-Received: by 2002:a1c:6a09:: with SMTP id f9mr5485740wmc.104.1613052903733; Thu, 11 Feb 2021 06:15:03 -0800 (PST) Received: from CBGR90WXYV0 ([2a00:23c5:5785:9a01:f088:412:4748:4eb1]) by smtp.gmail.com with ESMTPSA id f2sm5093215wrt.7.2021.02.11.06.15.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Feb 2021 06:15:03 -0800 (PST) From: Paul Durrant X-Google-Original-From: "Paul Durrant" Reply-To: To: "'Juergen Gross'" , , , Cc: "'Wei Liu'" , "'David S. Miller'" , "'Jakub Kicinski'" References: <20210211101616.13788-1-jgross@suse.com> <20210211101616.13788-5-jgross@suse.com> In-Reply-To: <20210211101616.13788-5-jgross@suse.com> Subject: RE: [PATCH v2 4/8] xen/netback: fix spurious event detection for common event case Date: Thu, 11 Feb 2021 14:15:02 -0000 Message-ID: <001d01d70080$4a5446d0$defcd470$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: en-gb Thread-Index: AQJuRSjpYwlLGVvLkRJGigHTv/cnpwJEXRo/qRJS+MA= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Juergen Gross > Sent: 11 February 2021 10:16 > To: xen-devel@lists.xenproject.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org > Cc: Juergen Gross ; Wei Liu ; Paul Durrant ; David > S. Miller ; Jakub Kicinski > Subject: [PATCH v2 4/8] xen/netback: fix spurious event detection for common event case > > In case of a common event for rx and tx queue the event should be > regarded to be spurious if no rx and no tx requests are pending. > > Unfortunately the condition for testing that is wrong causing to > decide a event being spurious if no rx OR no tx requests are > pending. > > Fix that plus using local variables for rx/tx pending indicators in > order to split function calls and if condition. > Definitely neater. > Fixes: 23025393dbeb3b ("xen/netback: use lateeoi irq binding") > Signed-off-by: Juergen Gross Reviewed-by: Paul Durrant