Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2348755pxb; Thu, 11 Feb 2021 10:04:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJy8ZhZEqfcrRs0owZwtspHX5wrephIOHYQdGeZ7o1zGkVB6GghwHf9DNjXzecc2/E+FnNCq X-Received: by 2002:a17:907:d25:: with SMTP id gn37mr9624933ejc.303.1613066691435; Thu, 11 Feb 2021 10:04:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613066691; cv=none; d=google.com; s=arc-20160816; b=WhBDHCm5ZSHCh9vEX0WXzMti8odSeJTLdUd9tCKZNIz6OoAy33IojhaxNvmklERsoH HWODi3cYfMCq/ypW7Zzx2B7LBf0eJdJEdN/Mwyx1rMsZt4vJgmycEvGrvWwVwnCCViDZ xZ2kxose+J6rX4jUPmQmCS5VDy1XhIKW3vh2HZhfNrracO5YnFdnBW//BksOPLofgHOz qfKR8murz1IKRsFX4cCj4+bkq6ouWi2+tNqdSozITgJtnXYqpdN8iIE4AK9ZKtUU7xWz T/Wj+CGyAIscLqwWr48shuGTMBtItYFM/+i0mJ6s9690xYsQbShwNVWpX+nDt7fDzlYf JOpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:to:subject:dkim-signature; bh=5Fr3+io0Dpa4uYgtLh0D1JQfAY8kNjybbJbRzQwYjvw=; b=Qb5pOQEE70sl4qfD7aYOiyvBhSGAvYxRgIj4J1dy4MJUGt/lbY6iqnmfdZUO81RBV8 K1DtFvnrVNQ/lBBqcYDCgmrjVITmJbzKlIL5LmX0LPRkDc6JpobQCAd5+NeXoRPiEGsU 6CjaVwA/+2tEO9Uq1BPP36fqvrjP7Z7tflXzCI9eVLRVxMu1wsSYLWPrrjP8/FG0fFmF Kq+IGOmxU8rX8wA3qz7ff+ub4Wap4pdDcvOnQvtKf3qYp2LjDTKU4X5g7/84YCgqjIiA MEQwowh03fmAMRUNL+Vqh9wmlXAvqLElf+bhDubS7Rrg2bdJuohO6wbsP8jC4yhyJZ+J Q1GA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=p9GbMZsF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gs5si4332877ejb.491.2021.02.11.10.03.59; Thu, 11 Feb 2021 10:04:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=p9GbMZsF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232701AbhBKSC5 (ORCPT + 99 others); Thu, 11 Feb 2021 13:02:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231809AbhBKRi4 (ORCPT ); Thu, 11 Feb 2021 12:38:56 -0500 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDDD2C06178A; Thu, 11 Feb 2021 09:38:16 -0800 (PST) Received: by mail-pl1-x62e.google.com with SMTP id r2so1262476plr.10; Thu, 11 Feb 2021 09:38:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5Fr3+io0Dpa4uYgtLh0D1JQfAY8kNjybbJbRzQwYjvw=; b=p9GbMZsFpWtPaa76x6F7h5GakfCPYloEyjBZiMsykxVje4x+IeH9AzY5a+FGogLpYc l5FAkR9Bymn1FPUsDym89bWpmGm1xH9QoV+/9SUzYpJq9YxAeh434UJ7dsUAuzaQi6rj J2OVZBxhwZeEwkmkall0emeqTeyeCx0EQJ45FpUXETdQM1QZQURRhLr+Kc3dUS+l/Wtz BzxOLxG4CNpj0Bk/Ou8NEREMj1S/UumcEvXj1DXaeDxcMM5mCpaUtdgASEOKBDz7vg4o 9KStSSNLfb+iAlfb0Tow7n02aRPo8o6ekbu7vKCF/ZaUrjp9iTwdPD+prVUc3AQH0rkc bmNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5Fr3+io0Dpa4uYgtLh0D1JQfAY8kNjybbJbRzQwYjvw=; b=rt0j6c2iTkgnzlAAkQ7ySwf9kIRzXKleE/JSH26WVlSR46hHaSWWOjQYxxUylqcfd2 j9zyrrLVWNKwUH3Aok6N3vNym3biDPvtSsbksvyJLTv3W9HWnqulyKAZfvSr+DX6pXJs Da+TE0PRKoHQ8wkrjbOOcN37ah5qT+4M+dRz/ckcP+YLirRlGEHtzv2MaCEbX/VcdCQ8 kTa1Psw60ZvKBVUI9gL8RtrH2glrCggd8+h7h0kyfNMnJoiNGKQLEVDN6Mf3A37ZLBb1 SvXE17p+hKo9xKFPgT6LwvTGXoFaAcDkP9PhCar3ACwgHtGGrv4roiISlYci+NcTeXl8 I/uA== X-Gm-Message-State: AOAM532xTA2U/PA21Q0JgyALtVxBP4fkihA+IQqmtDUUp19vUeOTNRar lBxP7948mH1igHe6kSw9I3thuSRt59A= X-Received: by 2002:a17:90b:254:: with SMTP id fz20mr4944078pjb.89.1613065095807; Thu, 11 Feb 2021 09:38:15 -0800 (PST) Received: from [10.67.49.228] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id w123sm6528917pgb.13.2021.02.11.09.38.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Feb 2021 09:38:15 -0800 (PST) Subject: Re: [PATCH] enetc: auto select PHYLIB and MDIO_DEVRES To: Tong Zhang , Claudiu Manoil , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210211160930.1231035-1-ztong0001@gmail.com> From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: Date: Thu, 11 Feb 2021 09:38:11 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210211160930.1231035-1-ztong0001@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/11/21 8:09 AM, Tong Zhang wrote: > FSL_ENETC_MDIO use symbols from PHYLIB and MDIO_DEVRES, however they are > not auto selected. > > ERROR: modpost: "__mdiobus_register" [drivers/net/ethernet/freescale/enetc/fsl-enetc-mdio.ko] undefined! > ERROR: modpost: "mdiobus_unregister" [drivers/net/ethernet/freescale/enetc/fsl-enetc-mdio.ko] undefined! > ERROR: modpost: "devm_mdiobus_alloc_size" [drivers/net/ethernet/freescale/enetc/fsl-enetc-mdio.ko] undefined! > > auto select MDIO_DEVRES and PHYLIB when FSL_ENETC_MDIO is selected. depends on MDIO_DEVRES && MDIO_BUS would be more appropriate because the symbols you reference are part of the MDIO bus layer, which happens to associated with PHYLIB depending on the configuration but as far as build goes you can separate the two. -- Florian