Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2361618pxb; Thu, 11 Feb 2021 10:22:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJyqcO+AANLpDgzkRsGN3hxfPgZuM2zegYHatjkMNAh+PPkWcy0HC8Se+VoK8peXx/jVCR1e X-Received: by 2002:a17:907:2897:: with SMTP id em23mr9797306ejc.550.1613067722680; Thu, 11 Feb 2021 10:22:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613067722; cv=none; d=google.com; s=arc-20160816; b=enPZx5t3T3/Irj/xprhTvc8WCAcpomeQReLi5mzMT5leN9HCx2cTta7W/Q+QeYa49e ocTm8ru4wlehcbqBEaKMqHUxZlwiCMn8oQd/0+OUwD1vCy66i20RDx+SGBzw3T0J2jrz T5TyQNuIxGG43QkSUqKapw+rVN5+at20Gg/uXDddPlpVv1FbQhyapsC5jGSjETmGlCsq PAoAd6rxpmRXT0YaoK7b6k1iyHCev4hmn0FTkDevePJqvbFNc5Lz/b0gBvGJ1Pk9RNM3 VzenpXu0BeZbqZGZLF5DlDKRCGSgLhzPJQ1MRtGSFwem4gNp2ZV4DJLrpm/5K0KrBApa 6oGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=FE1ZBcSfCaelUsbMiW2sW80k0mp0cw5wjA0Pttm4Erc=; b=VieCE7JehjEJypC85ATt4EYFqCrnUHt0dKBf6tXTAJWNXUvaocEiCdVY3R9tz73cJh RUNubXl5ikm+kT91Crhik7p9yqAVcq2COG6CxroEcjuGCgve8IR5QuCSKuB8eDJLDlBD cAV9+EEPzr89ALwUzaxWfSkpib2fD/i6r4TFLGj2oj3KwSSGT93YU57OgnlCNJxLdx/d qdb/IN5viUYN5KyeCpS82VX9CaTiwKGT+g0ftA7InuZd8g4l64AkumvIf+d4NSwE6ymP MwEa5WfoAEXKsizp02r15i1JMhSr+DTDayQFnA1yirCkx97NiVvkwU0RoEgQXNE2eDlK 2mtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OZ78IULd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c10si4288394ejf.281.2021.02.11.10.21.29; Thu, 11 Feb 2021 10:22:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OZ78IULd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232738AbhBKSRz (ORCPT + 99 others); Thu, 11 Feb 2021 13:17:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232488AbhBKRzD (ORCPT ); Thu, 11 Feb 2021 12:55:03 -0500 Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38F0EC061797; Thu, 11 Feb 2021 09:54:17 -0800 (PST) Received: by mail-qt1-x832.google.com with SMTP id w20so4810946qta.0; Thu, 11 Feb 2021 09:54:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FE1ZBcSfCaelUsbMiW2sW80k0mp0cw5wjA0Pttm4Erc=; b=OZ78IULdBST2DLbaRBNrDlLihVppvO8x0ZnpxrEe+iPwB44EVIaOVGDhCvK13VpwVr bUtu0AWFfcwtnyGFqiReZzYiDF2IGVfyjbI7KnJYjzZj/BSyQ5UD4ojTUavXTQbDjmek y09/Z/XztPbejWcTgnckEijS2WhLPmSHMoq+AeoncztQmii9KRkZMvsYOehUeQX9x1y4 XH0GmUfwD15y9Smm6fVDTEQPpupuJ1EbnFeVxIBA0gg4mCJ1jinQFX2psQ0MUfjVrVoz TGAaoEeaHZTZ8now2+acRav6lnA9jTuNkHKblOXNQwDTVAe9P5XX52HFN/MuGiDQs/V1 d2nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FE1ZBcSfCaelUsbMiW2sW80k0mp0cw5wjA0Pttm4Erc=; b=oPycPt623nwHRBMLK8ixngyZQkeWKSolFNV3lzdptwUu9ihCCbruCoMUfDBsxUmhrw 9eVO/BXjL1UWeUraPMWsnhRrcF/eLL6c7RPKkivysVh2+qStQsavFF3gFER0y6yhjYH8 /cN09WeXPsE0XxDjloVFh1LOf4YX1qeZ6BwNkg29MaaOcqQiird+Ixcig4oMis6+Tfyb bbPGW4MkOZ/73CS0mbHYBw00Qi1PXd7il35ukBbXINbXRwAKmuQA+XGs4Oc/80sdTIzl kWfRPkkEaQao4pOgGQjbwr8COoNDmK0uc26ZnHm1v1/lBZ0A5RZO5PfMoQi37OjJrip/ 5t3Q== X-Gm-Message-State: AOAM53191ECgz7nZ2LOuRuwJHJLQaA/CVdffW9JaT489uOW5Hu8pou+e L/EMFy/hWfj+UcUUZVyPf8E= X-Received: by 2002:a05:622a:90:: with SMTP id o16mr8212376qtw.49.1613066056313; Thu, 11 Feb 2021 09:54:16 -0800 (PST) Received: from tong-desktop.local ([2601:5c0:c200:27c6:d9d4:9919:4b2f:f800]) by smtp.googlemail.com with ESMTPSA id h9sm4427552qkh.104.2021.02.11.09.54.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Feb 2021 09:54:16 -0800 (PST) From: Tong Zhang To: Claudiu Manoil , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: ztong0001@gmail.com Subject: [PATCH v2] enetc: auto select PHYLIB and MDIO_DEVRES Date: Thu, 11 Feb 2021 12:54:11 -0500 Message-Id: <20210211175411.3115021-1-ztong0001@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org FSL_ENETC_MDIO use symbols from PHYLIB (MDIO_BUS) and MDIO_DEVRES, however there are no dependency specified in Kconfig ERROR: modpost: "__mdiobus_register" [drivers/net/ethernet/freescale/enetc/fsl-enetc-mdio.ko] undefined! ERROR: modpost: "mdiobus_unregister" [drivers/net/ethernet/freescale/enetc/fsl-enetc-mdio.ko] undefined! ERROR: modpost: "devm_mdiobus_alloc_size" [drivers/net/ethernet/freescale/enetc/fsl-enetc-mdio.ko] undefined! add depends on MDIO_DEVRES && MDIO_BUS Signed-off-by: Tong Zhang --- v2:change to depends on MDIO_DEVRES&& MDIO_BUS as suggested by Florian Fainelli > drivers/net/ethernet/freescale/enetc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/enetc/Kconfig b/drivers/net/ethernet/freescale/enetc/Kconfig index d99ea0f4e4a6..ab92382c399a 100644 --- a/drivers/net/ethernet/freescale/enetc/Kconfig +++ b/drivers/net/ethernet/freescale/enetc/Kconfig @@ -27,7 +27,7 @@ config FSL_ENETC_VF config FSL_ENETC_MDIO tristate "ENETC MDIO driver" - depends on PCI + depends on PCI && MDIO_DEVRES && MDIO_BUS help This driver supports NXP ENETC Central MDIO controller as a PCIe physical function (PF) device. -- 2.25.1