Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210131143033.7441-1-iwamatsu@nigauri.org> <dc9f110a-d998-2f79-aeaa-317ec6032891@xilinx.com>
In-Reply-To: <dc9f110a-d998-2f79-aeaa-317ec6032891@xilinx.com>
From:   Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
Date:   Fri, 12 Feb 2021 08:18:19 +0900
Message-ID: <CABMQnV+eUq5GVYJR98ZSgVHhQ84FCkzW+hVa6vUoMzcMF9o30w@mail.gmail.com>
Subject: Re: [PATCH] firmware: xilinx: Remove zynqmp_pm_get_eemi_ops() in IS_REACHABLE(CONFIG_ZYNQMP_FIRMWARE)
To:     Michal Simek <michal.simek@xilinx.com>
Cc:     linux ARM <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

Thanks for your review.

2021=E5=B9=B42=E6=9C=881=E6=97=A5(=E6=9C=88) 19:08 Michal Simek <michal.sim=
ek@xilinx.com>:
>
> Hi,
>
> On 1/31/21 3:30 PM, Nobuhiro Iwamatsu wrote:
> > zynqmp_pm_get_eemi_ops() was removed in commit 4db8180ffe7c: "Firmware:=
 xilinx:
> > Remove eemi ops for fpga related APIs", but not in IS_REACHABLE(CONFIG_=
ZYNQMP_FIRMWARE).
> > This removed zynqmp_pm_get_eemi_ops() in IS_REACHABLE(CONFIG_ZYNQMP_FIR=
MWARE), and also
> > modify the documentation for this driver.
> >
> > Fixes: 4db8180ffe7c ("firmware: xilinx: Remove eemi ops for fpga relate=
d APIs")
> > Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> > ---
> >  Documentation/driver-api/xilinx/eemi.rst | 27 +-----------------------
> >  include/linux/firmware/xlnx-zynqmp.h     |  5 -----
> >  2 files changed, 1 insertion(+), 31 deletions(-)
> >
> > diff --git a/Documentation/driver-api/xilinx/eemi.rst b/Documentation/d=
river-api/xilinx/eemi.rst
> > index 9dcbc6f18d75df..53416d25d309a8 100644
> > --- a/Documentation/driver-api/xilinx/eemi.rst
> > +++ b/Documentation/driver-api/xilinx/eemi.rst
> > @@ -19,32 +19,7 @@ device to issue or respond to power management reque=
sts.
> >  EEMI ops is a structure containing all eemi APIs supported by Zynq MPS=
oC.
> >  The zynqmp-firmware driver maintain all EEMI APIs in zynqmp_eemi_ops
> >  structure. Any driver who want to communicate with PMC using EEMI APIs
>
> The whole paragraph should be tuned. I would leave here just
>
> "Any driver who want to communicate with PMC using EEMI APIs
> use the functions provided for each function."
>
> Because there is no reference to any eemi ops structure.
>
> The rest looks good to me.

Thank you. I will add your point to the commit log and resend.
Best regards,
  Nobuhiro


--=20
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6