Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2750030pxb; Thu, 11 Feb 2021 23:34:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJxnDy7kc6uwkbdyxSYAe/8x7mYNjifr4/pEB6afgSvsqFJr8h8Aaj5ewHwVI85Iuppu1Mbg X-Received: by 2002:a17:906:6b1b:: with SMTP id q27mr1679808ejr.508.1613115291857; Thu, 11 Feb 2021 23:34:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613115291; cv=none; d=google.com; s=arc-20160816; b=GbPqx7PzTMxAQFiQQ4q2bOvDpy+c6MZmDaVrLIpyHD/wm39BKUELcfB5mPgTa6zNCG urgf/+8MYJmAxuEDn5WWwygZBTSckH9uNYwDNK3deaA6PSXTEXEDO7G9RDu1bxWo5jwE PX9qvUKpgod4clQ3e80S6OmQEuaKrKveF2tPgCkytx0uBnT8GiZjNcW1E+sbxPSb6Viv ayn4YavkKYbPjEbnTaFVM46xsb5tdF09RIJNAugcNdOs26L5vTo3qkcvf8i5ajgMS6X6 9e1PaUUB4aoyBJHVeNdazb7LnVSwf4mwP9tEhj9lasYT6Dt622s7wkDdM8gMAER/AstR 2iuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=ACcQvoKREXhj/JSWrq13ztfD15asBfb0rponA2slB4Y=; b=PaQ/f+9dnCMIRBZwLUyewy6YmlH6YqpFljumzMzf/i9J81x8HCK6stvics237bsmFz qaHIDFr0zAeO3qj0xW3vMcKl0D7tpADRRm68UmH/srY/qLbKi74va7mq5L/s6IGrJyPc rImAWAgN+Qhs9G5sc3i5mUhRNZ37V1/UVSYTncA03AKUlnU7LMkF2BcHUJsZIcc4w3qs W5n3IlB3hygThsqf8JYOloXJ/GUlGaY6IPufZ4SChW3q4fc2wIisQYAIAS2KqHrfr6y/ viDdxF0Y9sq8n8yy8FIFyi9yj8eA1m8yu5A12liCCF+UMf0SlnfOI9BS7H5SiF4V1oIC Lulw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t6si318244eds.443.2021.02.11.23.34.28; Thu, 11 Feb 2021 23:34:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229968AbhBLHdD (ORCPT + 99 others); Fri, 12 Feb 2021 02:33:03 -0500 Received: from mga07.intel.com ([134.134.136.100]:2579 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229880AbhBLHb1 (ORCPT ); Fri, 12 Feb 2021 02:31:27 -0500 IronPort-SDR: ndFPjInU+oxGTPikaJGBzPFuD85oe2De6Mecqg/oZxmWAd398qksjgn0A1zcrkCBfiyfm+uMAd z9q2Fix34Fbw== X-IronPort-AV: E=McAfee;i="6000,8403,9892"; a="246442151" X-IronPort-AV: E=Sophos;i="5.81,173,1610438400"; d="scan'208";a="246442151" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2021 23:30:42 -0800 IronPort-SDR: 4Ttpozjz99BYQvL0XQbIbRF0fE2kY9GEG4Ik+s5GVQMqiDK0jDFmwUy/tchjBOWsqSqEkZg4/D m/mti69jqJJA== X-IronPort-AV: E=Sophos;i="5.81,173,1610438400"; d="scan'208";a="415824809" Received: from isaxena-mobl2.amr.corp.intel.com (HELO [10.212.99.189]) ([10.212.99.189]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2021 23:30:42 -0800 Subject: Re: Memory keys and io_uring. To: "Aneesh Kumar K.V" , Jens Axboe , Michael Ellerman Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <877dndzs8c.fsf@linux.ibm.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <1cbf2f0b-7833-8a6c-e371-f648ebcb94a6@intel.com> Date: Thu, 11 Feb 2021 23:30:41 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <877dndzs8c.fsf@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/11/21 10:59 PM, Aneesh Kumar K.V wrote: > A read syscall do fail with EFAULT. But we allow read via io_uring > syscalls. Is that ok? In short, yes. As much as I'd like to apply pkey permissions to all accesses, when we don't have the CPU registers around, we don't have a choice: we have to let the access through. The same basic thing is done for accesses via the IOMMU and for things like ptrace() where the ptracer's registers don't have anything to do with the ptracee's address space. We could *probably* be a bit pickier at io_uring_submit() time. But, I'm not sure it's worth it.