Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 12 Feb 2021 09:33:58 +0100
From:   Jiri Olsa <jolsa@redhat.com>
To:     Ian Rogers <irogers@google.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Namhyung Kim <namhyung@kernel.org>,
        linux-kernel@vger.kernel.org, Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH] perf libperf: Remove unused xyarray.c
Message-ID: <YCY9dtFKwTLjTq+w@krava>
References: <20210212043803.365993-1-irogers@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210212043803.365993-1-irogers@google.com>
Precedence: bulk

On Thu, Feb 11, 2021 at 08:38:03PM -0800, Ian Rogers wrote:
> Migrated to libperf in:
> commit 4b247fa7314c ("libperf: Adopt xyarray class from perf")

Acked-by: Jiri Olsa <jolsa@redhat.com>

thanks,
jirka

> 
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
>  tools/perf/util/xyarray.c | 33 ---------------------------------
>  1 file changed, 33 deletions(-)
>  delete mode 100644 tools/perf/util/xyarray.c
> 
> diff --git a/tools/perf/util/xyarray.c b/tools/perf/util/xyarray.c
> deleted file mode 100644
> index 86889ebc3514..000000000000
> --- a/tools/perf/util/xyarray.c
> +++ /dev/null
> @@ -1,33 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0
> -#include "xyarray.h"
> -#include <stdlib.h>
> -#include <string.h>
> -#include <linux/zalloc.h>
> -
> -struct xyarray *xyarray__new(int xlen, int ylen, size_t entry_size)
> -{
> -	size_t row_size = ylen * entry_size;
> -	struct xyarray *xy = zalloc(sizeof(*xy) + xlen * row_size);
> -
> -	if (xy != NULL) {
> -		xy->entry_size = entry_size;
> -		xy->row_size   = row_size;
> -		xy->entries    = xlen * ylen;
> -		xy->max_x      = xlen;
> -		xy->max_y      = ylen;
> -	}
> -
> -	return xy;
> -}
> -
> -void xyarray__reset(struct xyarray *xy)
> -{
> -	size_t n = xy->entries * xy->entry_size;
> -
> -	memset(xy->contents, 0, n);
> -}
> -
> -void xyarray__delete(struct xyarray *xy)
> -{
> -	free(xy);
> -}
> -- 
> 2.30.0.478.g8a0d178c01-goog
>