Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <202102121331.d4C0ShlS-lkp@intel.com>
In-Reply-To: <202102121331.d4C0ShlS-lkp@intel.com>
From:   Arnd Bergmann <arnd@kernel.org>
Date:   Fri, 12 Feb 2021 11:05:11 +0100
Message-ID: <CAK8P3a3uM7rCbnJP9r2SFEjm0D7oy2YsXw7VcGzkg5tq7mQbag@mail.gmail.com>
Subject: Re: arch/m68k/68000/dragen2.c:73:16: error: 'screen_bits' undeclared
To:     kernel test robot <lkp@intel.com>
Cc:     Arnd Bergmann <arnd@arndb.de>, kbuild-all@lists.01.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Greg Ungerer <gerg@linux-m68k.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Feb 12, 2021 at 6:48 AM kernel test robot <lkp@intel.com> wrote:
>
> FYI, the error/warning still remains.

>          |             ^~~~~~~~~~~~
>    arch/m68k/68000/dragen2.c: In function 'init_dragen2':
> >> arch/m68k/68000/dragen2.c:73:16: error: 'screen_bits' undeclared (first use in this function)
>       73 |  LSSA = (long) screen_bits;
>          |                ^~~~~~~~~~~
>    arch/m68k/68000/dragen2.c:73:16: note: each undeclared identifier is reported only once for each function it appears in

This problem existed before my patch, I just moved the line to another file.
To fix it, one needs to test on real hardware and figure out what is supposed
to go in there.

The bug was apparently introduced in linux-2.5.70 in this commit:

commit 2b1a7e97c8c2d6330a432cbcaf83a0ef5fab848e
Author: gerg <gerg>
Date:   Mon May 26 16:45:57 2003 +0000

    [PATCH] fix m68knommu DragonEngine2 target setup code

    Numerous fixes for the m68knommu DragonEngine2 setup code.

    It was out of date relative to more recent kernels.  Original patches
    from Georges Menie.

    BKrev: 3ed244c5dPVeFKP63b4kkeS_rEshag


      Arnd