Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2826226pxb; Fri, 12 Feb 2021 02:16:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJyh/0BZOOM4p2UHixyNQak+y3FiMZr1GciX2nYYDntOqWziz+d9BXR63pTchuPW88Bl3jUn X-Received: by 2002:a05:6402:46:: with SMTP id f6mr2528053edu.163.1613125000763; Fri, 12 Feb 2021 02:16:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613125000; cv=none; d=google.com; s=arc-20160816; b=TXLYDZA5uKCFU0tKboG2kgZ7eHfljZe58AF2nr7CWZDJ5QyvAocPTD1bD22FNv/8hd xcGPYS0hfEmSXqRdPPdZNpgkYeu4yGK2+3quszeBKC6txPGNRHIglEA7Sg7b0nkbb4zg RRRpncs1gx0SvAA4G+NB7U8rHOOz8QERZz+47dS0JBr+CjcNy3GF1Eg7k15jTUcA2+dX JOEbGt8QvRWBhcrTHbfPUKht8HfBunydCpUBBC7gjCSr09PQMKOulsYZlOHX0D+blMPQ UCEgO7wgfjaePFNPR0fH4sDh+UiJifRng7yx/edReC4LpmhjwXr87rYIhaF8gtrzWDwv J6aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=At3TvYO39sMhS3EJN5CLDSYALJN4MjhiSj36T+O6gOc=; b=jvYkMyCljvIuqfVp+VMpTQYh9ogqeBo4Fn4x9KvPAN1nTT89SB8mJaVx8uSN/vY3+Q MOsiYQsATTF0AIYY7ksj8H0vhzzIbQ243Bj7K69JnSzf5BrfdPKu11FWDEXxjGx52lJ/ RGtwGadggYQroQ3v4pXLVU7v0f0XvPUYUWzomvsYOEOPapdbQgQHj1TUp161gmDzwsuH H8brm7jpg+DDWKF+Gf5mWDH8+G/KyNP75EBPOrnzORxuzlRCdmQtXE4kbe5G3odt1z7G B49s3UuFOxvF8XbT2xZNI5uH45tu9RGPApVmRNymwb75viarbBb7Y6qS/AgyAI+eMF2x IVZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="KPp1/5J+"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f23si5700183edj.313.2021.02.12.02.16.17; Fri, 12 Feb 2021 02:16:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="KPp1/5J+"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230376AbhBLKNS (ORCPT + 99 others); Fri, 12 Feb 2021 05:13:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:48134 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230300AbhBLKNQ (ORCPT ); Fri, 12 Feb 2021 05:13:16 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2558464E6B for ; Fri, 12 Feb 2021 10:12:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613124756; bh=At3TvYO39sMhS3EJN5CLDSYALJN4MjhiSj36T+O6gOc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=KPp1/5J+6Y+K3dUYigQ2VNE9Qxyw0sf5LmOPlAPYVPRzNFYDkcBtYTbbmsIehOkzH VfTCCdqU8UdouJD1HtspoqIJHvNtjSIRmSThGkJ7+R0lQLHXsF+fe03o6ta5LNJ1o6 2ujdpz1pgVN4REvxrEBizP6XoN8+vNMLCObdjLd78W5tR6K/O7za6wZFFLVGSjq5/n laS0O3Xy26p5RajQpV9ssHzMCvfNjyx/ZS8oUrARPH49NV4xyfUe5uYxN0pXxaXbzO O4yiODRKRrJ/zipFnZ+06WzvGK03x28b2o1+olfH5/EGSIQaXWqT+FsFO9bUMGnz3W jgojfJ/UHOhJQ== Received: by mail-ot1-f53.google.com with SMTP id r21so7867840otk.13 for ; Fri, 12 Feb 2021 02:12:36 -0800 (PST) X-Gm-Message-State: AOAM531QbsYp8UsYr0u7BuxtVBqoKdUJuvgfvfoxZ9XCYB0AEbNC2stM B30cJKstxhIkYDyJLEUbbJwuM3+JVprxjOBcylg= X-Received: by 2002:a05:6830:18e6:: with SMTP id d6mr1545429otf.251.1613124755488; Fri, 12 Feb 2021 02:12:35 -0800 (PST) MIME-Version: 1.0 References: <1613121426-15585-1-git-send-email-mihai.carabas@oracle.com> <1613121426-15585-2-git-send-email-mihai.carabas@oracle.com> In-Reply-To: <1613121426-15585-2-git-send-email-mihai.carabas@oracle.com> From: Arnd Bergmann Date: Fri, 12 Feb 2021 11:12:19 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/3] misc/pvpanic: split-up generic and platform dependent code To: Mihai Carabas Cc: "linux-kernel@vger.kernel.org" , gregkh , Arnd Bergmann , Randy Dunlap , Wang ShaoBo Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 12, 2021 at 10:17 AM Mihai Carabas wrote: > > Split-up generic and platform dependent code in order to be able to re-use > generic event handling code in pvpanic PCI device driver in the next patch. > > The code from pvpanic.c was split in two new files: > - pvpanic-common.c: generic code that handles pvpanic events > - mmio.c: platform/bus dependent code > > Signed-off-by: Mihai Carabas The patch looks fine, but for review purposes it's better to generate the email with 'git format-patch -M'. Reviewed-by: Arnd Bergmann