Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2925531pxb; Fri, 12 Feb 2021 05:12:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJwYk8uixg7mwluDuWlmmqvptCG9DRQEoTzrKKfpvrLQQr5EvF2Tk/Q/ktClZkNuBdJxGXmi X-Received: by 2002:a17:906:b31a:: with SMTP id n26mr2952530ejz.358.1613135557450; Fri, 12 Feb 2021 05:12:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613135557; cv=none; d=google.com; s=arc-20160816; b=iSys5KUqtSjRvS+PISgGwVbpMnlF/0Cf4aj47wK3a0kyva5DWLgXZFQmaKDm0C2+TA /2oglqS4XmoJmIj2eDzyY/uTwW3UGZB02TwToQtrEhVPKwPrySqozG9HtCxtIxBpZ/CD kYTHVcsuryFuJMe/+tPqGeCWwBGwJ2V5pmIiJznSbUfjfxH+tx+873BO3yT3OXYFwxEW 10heyCsHKlwB0qH2qHvt9QyySpDXLocK/7s7OarfACkAL4Z6ciROxkKAz95ouO3IkbxK dOu9n7Mi+QggOu71yqc4cZPhBOOzQ4gahY2/hthlsJC8/edCAATAaUYLiysgZKM9gV6Q 2OdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=TX1H3m3VFNgBv1mAohCEhi5B6yH8CGQhBabKsIXXRuY=; b=bhTdYJMct5bJ6+8jIioqISYk0rOcDzNaa7qy+NwNitlkMYCv5XZcS/uI7+pcQ2Vwha ARcGTi0uhL1mI2H4+Sx5j3i9/e4+wCUWovlSd/oFDge3baJIjIZn3bmyyDqxztbEzJxE C4+sDgLwpEnGqEHBTVVQp3XOHwpBtp+AS8O6LfDSvYOjO/U/SSXIQwLB4CS65Y/iUWkG vOkK5O0Hm09I8ySybk33bu/JzNd8H6FIbUIwYagKQd0BKbp2+uuqreH1OGzbYJqlqH4X syNkTIWdejfqdfczLLAOrATHVGAztNLhOdyM1amAGh7EOpfFXgeAafmDk2XqFfa/VjOx NC1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=H2BbUT4n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y11si6635656ejd.56.2021.02.12.05.12.14; Fri, 12 Feb 2021 05:12:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=H2BbUT4n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232081AbhBLNLm (ORCPT + 99 others); Fri, 12 Feb 2021 08:11:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231635AbhBLMyh (ORCPT ); Fri, 12 Feb 2021 07:54:37 -0500 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1ED34C061574 for ; Fri, 12 Feb 2021 04:53:57 -0800 (PST) Received: by mail-lj1-x22c.google.com with SMTP id b16so11364993lji.13 for ; Fri, 12 Feb 2021 04:53:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TX1H3m3VFNgBv1mAohCEhi5B6yH8CGQhBabKsIXXRuY=; b=H2BbUT4nDLAXlZkqeMybxmPTGGicSfUIgpUG/4UgLsZ1McUNC8osmJhxYRPoFmeZ+H DI0UqPfV5dwCN/aeTXK6jShgviiFHZ5PqpeH3nFkykDGPaf6r4momoN/7VnWdUP28Iwe uPVEPcGzsDJ1TVoxJOtTCCeyUg3ybck/rV4eNgXJPamhcjdyKUOihnW/iLw/c2w6jAxM cjte0Wa/Wba5Q6eKGcfx7jR6I4joYdDlhO+eAwEWxAo1S5C+Vw+v5DV5QA1ZijnRndk1 YCscDK7X2Qn3Mj135iLL00fNFzdLRcFOKDQcqw2b7BBkwc9CUC6AJUrBNXgH1dy2Zzyc vf7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TX1H3m3VFNgBv1mAohCEhi5B6yH8CGQhBabKsIXXRuY=; b=O7G3BElFP//qzakyD6wQYUgZIDNoV5J0/Ad11pbb0YXTBKo+3aZBpNK7MhVsjy24+/ QIBsYaflFtpqbTx4hsYDF+jZPfcg3ZQuGntIFNhjGHGXrdjaFxxzs3YlWTwwWj1avnbW +fSWZVm+a0Zu3aqbEYFwrzCvdqzqzZne5G/0Px2PdpDcenw0sPKFOGLMX8LRHJxoz224 cIH+QS2yzysSia0z5GbJErt6uXZA91pU1nqhUqhgtCmBlYxOjOkch7SmovBtqSyxiuA2 qq0HQO4bg8hiLWmwyIUCIlSpGR2VStEIOSm3os6HRd8wHoJxUurTY2Mq7N+efzMJGn06 uXfw== X-Gm-Message-State: AOAM533nUhbM3OtXyikrNDe0zLpUeqzTVe+IPeRMZ9bnqFKdhnPQmoc+ Ui4BZ/54gy4RAWNkN64+gftByDt0yPBHOHwGn1yrsQ== X-Received: by 2002:a2e:9ec3:: with SMTP id h3mr1584119ljk.200.1613134435693; Fri, 12 Feb 2021 04:53:55 -0800 (PST) MIME-Version: 1.0 References: <20210208145153.422093-1-geert+renesas@glider.be> In-Reply-To: <20210208145153.422093-1-geert+renesas@glider.be> From: Linus Walleij Date: Fri, 12 Feb 2021 13:53:44 +0100 Message-ID: Subject: Re: [PATCH] gpio: GPIO_MXS should not default to y, unconditionally To: Geert Uytterhoeven Cc: Anson Huang , Shawn Guo , Sascha Hauer , Bartosz Golaszewski , Fabio Estevam , Pengutronix Kernel Team , NXP Linux Team , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 8, 2021 at 3:51 PM Geert Uytterhoeven wrote: > Merely enabling CONFIG_COMPILE_TEST should not enable additional code. > To fix this, restrict the automatic enabling of GPIO_MXS to ARCH_MXS, > and ask the user in case of compile-testing. > > Fixes: 6876ca311bfca5d7 ("gpio: mxs: add COMPILE_TEST support for GPIO_MXS") > Signed-off-by: Geert Uytterhoeven Reviewed-by: Linus Walleij Yours, Linus Walleij