Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 12 Feb 2021 13:05:30 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
        Robin Murphy <robin.murphy@arm.com>,
        Phil Elwell <phil@raspberrypi.com>,
        linux-spi <linux-spi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] spi: Skip zero-length transfers in
 spi_transfer_one_message()
Message-ID: <20210212130530.GE6057@sirena.org.uk>
References: <20210211180820.25757-1-nsaenzjulienne@suse.de>
 <20210212123118.GB6057@sirena.org.uk>
 <cd41a204107900c890b0234847fa0b62701f74cc.camel@suse.de>
 <20210212125221.GD6057@sirena.org.uk>
 <CAMuHMdXFt-0vyBQnvwWim8MrijZ-PNN0HsO+dDp9iMzb2153Hg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="brEuL7wsLY8+TuWz"
Content-Disposition: inline
In-Reply-To: <CAMuHMdXFt-0vyBQnvwWim8MrijZ-PNN0HsO+dDp9iMzb2153Hg@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--brEuL7wsLY8+TuWz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Feb 12, 2021 at 01:57:24PM +0100, Geert Uytterhoeven wrote:
> On Fri, Feb 12, 2021 at 1:55 PM Mark Brown <broonie@kernel.org> wrote:

> > No, I think it's fine - there's probably some sensible use case with
> > drivers reusing a statically allocated transfer/buffer set for multiple
> > operations and just tweaking the length as needed which seems a bit
> > weird but I can't think of a reason not to allow it.  Your patch is
> > currently queued, all being well it'll get tested & pushed out later
> > today.

> Aren't the zero-length transfers also used to do tricks with the CS signal,
> e.g. combined with cs_change?

The issue wasn't that things were using zero length transfers, the issue
was that drivers were doing zero length transfers but also passing data
buffers which isn't an obvious thing to do given that there will be no
data in those buffers.

--brEuL7wsLY8+TuWz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmAmfRkACgkQJNaLcl1U
h9CTbQf+M0AJe+8RIbyBkQmucMxzMYl1M7W5COpyanLLe/qcEZNQ0yWzuJ13HMCr
9PcrQk+R63wg3Se0VUPAvx083lIbePEcCs2CkzoT+h2Y08zBxT3QBHNYNBq0MZ3D
QqQP9G3BX3xqaFduWeJ/7ZZq5l4dDAC1u9P/7ZJajupQcnKe7H2MoPe01qgKvjS8
T/i5dJaUS2LPhsHxieI5wNBCtvtbJ6ziCyXoc5/QDW5p4GXj9SfUF2jnA0wZEJ93
uq5Qhyf07f7/FAcBfbODsStxhoR9t6PJ3v1ZsJ+bwUoPXKMEre2+Vmbx25q6+MWA
J5MBE8qyVAtSNs4leGb06uNWAwIQ9g==
=14UE
-----END PGP SIGNATURE-----

--brEuL7wsLY8+TuWz--