Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2965184pxb; Fri, 12 Feb 2021 06:09:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJy7bxNlJ8e0Z9+ulM/LMrWUEO9ebVYsNjaUzeFn31HcOYUnCLEZjVY6SKHRXrSfXRynhKmR X-Received: by 2002:a17:906:4f16:: with SMTP id t22mr3167273eju.307.1613138967672; Fri, 12 Feb 2021 06:09:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613138967; cv=none; d=google.com; s=arc-20160816; b=EH0Zfl+EiX6W5jTByNR/tMom428j1ZdqU0sccYbbJxA2fFNrcEgWvrVE3CJxX5zUpy 1O+XI6w8Zgy/Ut7vNYYW50R0QLjoYfunR7pY/wiRZWLNwSiOd0d1QBckpFhSpox0G/MW AXleRanbgSMB1uaC3GHEK2YqaH0DDlaAG28QGGlDxb8RksnuCtytvfBbrg1AOAa3gtSV nJk5byxkX9rf4vkI7IbYy+b6SkyGhanSTwZr/Na+WQNGynRS4BZqy6Q6zM0uas63De5j BgMG3D3/oGUe2OEi1MPQCwe7jw5dnvvtKzN2OJejCY9rS8ngfLacxs3OiLVA3t0/R9TP jT3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=nvdaLks01KVjSkXksEcBI652oXg84KjGEB7zDiBS9p0=; b=Y7SIzk2RkVrCuU1RixtRv7RQbBW8lKzJcrI+Ou6aevrSp4kUVSHC5H5yAz532Bfect VZHu1PdnCKWbkNrALPdePoNHN1SoYIFsMYbavuooGRG5xfNaYCSKJzXYJD5JQICqYSA7 BUzclLgzBg8ElfRItNORQtGubNz/it08aSHQMXQV1x+GfCYOd76hPlRNdXNftHGIlPvM BWrqaBGwXTeSXeK41DfrQU6s8ZBvp7Br3rHD0Y3sF3IcvxBBFDc4xDfY7XyuzwFo8vzL cSosIj7oBPiFaYv+TZpQ5/k5f5TFg4rWnAFOzkc+ong2tkGY5MKNaygdDLRbLp0f6kbo U4+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pnfqD28M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n20si1151356edo.525.2021.02.12.06.09.03; Fri, 12 Feb 2021 06:09:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pnfqD28M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231660AbhBLOD4 (ORCPT + 99 others); Fri, 12 Feb 2021 09:03:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:42466 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230090AbhBLODm (ORCPT ); Fri, 12 Feb 2021 09:03:42 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id D386D64E25; Fri, 12 Feb 2021 14:03:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613138581; bh=VuqkFaZKHwNoY6ayATlulBlks2L7rIdSyE0iZde9Ji0=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=pnfqD28M/wUvoL5jJbWHzvQVZhqVVptV6wi4jztcYbcbbxFxEjOBw4fmlYMJknxqb 7SugWdCJucriHzzJPYnf2A05zETc+T7rLE7DBTYuh/5eyJ9zy+2LkW1vRzy4luUKxy 8q45+es95h7rQWKPX26qw7pn3lcJmNsgDq5d1VuQPmcTFfazaJ6p2sdg/Py881i5GL AKDuV5n1JDuZeB115d9grCj0iBW6MT0ej4fjAZ+eeJSfBwObQcNAUD5RV5mlHpJ+eE s5SYxdPBidWgLmayw1Lrd9EiaettiOaVT+mfMde/xnkNwAcHF2gBcDS0uvaiRpF1eN 3wf5/DUbY+oYw== From: Mark Brown To: Robin Murphy , Nicolas Saenz Julienne Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Phil Elwell In-Reply-To: <20210211180820.25757-1-nsaenzjulienne@suse.de> References: <20210211180820.25757-1-nsaenzjulienne@suse.de> Subject: Re: [PATCH] spi: Skip zero-length transfers in spi_transfer_one_message() Message-Id: <161313851919.18278.11191076448081876020.b4-ty@kernel.org> Date: Fri, 12 Feb 2021 14:01:59 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 Feb 2021 19:08:20 +0100, Nicolas Saenz Julienne wrote: > With the introduction of 26751de25d25 ("spi: bcm2835: Micro-optimise > FIFO loops") it has become apparent that some users might initiate > zero-length SPI transfers. A fact the micro-optimization omitted, and > which turned out to cause crashes[1]. > > Instead of changing the micro-optimization itself, use a bigger hammer > and skip zero-length transfers altogether for drivers using the default > transfer_one_message() implementation. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: Skip zero-length transfers in spi_transfer_one_message() commit: b306320322c9cfaa465bc2c7367acf6072b1ac0e All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark