Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Min Li <min.li.xe@renesas.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "derek.kiernan@xilinx.com" <derek.kiernan@xilinx.com>,
        "dragan.cvetic@xilinx.com" <dragan.cvetic@xilinx.com>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next v2] misc: Add Renesas Synchronization Management
 Unit (SMU) support
Thread-Topic: [PATCH net-next v2] misc: Add Renesas Synchronization Management
 Unit (SMU) support
Thread-Index: AQHXANy3Kc3xxVsbt0Wl/bCSqSMNqapUIqQAgACD5GA=
Date:   Fri, 12 Feb 2021 15:39:03 +0000
Message-ID: <OSBPR01MB47733A5CB20E20E48EE84602BA8B9@OSBPR01MB4773.jpnprd01.prod.outlook.com>
References: <1613092575-17311-1-git-send-email-min.li.xe@renesas.com>
 <YCYwrNE8547uuODo@kroah.com>
In-Reply-To: <YCYwrNE8547uuODo@kroah.com>
Accept-Language: en-CA, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 0410dc21-e381-4d13-a393-08d8cf6c538c
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Feb 2021 15:39:03.7229
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UxwyEGFtElRopiaWSh+GlCn6dkYDAgz1WtLLmTytUwNyfrYsW9HHhQaJ7lUm2ytUVoZM3FEQvzQDLEwKxO2cyA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSBPR01MB4599
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > +
> > +	/* Only one open per device at a time */
> > +	if (!atomic_dec_and_test(&rsmu->open_count)) {
> > +		atomic_inc(&rsmu->open_count);
> > +		return -EBUSY;
>=20
> This does not do what you think it does, and does not prevent multiple
> applications from talking to your device at the same time.
>=20
> There is no need for this at all, as it does not work, sorry.  If multipl=
e apps
> talk to your device, it's their fault, not the kernel's fault, that thing=
s go
> wrong.
>=20
> And I thought that Arnd already told you to fix this?
>=20

Hi Greg

Sorry for not replying to the list, I am new so not very familiar with the =
process.

Can you elaborate why it doesn't work? I kind of borrow the idea from xilin=
x_sdfec.c and I don't see why it doesn't work.

I mean if an application failed at opening the device, how can it proceed t=
o talk the device without a file descriptor?

Thanks

Min