Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Anirudh Rayabharam <mail@anirudhrb.com>
To:     gregkh@linuxfoundation.org, lee.jones@linaro.org, arnd@arndb.de,
        colin.king@canonical.com
Cc:     Anirudh Rayabharam <mail@anirudhrb.com>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Message-ID: <20210212153843.8554-1-mail@anirudhrb.com>
Subject: [PATCH v2] staging: wimax/i2400m: fix some byte order issues found by sparse
Date:   Fri, 12 Feb 2021 21:08:43 +0530
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=utf8
Precedence: bulk

Fix sparse byte-order warnings in the i2400m_bm_cmd_prepare()
function:

wimax/i2400m/fw.c:194:36: warning: restricted __le32 degrades to integer
wimax/i2400m/fw.c:195:34: warning: invalid assignment: +=3D
wimax/i2400m/fw.c:195:34:    left side has type unsigned int
wimax/i2400m/fw.c:195:34:    right side has type restricted __le32
wimax/i2400m/fw.c:196:32: warning: restricted __le32 degrades to integer
wimax/i2400m/fw.c:196:47: warning: restricted __le32 degrades to integer
wimax/i2400m/fw.c:196:66: warning: restricted __le32 degrades to integer

Signed-off-by: Anirudh Rayabharam <mail@anirudhrb.com>
---
 drivers/staging/wimax/i2400m/fw.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/wimax/i2400m/fw.c b/drivers/staging/wimax/i240=
0m/fw.c
index b2fd4bd2c5f9..92ea5c101e76 100644
--- a/drivers/staging/wimax/i2400m/fw.c
+++ b/drivers/staging/wimax/i2400m/fw.c
@@ -189,12 +189,17 @@ void i2400m_bm_cmd_prepare(struct i2400m_bootrom_head=
er *cmd)
 {
 =09if (i2400m_brh_get_use_checksum(cmd)) {
 =09=09int i;
-=09=09u32 checksum =3D 0;
+=09=09__le32 checksum =3D 0;
 =09=09const u32 *checksum_ptr =3D (void *) cmd->payload;
-=09=09for (i =3D 0; i < cmd->data_size / 4; i++)
-=09=09=09checksum +=3D cpu_to_le32(*checksum_ptr++);
-=09=09checksum +=3D cmd->command + cmd->target_addr + cmd->data_size;
-=09=09cmd->block_checksum =3D cpu_to_le32(checksum);
+
+=09=09for (i =3D 0; i < le32_to_cpu(cmd->data_size) / 4; i++)
+=09=09=09le32_add_cpu(&checksum, *checksum_ptr++);
+
+=09=09le32_add_cpu(&checksum, le32_to_cpu(cmd->command));
+=09=09le32_add_cpu(&checksum, le32_to_cpu(cmd->target_addr));
+=09=09le32_add_cpu(&checksum, le32_to_cpu(cmd->data_size));
+
+=09=09cmd->block_checksum =3D checksum;
 =09}
 }
 EXPORT_SYMBOL_GPL(i2400m_bm_cmd_prepare);
--=20
2.26.2