Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210209105435.21036-1-lukasz.luba@arm.com>
In-Reply-To: <20210209105435.21036-1-lukasz.luba@arm.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Fri, 12 Feb 2021 16:45:32 +0100
Message-ID: <CAJZ5v0hZsns4_An-kCbdVjzXWp9QC+b1FV2WsfRqfEhvT=rs9g@mail.gmail.com>
Subject: Re: [PATCH 1/2] PM / EM: update Kconfig description and drop "default
 n" option
To:     Lukasz Luba <lukasz.luba@arm.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux PM <linux-pm@vger.kernel.org>,
        Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Greg Kroah-Hartman <greg@kroah.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Feb 9, 2021 at 11:58 AM Lukasz Luba <lukasz.luba@arm.com> wrote:
>
> Energy Model supports now other devices like GPUs, DSPs, not only CPUs.
> Thus, update the description in the config option. Remove also unneeded
> "default n". If the "default" line is removed, it defaults to 'n'.
>
> Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>

Applied along with the [2/2[ as 5.12 material, thanks!

> ---
>  kernel/power/Kconfig | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig
> index a7320f07689d..56dbc2616d5c 100644
> --- a/kernel/power/Kconfig
> +++ b/kernel/power/Kconfig
> @@ -322,15 +322,14 @@ config CPU_PM
>         bool
>
>  config ENERGY_MODEL
> -       bool "Energy Model for CPUs"
> +       bool "Energy Model for devices with DVFS (CPUs, GPUs, etc)"
>         depends on SMP
>         depends on CPU_FREQ
> -       default n
>         help
>           Several subsystems (thermal and/or the task scheduler for example)
> -         can leverage information about the energy consumed by CPUs to make
> -         smarter decisions. This config option enables the framework from
> -         which subsystems can access the energy models.
> +         can leverage information about the energy consumed by devices to
> +         make smarter decisions. This config option enables the framework
> +         from which subsystems can access the energy models.
>
>           The exact usage of the energy model is subsystem-dependent.
>
> --
> 2.17.1
>