Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210201225735.86163-1-rikard.falkeborn@gmail.com>
In-Reply-To: <20210201225735.86163-1-rikard.falkeborn@gmail.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Fri, 12 Feb 2021 16:48:17 +0100
Message-ID: <CAJZ5v0gKRRTzmXUbdcwNO1jTYnOFpioNQ2nK615QY5X84ULeYg@mail.gmail.com>
Subject: Re: [PATCH] PM: Constify static struct attribute_group
To:     Rikard Falkeborn <rikard.falkeborn@gmail.com>
Cc:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
        Linux PM <linux-pm@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Feb 1, 2021 at 11:58 PM Rikard Falkeborn
<rikard.falkeborn@gmail.com> wrote:
>
> The only usage of suspend_attr_group is to put its address in an array of
> pointers to const attribute_group structs. Make it const to allow the
> compiler to put it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---
>  kernel/power/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/power/main.c b/kernel/power/main.c
> index 0aefd6f57e0a..12c7e1bb442f 100644
> --- a/kernel/power/main.c
> +++ b/kernel/power/main.c
> @@ -387,7 +387,7 @@ static struct attribute *suspend_attrs[] = {
>         NULL,
>  };
>
> -static struct attribute_group suspend_attr_group = {
> +static const struct attribute_group suspend_attr_group = {
>         .name = "suspend_stats",
>         .attrs = suspend_attrs,
>  };
> --

Applied as 5.12 material, thanks!