Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v5 net-next 03/10] net: bridge: don't print in
 br_switchdev_set_port_flag
To:     Vladimir Oltean <olteanv@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>
CC:     Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <bridge@lists.linux-foundation.org>,
        "Roopa Prabhu" <roopa@nvidia.com>, Jiri Pirko <jiri@resnulli.us>,
        Ido Schimmel <idosch@idosch.org>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
        <UNGLinuxDriver@microchip.com>, Vadym Kochan <vkochan@marvell.com>,
        Taras Chornyi <tchornyi@marvell.com>,
        Grygorii Strashko <grygorii.strashko@ti.com>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        Ivan Vecera <ivecera@redhat.com>, <linux-omap@vger.kernel.org>
References: <20210212151600.3357121-1-olteanv@gmail.com>
 <20210212151600.3357121-4-olteanv@gmail.com>
From:   Nikolay Aleksandrov <nikolay@nvidia.com>
Message-ID: <a087531e-59f3-cadb-da69-e6b1e7b521f2@nvidia.com>
Date:   Fri, 12 Feb 2021 17:59:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.0
In-Reply-To: <20210212151600.3357121-4-olteanv@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [10.21.241.151] (213.179.129.39) by ZR0P278CA0115.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:20::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.27 via Frontend Transport; Fri, 12 Feb 2021 15:59:29 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0c46e3f9-1c8b-4671-54e8-08d8cf6f3126
X-MS-TrafficTypeDiagnostic: DM6PR12MB3051:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR12MB3051897022A9C2731F048273DF8B9@DM6PR12MB3051.namprd12.prod.outlook.com>
X-Header: ProcessedBy-CMR-outbound
X-MS-Oob-TLC-OOBClassifiers: OLM:3383;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: PkQDNtWQ1z2D3CvZcRX/1iMZQM5V7sI1TtDZUQbrAEAT60tX6Z19TYNh5091k8SoOQD3jE4d5ncaZWy+MbQKnb6MRFMn7Ze/svOBV1J7y8hixcKdsASlKBFlBpDiiIyWii0N+juB991ROL2xOeGC88EpF6cfgJl6ENk9JFnPxQDaH7J9EPWvjK6uAQSMAncwkzgW3PH1fv6n2eyYLIu0V/NedaJOsD3wdgYUBLdf0RAzwqOul8PPKzfdEv/N31qU5FrXlvbY0MfKfk2RRPFjdFMoA6W7+hIu3catZjV9t74fTgD2yjd8sRe0OlrA3pGnXpt+eVJ8to9SfM7XXAwNAJX6sfxzDNJ0Nrv/Rep/KB+L9c4Bi3I4FBORJdLKeordf/P0y4Lhdn1RrWlVY40sjRWhWM737m2Zq2lk/xtxgVwE9sr9+19cgKS/zSCskiVlM7RT3Lxq02QqV9htDfhWMxOOLNvue0N6tA6yQ0fZ20B9ewnatE1OXL/j4HEE0tYuwhqi/SfrNrcZyLFHoQmJ3nmZ/sjE3SaYw8Vrky4QKexnaiMuBG/Y26LnDU3TpKbPK8PmJ6esvVda/GMDHOSiDzlBQ7hod65Mk8Agbxe0nac=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4403.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(39860400002)(136003)(366004)(376002)(396003)(16576012)(4326008)(31696002)(83380400001)(16526019)(53546011)(66476007)(7416002)(26005)(316002)(186003)(478600001)(110136005)(6486002)(2906002)(66946007)(2616005)(36756003)(31686004)(6666004)(86362001)(54906003)(66556008)(8676002)(5660300002)(8936002)(956004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?MzNSeU1uTmpJS01VME90UzRtcHVONnJabC9qZU1yQ2dYcHhjRlFnTS9LTXBl?=
 =?utf-8?B?ZVNyUzV0UG5UMXdmV2dHY1RmSEFnNllBTDhsMjZoLzJLM1AxTC9Db0NMOHgz?=
 =?utf-8?B?WC9hVG9UekppRnZYU3RQN1FrZk9OaGh0ZzdQNGIxQW1ndzV5VFBHVEluckQy?=
 =?utf-8?B?c2g3SjNlSFMveXlpMENrZG5RS2cvUFdmMlJISUk2Zk1BSm5hdW9hZHE3UFpx?=
 =?utf-8?B?U1g1TytxbkF5SVRsUkl3SUxRVENWOHpnMXdSOU9KbHcwTjhxQVJic3BFYjdP?=
 =?utf-8?B?S2NlSDhJRlU5enJFTjBZM21pZXRacVNiWGoxQW1oekgxd0F3ZXVNUDNuM3hT?=
 =?utf-8?B?WUx2MXk0ZCtWRGRvdmhKQlljL1V5cnB1UFovYjRPZzA2MlFCbmtNc0N0b0tR?=
 =?utf-8?B?NklPclJyL1krbTVIZHlTR0lHUmJpaTJ2OUlsM0Q4REptZnhZZDFweFB6V01I?=
 =?utf-8?B?SHVHK0pJcFQzY3YraGUwQmhXMVVnVjRvRUl6UEFnL2VaZUpjYTd4cHFuNHAy?=
 =?utf-8?B?Z1VIN2xIcnJTTk03Zk5JTHA0NlltdFVmZytZYVN0bGZKdWxhS1FLMHRHeGda?=
 =?utf-8?B?cFJIT0RrTUowUmRIL2ZJcGxnWFN1OG9oZWdReGMzVkpsOG9zVFMrSG8xUDZR?=
 =?utf-8?B?eFNvTXFRUHhzQ1ppTW92UlluOWs3R0dvM1duNUZzU2lzMFJHSFo4QUZ6MlMy?=
 =?utf-8?B?dmVabVFObzBxWTFCNHlLekxTWElORDIzRHJZWkUxbG1aNmpDT25ER0tKWW1q?=
 =?utf-8?B?akh0RHQvbC80cjY3d0tzV0tRTkMwVU9VM1NCbEg3ZXRBcjFpWVZ5M1ZsVlZ3?=
 =?utf-8?B?Q2xLU2pJRTdPRC9xS3NGS0hPYklsNEhJYndWbkE3d1pZRGQrSUhPZ1BMOGcv?=
 =?utf-8?B?RUxYKzVjWnBkaTFEMGRnK3JBYU01clI2ODM3eGZvcFhaZGtnMUhIS0lEeHhx?=
 =?utf-8?B?SStQbCttZEFkOHNCcUlqWEdNV0FvUG1qc1k4QmdtRzFCSWhDa2hxNnNUNnUv?=
 =?utf-8?B?MzlDQXcwVkNxLzFvbmFMb09FMzRWR2JienRTaHhCK01xZ2xFVlZiZkNNK0xV?=
 =?utf-8?B?NVVNUzltVVFJN3dZVUJOamJRRkI2cGJsRytSOEs1ekoreTF5dk1rblpJMnNX?=
 =?utf-8?B?bm50MnhHSWdrK1V0VFlROTdldGM3N3VCaGdzWU5XU1VibGxlTlhTNWpWdUFK?=
 =?utf-8?B?eXdxc0FOZ2FyQ2x6ZWdwdWE5eFczNVlwc1RmbWZmMzV0NTBjSUNWWmdSdHcz?=
 =?utf-8?B?WW5ob28xemt6Ulk0QW5UYlc2dzlQOGtPWk5Bd1BRQnNsdUFBTnhnMk5reHNw?=
 =?utf-8?B?S3ZYV2ZsN3ZkbGR4cy9zT1A5NDlHeHJlYkxsTzd5ZGFBNGFDL1dGdVRKcHY0?=
 =?utf-8?B?T0JBNEZUVEUwWXo4SGJvcml1RzN0aEkwTDBPeUJjYW5EVXFFMTRQYVowMExH?=
 =?utf-8?B?ZU5sT1VlMC9jazljNllReVphRXRVdzJrSmtFcXRFL1V4aHowYlJSaXkvVDdH?=
 =?utf-8?B?Qy93OXNMa1ZQRWdnazQxOC8zeURGOHk4Nk9WcHBFenR0VDRPbkozc3I3VElO?=
 =?utf-8?B?TmY0RlJYRi9pUlBjWmwrVnRuSFhkbWxoUFo4QkVVR1BwY2RZcWJnVTQvNHpy?=
 =?utf-8?B?SEh1WlBySTN1YVBsdWlQVDVtaGZDL3BNTnFFVTRGRnBEYVNIWDlyMzk0NWdl?=
 =?utf-8?B?Rk9ubmszT0F6S3VJSG4wMG1iWjhodHBwOVJsN3IrMmpTeGNMTXJXN1V0QW43?=
 =?utf-8?Q?e47qq3U4aVqr9xEJBfnUdg/QuQQUMhRJHl8BQVY?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c46e3f9-1c8b-4671-54e8-08d8cf6f3126
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4403.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2021 15:59:34.8528
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3eMcdrwwdQNQxPt6Pc7haQZ/BWAr6AjEkOZbkWNEhorO2Ze/4Ugeb3xaXgDw4DqW4+i4A50I0U+BBU7Y8EXqcA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3051
X-OriginatorOrg: Nvidia.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1613145591; bh=PGxgvwGmLROjZIYredrYug2Omsu8c9w171ZNtaAEwIQ=;
        h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:
         Authentication-Results:Subject:To:CC:References:From:Message-ID:
         Date:User-Agent:In-Reply-To:Content-Type:Content-Language:
         Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy:
         MIME-Version:X-MS-Exchange-MessageSentRepresentingType:
         X-MS-PublicTrafficType:X-MS-Office365-Filtering-Correlation-Id:
         X-MS-TrafficTypeDiagnostic:X-MS-Exchange-Transport-Forked:
         X-Microsoft-Antispam-PRVS:X-Header:X-MS-Oob-TLC-OOBClassifiers:
         X-MS-Exchange-SenderADCheck:X-Microsoft-Antispam:
         X-Microsoft-Antispam-Message-Info:X-Forefront-Antispam-Report:
         X-MS-Exchange-AntiSpam-MessageData:
         X-MS-Exchange-CrossTenant-Network-Message-Id:
         X-MS-Exchange-CrossTenant-AuthSource:
         X-MS-Exchange-CrossTenant-AuthAs:
         X-MS-Exchange-CrossTenant-OriginalArrivalTime:
         X-MS-Exchange-CrossTenant-FromEntityHeader:
         X-MS-Exchange-CrossTenant-Id:X-MS-Exchange-CrossTenant-MailboxType:
         X-MS-Exchange-CrossTenant-UserPrincipalName:
         X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg;
        b=Gz0/u9deOFaO0hRlsx5cOFAR/Ja/dfl44yKe014JHw/oUnxK9jScrhS2hKM1TtYwj
         DcZ9mcUZPOe8FRtPanzHM0l/WR6wyp8Y2MrfXNXwy/El1NDDG4p0neuHFYEpFNtJ94
         3SW7qV34l7mzFLBLySRkdPepBDfKxA/KC7cEb20s9HKHQN/PQZCYKpcYXqAIJ0TYsu
         Ry3Zh62tNq0DmgiKVBhxJKKv/2sHzEptv3TcsOHGTSXP4auaNDcc0CbvcIWR2dosFg
         CEktwIUML/OwToRJT3fW1TAaPiRx2T/lVavHi3RcWTmVDtwoAkgYmRLIX9YWODQHHJ
         Mk/sxXdvYq4CQ==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/02/2021 17:15, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
> 
> For the netlink interface, propagate errors through extack rather than
> simply printing them to the console. For the sysfs interface, we still
> print to the console, but at least that's one layer higher than in
> switchdev, which also allows us to silently ignore the offloading of
> flags if that is ever needed in the future.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
> Changes in v5:
> None.
> 
> Changes in v4:
> - Adjust the commit message now that we aren't notifying initial and
>   final port flags from the bridge any longer.
> 
> Changes in v3:
> - Deal with the br_switchdev_set_port_flag call from sysfs too.
> 
> Changes in v2:
> - br_set_port_flag now returns void, so no extack there.
> - don't overwrite extack in br_switchdev_set_port_flag if already
>   populated.
> 
>  net/bridge/br_netlink.c   |  9 +++++----
>  net/bridge/br_private.h   |  6 ++++--
>  net/bridge/br_switchdev.c | 13 +++++++------
>  net/bridge/br_sysfs_if.c  |  7 +++++--
>  4 files changed, 21 insertions(+), 14 deletions(-)
> 

Acked-by: Nikolay Aleksandrov <nikolay@nvidia.com>