Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3078140pxb; Fri, 12 Feb 2021 08:38:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJwntvepvX8tzu6mLGbGDFDH1NBw+HdXZpC6xdD0WxZt5aCobTNlMpL3IBXBX+lluK02Dlj9 X-Received: by 2002:a17:906:398c:: with SMTP id h12mr3882542eje.469.1613147929076; Fri, 12 Feb 2021 08:38:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613147929; cv=none; d=google.com; s=arc-20160816; b=t/j8UYhZjt0JJ+mYDVFLwPbVKM8EIRN6IPT1bJkLP+qBj1+vnaxUc5nRWVPeUm9stK R9rz2UrReOpyuVAgQr0TiXp4XLHEABYyuJEbbiW85nxmCBtYsKGYw3YvNSIKpOU0TxVq VzYjNzB6UNqGA6lWjR9Ldu94eRip5r+G9MKwcy9n8C8lUIKp377EW1WJHzooWcm/Fd/G jvAunLY3ATPx+Wj6A7olElJbaa8BjhEEU/qa3tC/ptKE64lqSIlarNOHICUO2pINgyNA ZbCyFNkbcaC3lTJ0LtIIBSeJ6WMEr9B2QSzI8vZOHUzpLO593yvm+7Ybm0PvsPlQ6L2Z mFAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=iXlLE7652JkIkE/EoWlBl/1BjMr3WVu7q/Sr5u+qMZk=; b=BEcWYgL6OFQN8TA1osH1cUnMrM39MbaXb9XgJQEeAzaVzdNxYajs4uIPTzk0LhI/Ry YKXpVqVUa3zDJElVxmQSrJuovJZcy0rDlyoiscQkmgXA5u6G+NetdNO7T1MazHfKQgCw TEmYZg9z/RNeO7tq7EWpnnjNWW6b/TfqFTUHqecp6ADF/PGSmImBLxb1Jj+cvypt6yqq UiLZoKiPiSEiwtpQH8VS1xBpVD9RcMGqAN0EQ/lDL7yY6Tu4hxeCRiC8UGwNUF3cyDE2 tYNcDP5WsJ5gQTFumRfCi89gEXBrcMKdNU9fWcnwOXYjuOC30/fLzmBd1BNSlcotVfyw SaJw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c4si6673590edy.405.2021.02.12.08.38.25; Fri, 12 Feb 2021 08:38:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230486AbhBLQgw (ORCPT + 99 others); Fri, 12 Feb 2021 11:36:52 -0500 Received: from elvis.franken.de ([193.175.24.41]:51425 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230199AbhBLQej (ORCPT ); Fri, 12 Feb 2021 11:34:39 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lAbO7-00056D-00; Fri, 12 Feb 2021 17:33:47 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 183D4C0E7B; Fri, 12 Feb 2021 17:33:35 +0100 (CET) Date: Fri, 12 Feb 2021 17:33:35 +0100 From: Thomas Bogendoerfer To: Tiezhu Yang Cc: Oleg Nesterov , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Xuefeng Li , kernel test robot , Xingxing Su Subject: Re: [PATCH v2] MIPS: Add basic support for ptrace single step Message-ID: <20210212163335.GA12558@alpha.franken.de> References: <1612939961-8827-1-git-send-email-yangtiezhu@loongson.cn> <20210211102905.GE7985@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210211102905.GE7985@alpha.franken.de> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 11, 2021 at 11:29:05AM +0100, Thomas Bogendoerfer wrote: > IMHO ptrace single step is for CPUs supporting single stepping and not > for emulating it in the kernel. I've checked other arch how they implement single step, and looks like I'm wrong. So I'm ok with applying your patch. Can you resend it again, so I'll get the latest version in patchwork ? Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]