Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3123965pxb; Fri, 12 Feb 2021 09:43:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJwpiD1tawe6IwgKz07LH2rMzqXpRmfl4VwFLbSDcYAx9CsaW9QZpk83QkjOa8UHYBEk+7R3 X-Received: by 2002:a17:906:3006:: with SMTP id 6mr4114093ejz.448.1613151838918; Fri, 12 Feb 2021 09:43:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613151838; cv=none; d=google.com; s=arc-20160816; b=PAZcE0UjBYxnEEiDnq8fQ/5k1cPMvegTQ+kQNgMYNUN5KR/Gctsw9wyhfX4uVB+PSi bL9DxV5WiDO8GNsStgjHsRygvuVBS8CqKV/V7pkRAnz0MemQoc0dBOTMRDXsKMOMNqtW yzCiGTN3412vW7U+yNZgDejg4T5QaXjcGg7rhenGgszqPE7iONN4AMuIZqAm7I9fYRhn IRqFBqsQs3c6Y6NbzGP9JpC6L0myaNDsxJl4hX6IweXPFqpvMPM8bIvUxnCgokEzMAYR FB7bNQReNF7tbwkbF2cbZ4duSH9E9FMNwGLxet0deSa8mkhw0QUm59NEdAiGs1bMlYWb R0Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:references:in-reply-to :message-id:date:subject:to:from:dkim-signature; bh=LeJkYXCorWtiaP+yCGj+HszRDmiDY/6LzTvN7R0PDJU=; b=T6iq7mjOVUS/QernJ7uTZqJ/+65BBZLW6REs+dyu7fJASf2Hi64B/C0R0z6HgiFng0 4O/ugyoXPJF+4uWMYl8l9kBVGni+N3OL4DnRo4crhCnXURPZf1AuYJknMEwR49MQB8zn FeDTKYzce65M58U0I394NVqH3zrEwU29CJdUJjpSOmgWjGhu1RPwzAfcZxEngA/qVWLg 31tnAPCNePD/UrYNT9KvZK7GmbchtfmrLs4uluazxKpcVQO4JBshmolpdYCiGjJTvlap 6eOnEYbLzEnc7QRJB+cZf9V9NZ2YIJsNaZp/MoqrN98e9iACxEzwiYQPwuwlI1pEXz5C D4fA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=OABOD7Iv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g25si6512740edr.526.2021.02.12.09.43.35; Fri, 12 Feb 2021 09:43:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=OABOD7Iv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231616AbhBLRmw (ORCPT + 99 others); Fri, 12 Feb 2021 12:42:52 -0500 Received: from smtprelay-out1.synopsys.com ([149.117.87.133]:43162 "EHLO smtprelay-out1.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231659AbhBLRjJ (ORCPT ); Fri, 12 Feb 2021 12:39:09 -0500 Received: from mailhost.synopsys.com (mdc-mailhost1.synopsys.com [10.225.0.209]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id D1FF5C044C; Fri, 12 Feb 2021 17:38:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1613151490; bh=71t8kLn/h4uRT+rZrsVOIM9WjcoyjC97XsyNd4xo0/8=; h=From:To:Subject:Date:In-Reply-To:References:In-Reply-To: References:From; b=OABOD7Iv2JQa9y2qvDNZ136yiLm7+FBIZ/a9ddLROXyEMq/P7bn915UfClCIUoCFH 2PKNeJ4AzYomc4gJSttDBqcOCK1Avs0nTVvO1NnGDCaQeYQMG0OzFBLtxmrWsbMvgi qz6a9OT/o9ISZp7UzR37K568keuMjelvhgFb0YWlwAyS3V4e0JnRIyEUp4MYior67T sGT0KWJUm05TOhxs6xvgw9Jn/i21nZQeagGrG+rlVhtP+UawQvF//WbPomyUkmd/q2 FzRuhsfpORRkQphQSD0FHlY4jbPDSgf9LJqds9OwG7bRQL3G2o//Rv23iGPxUW88qT nJ7+3coXgEhNA== Received: from de02dwia024.internal.synopsys.com (de02dwia024.internal.synopsys.com [10.225.19.81]) by mailhost.synopsys.com (Postfix) with ESMTP id A3E0FA005E; Fri, 12 Feb 2021 17:38:08 +0000 (UTC) X-SNPS-Relay: synopsys.com From: Gustavo Pimentel To: dmaengine@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Vinod Koul , Dan Williams , Bjorn Helgaas , Gustavo Pimentel Subject: [PATCH v6 12/15] dmaengine: dw-edma: Fix crash on loading/unloading driver Date: Fri, 12 Feb 2021 18:37:47 +0100 Message-Id: X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When the driver is compiled as a module and loaded if we try to unload it, the Kernel shows a crash log. This Kernel crash is due to the dma_async_device_unregister() call done after deleting the channels, this patch fixes this issue. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c index 8d8292e..f7a1930 100644 --- a/drivers/dma/dw-edma/dw-edma-core.c +++ b/drivers/dma/dw-edma/dw-edma-core.c @@ -986,22 +986,21 @@ int dw_edma_remove(struct dw_edma_chip *chip) /* Power management */ pm_runtime_disable(dev); + /* Deregister eDMA device */ + dma_async_device_unregister(&dw->wr_edma); list_for_each_entry_safe(chan, _chan, &dw->wr_edma.channels, vc.chan.device_node) { - list_del(&chan->vc.chan.device_node); tasklet_kill(&chan->vc.task); + list_del(&chan->vc.chan.device_node); } + dma_async_device_unregister(&dw->rd_edma); list_for_each_entry_safe(chan, _chan, &dw->rd_edma.channels, vc.chan.device_node) { - list_del(&chan->vc.chan.device_node); tasklet_kill(&chan->vc.task); + list_del(&chan->vc.chan.device_node); } - /* Deregister eDMA device */ - dma_async_device_unregister(&dw->wr_edma); - dma_async_device_unregister(&dw->rd_edma); - /* Turn debugfs off */ dw_edma_v0_core_debugfs_off(chip); -- 2.7.4