Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 3/4] perf archive: Fix filtering of empty build-ids
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Ian Rogers <irogers@google.com>,
        "Frank Ch. Eigler" <fche@redhat.com>,
        Song Liu <songliubraving@fb.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Kim Phillips <kim.phillips@amd.com>,
        Tommi Rantala <tommi.t.rantala@nokia.com>,
        Remi Bernon <rbernon@codeweavers.com>,
        linux-kernel@vger.kernel.org,
        Ulrich Czekalla <uczekalla@codeweavers.com>,
        Huw Davies <huw@codeweavers.com>
References: <7708cca1-b8f6-c394-75f1-5f9681d625d0@codeweavers.com>
 <20210212122901.GB1398414@kernel.org>
From:   Nicholas Fraser <nfraser@codeweavers.com>
Message-ID: <8f50e586-ae58-ef4e-a594-e2248203a2a7@codeweavers.com>
Date:   Fri, 12 Feb 2021 13:49:36 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <20210212122901.GB1398414@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

The current version of "perf buildid-list" prints missing build-ids as
blank even when loading perf.data files generated from older versions of
perf. I've tested with a few older versions.

Since perf-archive is an external script that calls back into perf, it
could in theory find a different older version that still returns zeroes.
We could make it look for a matching perf, e.g. "$(dirname "$0")/perf".
Unfortunately that won't work in general because at least on my system
perf-archive is installed to a different path than perf.

Nick


On 2021-02-12 7:29 a.m., Arnaldo Carvalho de Melo wrote:
> Em Wed, Feb 10, 2021 at 02:17:49PM -0500, Nicholas Fraser escreveu:
>> A non-existent build-id used to be treated as all-zero SHA-1 hash.
>> Build-ids are now variable width. A non-existent build-id is an empty
>> string and "perf buildid-list" pads this with spaces.
>>
>> This fixes "perf-archive" to skip missing build-ids by skipping lines
>> that start with a padding space rather than with zeroes.
>>
>> Signed-off-by: Nicholas Fraser <nfraser@codeweavers.com>
>> ---
>>  tools/perf/perf-archive.sh | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/tools/perf/perf-archive.sh b/tools/perf/perf-archive.sh
>> index 0cfb3e2cefef..133f0eddbcc4 100644
>> --- a/tools/perf/perf-archive.sh
>> +++ b/tools/perf/perf-archive.sh
>> @@ -20,9 +20,8 @@ else
>>  fi
>>  
>>  BUILDIDS=$(mktemp /tmp/perf-archive-buildids.XXXXXX)
>> -NOBUILDID=0000000000000000000000000000000000000000
>>  
>> -perf buildid-list -i $PERF_DATA --with-hits | grep -v "^$NOBUILDID " > $BUILDIDS
>> +perf buildid-list -i $PERF_DATA --with-hits | grep -v "^ " > $BUILDIDS
>>  if [ ! -s $BUILDIDS ] ; then
>>  	echo "perf archive: no build-ids found"
>>  	rm $BUILDIDS || true
> 
> What should we do when using older files? We have to support both cases.
> 
> - Arnaldo
>