Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3169421pxb; Fri, 12 Feb 2021 10:53:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJz8EfxnvGXAloR1JQXMEJvMm7RRIAp+/XrLzx8OE7Lq7JDjyypVevJ2R8vNT6RdGDy/2rI2 X-Received: by 2002:a17:906:90c5:: with SMTP id v5mr4034545ejw.398.1613156021112; Fri, 12 Feb 2021 10:53:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613156021; cv=none; d=google.com; s=arc-20160816; b=e6Yp8oxjkuPQJm5cJfS+2ToxwxbL4biBDJWGccnusy+Gv8Qh+l9LxHBSDn/GatdCer lJaSF+/AnqeGZWhRpZX0hknqq4xHKWwnk9/oJySK7kC9QFNk2MAR9f+BadO1J1Ryx5M5 I+BMhhe8P1q7+ibON5FEMlrhaUGckZwFFGf7Q1NGvZHiVq+XfhDQ2+dpg+uKrjEa9auo GMgwfnaEnlVzUbAX1yVqwdSAMe/iRz7Z8EMh/LS0EMryObo97KyhJRKly6wXFPbDEbYc Wof5Kt6xl5yn9YzotfHBIBbu7HMkVaIQKZgyj/ZCR3/5bDCQSLhiqlXceITxyIlPOFUC d12Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=rAjUasmM9yp+S6QX/rjU5H8H6eBdqMECNjAM3EwxUIA=; b=KaONERkzbNyURbQoiRDXM47QJwHgPYYvxwsKY0f166XI2a9kS04VZ0Snc6+eueQ9We k4ZGKJJ2XmufFNe7Z44ZDEI5jf064sv2duZCLo8h0WeX+Imc5ke/V0PCnZxQnZVBjBe0 WrJsxJ5mvOR4GHCwTNFjvX6lyTdO6Vk6rWfvI3LjeeAY2wOx5uijOP4chIV3MQQB+oHq Pfjq7a+xoi9hdPeitnmVIQvKmO1/cxnJZ0pJVKFiROY8CBqMaSxEWhj75ibMN1F1Z1QF MTibrrx5RN+OPJ6hxFocEgo04iTVCaOTYXxmZaDpntp2B7Bif7b2Oa/jUJQqzAIWSyhw JVzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=K4VklQHD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b67si7009074edf.215.2021.02.12.10.53.16; Fri, 12 Feb 2021 10:53:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=K4VklQHD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231687AbhBLSu6 (ORCPT + 99 others); Fri, 12 Feb 2021 13:50:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:56552 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229558AbhBLSuy (ORCPT ); Fri, 12 Feb 2021 13:50:54 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id BBFA164E9A; Fri, 12 Feb 2021 18:50:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613155814; bh=ca8NmUoXUMn3p9qX2HDf8b5wDt/sG8WeAWOl8PNCSNg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=K4VklQHDUj8mWEb4wGE+IuW8XY3tfX4XirqHLdhm8NL4rRGvgVWiVNrEvoxd6asMG acVSKvNhW3JF1eqQ5NwuH3d0FjbRoA9Jy0OSLAoJCv0fSfOHkjRzrm29M5qVl2vPtU Wwznm6jAIELdvqqJlKO+oYn/+SZ6+FLVHvzxuDFfOwRxA3SUS0T6Er7pqO45IgwblN 03l+2BdTTavhsowiNsAod+LFVICJE53KYG2i8h1lZDGdWFMS3WixWKhAjcqtiLzfzF mQ9qo4LiufgHRs4PO1EgIdrAd6LjE/87ihsC5G+Ive0cmdYr8YCkpDV17IasBPBSHL DQmXm/TC6oHXA== Date: Fri, 12 Feb 2021 10:50:12 -0800 From: Jakub Kicinski To: AngeloGioacchino Del Regno Cc: elder@kernel.org, bjorn.andersson@linaro.org, agross@kernel.org, davem@davemloft.net, linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, konrad.dybcio@somainline.org, marijn.suijten@somainline.org, phone-devel@vger.kernel.org Subject: Re: [PATCH v1 5/7] net: ipa: Add support for IPA on MSM8998 Message-ID: <20210212105012.2f425230@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210211175015.200772-6-angelogioacchino.delregno@somainline.org> References: <20210211175015.200772-1-angelogioacchino.delregno@somainline.org> <20210211175015.200772-6-angelogioacchino.delregno@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 Feb 2021 18:50:13 +0100 AngeloGioacchino Del Regno wrote: > MSM8998 features IPA v3.1 (GSI v1.0): add the required configuration > data for it. >=20 > Signed-off-by: AngeloGioacchino Del Regno This one does not build: drivers/net/ipa/ipa_data-msm8998.c:382:3: error: =E2=80=98struct ipa_clock_= data=E2=80=99 has no member named =E2=80=98interconnect=E2=80=99; did you m= ean =E2=80=98interconnect_data=E2=80=99? 382 | .interconnect =3D { | ^~~~~~~~~~~~ | interconnect_data drivers/net/ipa/ipa_data-msm8998.c:382:2: warning: braces around scalar ini= tializer 382 | .interconnect =3D { | ^ drivers/net/ipa/ipa_data-msm8998.c:382:2: note: (near initialization for = =E2=80=98ipa_clock_data.interconnect_count=E2=80=99) drivers/net/ipa/ipa_data-msm8998.c:383:4: error: =E2=80=98IPA_INTERCONNECT_= MEMORY=E2=80=99 undeclared here (not in a function) 383 | [IPA_INTERCONNECT_MEMORY] =3D { | ^~~~~~~~~~~~~~~~~~~~~~~ Each commit must build cleanly and not add any transient W=3D1 C=3D1 warnings.