Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3218937pxb; Fri, 12 Feb 2021 12:18:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJxP4HJ3UzjKkomiMN6UzUq/WemBpiwG++k4/syqP4xXu7c+oxPw6KIH2BbuRomCOwtky3vx X-Received: by 2002:aa7:d60f:: with SMTP id c15mr5160984edr.291.1613161081995; Fri, 12 Feb 2021 12:18:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613161081; cv=none; d=google.com; s=arc-20160816; b=JTILIvRWyBe7L51kLllTlNyCBxgQt5EcS9K9grdALa+25lRk20hEFrDLStIHshaUDq gxVt5eMxXfUjO1tzASODvaDrXqjiJfHamHY65btePcKU8Oe3TSHYIUhZhSqD9SSufnw5 4CX5N2morocKgdFCg4j4DMp0k9/uvOeQKuL0vRvsLfE3tYPaAcjxg0uz8FH413QFmCFw wmjz8CP5d5bWQag4w1WNxdT9NPNnrbY9zUkrvsWpiF69+bPyR6EitDoSmQc1CrTupS4Z MJomrt69C6r2RyDcOmsSGR0SYgif3pr6sbjZb25RKXqNf4y1VmCKMWwOyr2xI3hNzH13 P0vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=86YuSJCwc55KUOmNf/A3C8FQ9KMioYrgFWSAePLtRo0=; b=xoeXzUPVt7d6XFj5w52/bzyFJ2Z5B0Z1MMBy7OmJTwQnTqUccWrVWHEQnvL3CUPMgj Bb2Y1jx76WtYY1wN0aYEXjHHF8vnuaCJa+X8OBeq9xV8ni3Yf1fkxVGNDasc8n691Mt1 /7IchBAP4ooXRUzRCZ9zqrAoYXE+mMxZ03m3nlwS9+AP/Npt+NQ0Nj/MTGM5Yxt2i4Ck y/chofxGnS+JASzv55niFCNDvt7k6fhgGJTHVA4kx8s+1gZ9pvqc40CSGcxVOWyxRH3R /9J3Bh+1JkjAqicY717woMC8huIN6aWWxZbbV7K5PrDXFn1vySmSVOW40dn0E2Z9k9Mu 9GCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b="XZc0O/AH"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h91si7307672edd.384.2021.02.12.12.17.38; Fri, 12 Feb 2021 12:18:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b="XZc0O/AH"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231330AbhBLUQ7 (ORCPT + 99 others); Fri, 12 Feb 2021 15:16:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:51532 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230227AbhBLUQv (ORCPT ); Fri, 12 Feb 2021 15:16:51 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id AFB1764E8A; Fri, 12 Feb 2021 20:16:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1613160971; bh=Z6BeODGzyRx31VY22FuktGBOIe3w+i59UrY0eDPk1GU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XZc0O/AHZdME36mBlSpuJdaTY86T1zGR/Y8O1geqGr3tJc8lInivmvBY/iG5gMK/1 NpxE17zhrMoPpLnCDQrfGi3aBw0mAUQxTyUBpmxB5OaQlm4tSPchaNe/Srul9UUh+4 lp+bEV3E7OyO9/FkAgl3yJXmPMw3I3BAfrWesAGk= Date: Fri, 12 Feb 2021 12:16:10 -0800 From: Andrew Morton To: Andrey Konovalov Cc: Catalin Marinas , Vincenzo Frascino , Will Deacon , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Christoph Hellwig , kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH mm] kasan: export HW_TAGS symbols for KUnit tests Message-Id: <20210212121610.ff05a7bb37f97caef97dc924@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 12 Feb 2021 21:08:52 +0100 Andrey Konovalov wrote: > Currently, building KASAN-KUnit tests as a module fails with: > > ERROR: modpost: "mte_enable_kernel" [lib/test_kasan.ko] undefined! > ERROR: modpost: "mte_set_report_once" [lib/test_kasan.ko] undefined! > > This change adds KASAN wrappers for mte_enable_kernel() and > mte_set_report_once() and only defines and exports them when KASAN-KUnit > tests are enabled. > > The wrappers aren't defined when tests aren't enabled to avoid misuse. > The mte_() functions aren't exported directly to avoid having low-level > KASAN ifdefs in the arch code. > Please confirm that this is applicable to current Linus mainline? Today is pretty much the last day for getting material into 5.11, and this patch has been churning somewhat. So I think it would be better to merge this into 5.12-rc1, with a cc:stable so it goes into 5.11.1. For which we'll need a Fixes:, please?