Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3247755pxb; Fri, 12 Feb 2021 13:10:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJz5JBwdFmJxEC98rHSSsbBTiSjuY84YD74/9zXGPy9trRzKi0tMYq22gHQ0bB6i6FbF6cYn X-Received: by 2002:a50:bc15:: with SMTP id j21mr5262920edh.187.1613164227942; Fri, 12 Feb 2021 13:10:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613164227; cv=none; d=google.com; s=arc-20160816; b=Chmp225RGrYjYDyxP2mf9sudOehsSD89Y1whgkrC5RsxbbtrttpXSb8+GL2ICyn4Rm US5kx5lkx7E/MIsfauYPuifUNX+ve7njCSFMqBOTxrjGiOsufpNN6ph+HWfX9aToFygY REWDXWYlofr4AlDj+uCeLfRBYsOHEezdnvMNS6teidRAxjebHwRYe0NQSJKd1RPnPXt8 ZLjlfOildivqw4pPeMFvLHMJkvGEZ5MyIXRTeqUxz4vURwt/Algm7sCvVA1E2sW0yJvh tlrZjurM1ur1J8IxCUBlMD96ntx1KNfx5deaPr7wPDo+eMKZrawBP34l9yaGSI8jyhEU c8bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=mZyKbkdDMu0MKT78PU74CX+OvPDtOK/WA93Ky3pQof8=; b=qYSUwrQOPPx0M/Bk1wnqZ18SSoDjLz+NVD9vMD8ciA3sABBWozJvGlnpSxGpeYKRiv UfQDXKBq/mtcGVoJbvckrSH9kR+173qSjECQGlqR3XxMA3j4wwuoExYZg6ahlr22Qkh5 kNZBxDb+e/EfT2o73Eu/fzuF+fb67vf7BPocpP1sG6am+7zHL2hhNLbVGh6vOBfSoxon FaNsW8LQT9//oRJtJjY9iZRSqxlL1Qd2khwOQsDrBaLjSre2mKzr+gbt3/EECyImtulJ TJ+ER/OwKuK2UQEdpq9O38vMoTvfoEFrLa5ZpLBO0is4Bn0Tc43NHzg/ai1gg+EM8ef7 hdCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=dU5l63E+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s28si7138591edy.162.2021.02.12.13.10.04; Fri, 12 Feb 2021 13:10:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=dU5l63E+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231942AbhBLVJB (ORCPT + 99 others); Fri, 12 Feb 2021 16:09:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:58732 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231289AbhBLVI6 (ORCPT ); Fri, 12 Feb 2021 16:08:58 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0CAEE601FF; Fri, 12 Feb 2021 21:08:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1613164097; bh=TshSgO+ebZMoA2lgK0wETLr/ZM7OS4W2rKQLUJLiZOU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dU5l63E+JgxMA9hCk/3yD9QdirwmUXp/uYUF/gEWBBbbw6aFNgKIWCCg8n7d9iNNh xIokgctQ+x5kt8jukAVR82rLaJELRFGZ940HgrgWFfqL+372qV9zOpCQ3jCpX4vpsx 0hLdVCahws96UqaUmfsgjYBkWnBv4Yf5GBg//51o= Date: Fri, 12 Feb 2021 13:08:16 -0800 From: Andrew Morton To: Andrey Konovalov Cc: Catalin Marinas , Vincenzo Frascino , Will Deacon , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Christoph Hellwig , kasan-dev , Linux ARM , Linux Memory Management List , LKML Subject: Re: [PATCH mm] kasan: export HW_TAGS symbols for KUnit tests Message-Id: <20210212130816.cde26643a6b9b24007be4e54@linux-foundation.org> In-Reply-To: References: <20210212121610.ff05a7bb37f97caef97dc924@linux-foundation.org> <20210212125454.b660a3bf3e9945515f530066@linux-foundation.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 12 Feb 2021 22:01:38 +0100 Andrey Konovalov wrote: > On Fri, Feb 12, 2021 at 9:54 PM Andrew Morton wrote: > > > > On Fri, 12 Feb 2021 21:21:39 +0100 Andrey Konovalov wrote: > > > > > > > The wrappers aren't defined when tests aren't enabled to avoid misuse. > > > > > The mte_() functions aren't exported directly to avoid having low-level > > > > > KASAN ifdefs in the arch code. > > > > > > > > > > > > > Please confirm that this is applicable to current Linus mainline? > > > > > > It's not applicable. KUnit tests for HW_TAGS aren't supported there, > > > the patches for that are in mm only. So no need to put it into 5.11. > > > > So... which -mm patch does this patch fix? > > "kasan, arm64: allow using KUnit tests with HW_TAGS mode". > > There will be some minor adjacent-line-changed conflicts if you decide > to squash it. > > Alternatively, this can go as a separate patch after the tests series > (after "kasan: don't run tests when KASAN is not enabled"). Thanks - it wasn't obvious. I staged it as a fix against "kasan, arm64: allow using KUnit tests with HW_TAGS mode". To make the series as nice as we can, and to avoid bisection holes.