Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <e7eeb252da408b08f0c81b950a55fb852f92000b.1613155970.git.andreyknvl@google.com>
 <20210212121610.ff05a7bb37f97caef97dc924@linux-foundation.org>
 <CAAeHK+z5pkZkuNbqbAOSN_j34UhohRPhnu=EW-_PtZ88hdNjpA@mail.gmail.com>
 <20210212125454.b660a3bf3e9945515f530066@linux-foundation.org>
 <CAAeHK+w6znh95iHY496B15Smtoaun73yLYLCBr+FBu3J57knzQ@mail.gmail.com> <20210212130816.cde26643a6b9b24007be4e54@linux-foundation.org>
In-Reply-To: <20210212130816.cde26643a6b9b24007be4e54@linux-foundation.org>
From:   Andrey Konovalov <andreyknvl@google.com>
Date:   Fri, 12 Feb 2021 22:10:24 +0100
Message-ID: <CAAeHK+y20nuSLs1bQO2wyND5S1xFRDHNvvL07Jk8y72tF11O_w@mail.gmail.com>
Subject: Re: [PATCH mm] kasan: export HW_TAGS symbols for KUnit tests
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Catalin Marinas <catalin.marinas@arm.com>,
        Vincenzo Frascino <vincenzo.frascino@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        Andrey Ryabinin <aryabinin@virtuozzo.com>,
        Alexander Potapenko <glider@google.com>,
        Marco Elver <elver@google.com>,
        Peter Collingbourne <pcc@google.com>,
        Evgenii Stepanov <eugenis@google.com>,
        Branislav Rankov <Branislav.Rankov@arm.com>,
        Kevin Brodsky <kevin.brodsky@arm.com>,
        Christoph Hellwig <hch@infradead.org>,
        kasan-dev <kasan-dev@googlegroups.com>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Linux Memory Management List <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Feb 12, 2021 at 10:08 PM Andrew Morton
<akpm@linux-foundation.org> wrote:
>
> On Fri, 12 Feb 2021 22:01:38 +0100 Andrey Konovalov <andreyknvl@google.com> wrote:
>
> > On Fri, Feb 12, 2021 at 9:54 PM Andrew Morton <akpm@linux-foundation.org> wrote:
> > >
> > > On Fri, 12 Feb 2021 21:21:39 +0100 Andrey Konovalov <andreyknvl@google.com> wrote:
> > >
> > > > > > The wrappers aren't defined when tests aren't enabled to avoid misuse.
> > > > > > The mte_() functions aren't exported directly to avoid having low-level
> > > > > > KASAN ifdefs in the arch code.
> > > > > >
> > > > >
> > > > > Please confirm that this is applicable to current Linus mainline?
> > > >
> > > > It's not applicable. KUnit tests for HW_TAGS aren't supported there,
> > > > the patches for that are in mm only. So no need to put it into 5.11.
> > >
> > > So... which -mm patch does this patch fix?
> >
> > "kasan, arm64: allow using KUnit tests with HW_TAGS mode".
> >
> > There will be some minor adjacent-line-changed conflicts if you decide
> > to squash it.
> >
> > Alternatively, this can go as a separate patch after the tests series
> > (after "kasan: don't run tests when KASAN is not enabled").
>
> Thanks - it wasn't obvious.
>
> I staged it as a fix against "kasan, arm64: allow using KUnit tests
> with HW_TAGS mode".  To make the series as nice as we can, and to avoid
> bisection holes.

Sounds good, thank you!