Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v5 02/10] hugetlb/userfaultfd: Forbid huge pmd sharing
 when uffd enabled
To:     Axel Rasmussen <axelrasmussen@google.com>,
        Peter Xu <peterx@redhat.com>
Cc:     Alexander Viro <viro@zeniv.linux.org.uk>,
        Alexey Dobriyan <adobriyan@gmail.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Anshuman Khandual <anshuman.khandual@arm.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Chinwen Chang <chinwen.chang@mediatek.com>,
        Huang Ying <ying.huang@intel.com>,
        Ingo Molnar <mingo@redhat.com>, Jann Horn <jannh@google.com>,
        Jerome Glisse <jglisse@redhat.com>,
        Lokesh Gidra <lokeshgidra@google.com>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        =?UTF-8?Q?Michal_Koutn=c3=bd?= <mkoutny@suse.com>,
        Michel Lespinasse <walken@google.com>,
        Mike Rapoport <rppt@linux.vnet.ibm.com>,
        Nicholas Piggin <npiggin@gmail.com>, Shaohua Li <shli@fb.com>,
        Shawn Anastasio <shawn@anastas.io>,
        Steven Rostedt <rostedt@goodmis.org>,
        Steven Price <steven.price@arm.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-fsdevel@vger.kernel.org, Linux MM <linux-mm@kvack.org>,
        Adam Ruprecht <ruprecht@google.com>,
        Cannon Matthews <cannonmatthews@google.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        David Rientjes <rientjes@google.com>,
        Mina Almasry <almasrymina@google.com>,
        Oliver Upton <oupton@google.com>
References: <20210210212200.1097784-1-axelrasmussen@google.com>
 <20210210212200.1097784-3-axelrasmussen@google.com>
 <0a991b83-18f8-cd76-46c0-4e0dcd5c87a7@oracle.com>
 <20210212204028.GC3171@xz-x1>
 <CAJHvVchJtjpjNUYTGw1m568w_GTK_KMKbu0MLyvK8gcbrs6S7A@mail.gmail.com>
From:   Mike Kravetz <mike.kravetz@oracle.com>
Message-ID: <4a651313-0e14-35da-0223-8805cd1ac1c7@oracle.com>
Date:   Fri, 12 Feb 2021 13:27:49 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.1
In-Reply-To: <CAJHvVchJtjpjNUYTGw1m568w_GTK_KMKbu0MLyvK8gcbrs6S7A@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.2.112] (50.38.35.18) by MWHPR1701CA0016.namprd17.prod.outlook.com (2603:10b6:301:14::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.27 via Frontend Transport; Fri, 12 Feb 2021 21:27:50 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c1d0277e-59e2-4a29-3670-08d8cf9d0d15
X-MS-TrafficTypeDiagnostic: MWHPR10MB2030:
X-Microsoft-Antispam-PRVS: <MWHPR10MB20309136178E5BD7A082154DE28B9@MWHPR10MB2030.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: cM4MjhSckt1jj75AGVONXLk8NGfDraucsgPXvPgWz+Lp9gSZ+7UZrYchcDDXybI1FJv4haSJi0GiicmS8FDUtTxELxmYBQmfqPTEScE5t0oLhXzBaL8u18tlRUiozAApEz+oIM5K2q5WG/UhvGRg95KqCjo7xVLRe/1LmCnF6+NjdYhL/+qQuIuqKnWg/4mkOdECL3KdEE5vJ26FPTObPFgrLdA2e7tfQrD+UlT+1+6VT+hhq9tkokJievk/Lu8TFw4dsDezATNZ1XCK1EBd8znqacQovqvtTnn9xUtltPUGU6JUnXZ7vBjn1fsCIMq3Y6/+3NqbmwTXTqbbA0ONsjv3YZaXyGd/VH/wUH4b5/OcvefsAyVK2JZwpNuW/+xuIBlNt5msYwxi62mqTj9/SsCLfydiYo8PXRA1/pFkVxUnOIOjynnwiM/BYe5fhKWZdU9KEi2HX2iq6hHM4MNyZn/1pfUo05QGY4RhMVgXR29vbzh3q5P0nehoScyzwWRVE0gZU2oR0nwR1AJAU2aLAABJVdQt8GRwyeUiiBDHkCbBVd/3vP8Oj3GlMqbAunFtlEZZ2VoCrHfj8hQQJLtDiEzPPTj8c3l5B+wZD8YzKLp0TUrMZ1SoDxjyJzoKB8WokbhCma9XWVJk1W1mvVyRLONS1VK62VJbY4FVqKBoZM0=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR10MB1389.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(39860400002)(136003)(396003)(346002)(376002)(31686004)(31696002)(7406005)(7416002)(36756003)(6486002)(26005)(186003)(8676002)(52116002)(16526019)(478600001)(316002)(2906002)(110136005)(16576012)(86362001)(54906003)(956004)(2616005)(66556008)(8936002)(5660300002)(66946007)(66476007)(53546011)(44832011)(4326008)(21314003)(14583001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Umw0dXhURGtXd0owVFVKUzQzdXZRTXBJbXhxUnhjQk5POHI1VXJkUGNHNVRN?=
 =?utf-8?B?UEhJdnk1UldmN1Z4alozT082RyttSzc1YWlMNi9ZR3laTERaRGFHUFo5KzU3?=
 =?utf-8?B?VFJjQWNPR09vK2UySjMyTEdvOWFDV1FCT1lCbDd5eXJTd2xLaHJnR2ltYXN3?=
 =?utf-8?B?Ui9yK0NnQlZCcGZ3c0szRjBudXFlL3EwZ0pBTzhWeWtiNEpYNTlISkdkall2?=
 =?utf-8?B?Qnk2a2M1UWNUSWkrN05kd0xkaGczTzA2SFlHUjFhVEdvdmE0alY1RldyS3Zp?=
 =?utf-8?B?QWl6RWcyK1BoYzBNVSsvY0h0ZnBoMzlPOXVUNEZrVFVtbnhTQ3FCNlg2dmNG?=
 =?utf-8?B?LzErRWM3cVlGOG9OR1pUQUxJQ2JBcTZVN245SjBSSEYrNVYzNG1HM3BoNU15?=
 =?utf-8?B?SmN1b0JpdWk4MGZ6YmRoaXlHTzN5bEFNWXhZRmI1RjJ5K1pDYjYyMGlnVmU4?=
 =?utf-8?B?ZmVXYldjSXNuMVVFQSs4VlpETTZ0VHhDMWdUUXRYbWhaSWc1dmxpZTZER0Zj?=
 =?utf-8?B?Z2Yyd01jeDV3ZTZsdUxaTXlMMHh5THk0TEgzaGdCeG5RMHVZVUVlNDcrbEJ0?=
 =?utf-8?B?eTR1UTJZdUpVWlgwMUNGWmllQUFPbEtnNHF6TEdYSnArQTB1QzAwbnJjSkdE?=
 =?utf-8?B?Z3dXOG51WEEwZG9FRjJmc2NTcmtobEJXQzlzWUt0b0k3OWZHemJKREc4Zy9N?=
 =?utf-8?B?SjhvTUN5KzZ1RE9mVWFDaGdwYitXS1Q1ZmZYbkxRMlVjUWs4NDVWL2tXNlZX?=
 =?utf-8?B?K3VpNkVkWGJtdTRvQ3hkSU5qekNyZXpnZDV6SXU2TzJDdWk2dWVZNkZrY3d4?=
 =?utf-8?B?ZDBUZzlYRW1hMFZaSGlwRFZNanB3bncrQ00vMjdkNi9xRldiUW5SbUhmU3VS?=
 =?utf-8?B?RFQ2TlZpQW50LzYzM3BuczgxNHB1U3F4ODVjc2pNT2ZSTE5lQUNBcUFjMFBF?=
 =?utf-8?B?ZkRHMGZ3MGx3MWpHMGg3TXlGUlhodkZUdlNmNnE0dGJnSTRTU3J6NmkvamR1?=
 =?utf-8?B?NHRPaTU1bGJlMGR5WlBDaURsdTdTN3U1ZHR3blFENDdqR013KzJ3SWVDVnZk?=
 =?utf-8?B?L3FGOXo2eEhTekNCT0s1Y3F2eHVhTllXRWR6Um5vQ1ZjdldUN1VRWHdIQkpy?=
 =?utf-8?B?a1JNTTZnTWVFNVpqSWVQVytvWEZMemtuRnd1QXAveCtjK3FaUjRZS3BQcDYv?=
 =?utf-8?B?RS9qYTAxRG5lKzR6MzZqeTlIeG5Ka3NiRkJwaHovR29sMS9qV1c2OWVaNmdp?=
 =?utf-8?B?Y2FZVEMrOGt3R0RFOWJySzJ6LytmQUVWMERjWjRhVWt5TGFzNGJuOUk1UHAv?=
 =?utf-8?B?aExIVkg1VnVKd0hrUi9pZFZwWGh0MEVxYldHUkFCTWFCU3ZUMVRFai83aTlK?=
 =?utf-8?B?Yy9sT1N1YldzeU94eDhZS0FMVndOSTdhb00yU3RleFpvTDNKSGJjc0tYYlNT?=
 =?utf-8?B?cis0YStGOFlwWnphUkZsY3lXZlJvUGNlMEVMRnhQMkorVDNSVzBFV2FScXZ5?=
 =?utf-8?B?WXhBS0xWTnVsVnFpTnFmakFHa0VSUnlYWEprR2l4ZmJnYnZWS01jdWpQZ0JB?=
 =?utf-8?B?N2trMVlBajBqSm1pcTlYTk5yd1cxdktLZDRVSTdUakh1ZHJlQWs0cjVpcGpz?=
 =?utf-8?B?aXdMaGRQdWFoREltQVE3NUE5VnpzTTQ2NTUvY2FROG5XdHc0aUNJREpjeFE0?=
 =?utf-8?B?VlNGMVJGSEEzYk5lWHhoWFdSUGQ5cDhpN1ZIOU9Ralo0KzNYR09KTmlCd3Rt?=
 =?utf-8?Q?7huXrYu2SejUjxOgbpdtJmUwBxMkpe9bBJcaXGE?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c1d0277e-59e2-4a29-3670-08d8cf9d0d15
X-MS-Exchange-CrossTenant-AuthSource: MWHPR10MB1389.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2021 21:27:51.1853
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UZEWD+UEfYph9rKYXhw0oQrf+XoM84sLI1UPydofXzyBoMn+Ke3HUbPwOjRWGmy7yDszYTjySRaYLg4XGKTAAg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB2030
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9893 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 phishscore=0
 mlxscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2102120158
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9893 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 mlxlogscore=999
 bulkscore=0 suspectscore=0 phishscore=0 adultscore=0 impostorscore=0
 mlxscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2102120158
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/12/21 12:47 PM, Axel Rasmussen wrote:
> On Fri, Feb 12, 2021 at 12:40 PM Peter Xu <peterx@redhat.com> wrote:
>>
>> On Thu, Feb 11, 2021 at 04:19:55PM -0800, Mike Kravetz wrote:
>>> want_pmd_share() is currently just a check for CONFIG_ARCH_WANT_HUGE_PMD_SHARE.
>>> How about leaving that mostly as is, and adding the new vma checks to
>>> vma_shareable().  vma_shareable() would then be something like:
>>>
>>>       if (!(vma->vm_flags & VM_MAYSHARE))
>>>               return false;
>>> #ifdef CONFIG_USERFAULTFD
>>>       if (uffd_disable_huge_pmd_share(vma)
>>>               return false;
>>> #endif
>>> #ifdef /* XXX */
>>>       /* add other checks for things like uffd wp and soft dirty here */
>>> #endif /* XXX */
>>>
>>>       if (range_in_vma(vma, base, end)
>>>               return true;
>>>       return false;
>>>
>>> Of course, this would require we leave the call to vma_shareable() at the
>>> beginning of huge_pmd_share.  It also means that we are always making a
>>> function call into huge_pmd_share to determine if sharing is possible.
>>> That is not any different than today.  If we do not want to make that extra
>>> function call, then I would suggest putting all that code in want_pmd_share.
>>> It just seems that all the vma checks for sharing should be in one place
>>> if possible.
>>
>> I don't worry a lot on that since we've already got huge_pte_alloc() which
>> takes care of huge pmd sharing case, so I don't expect e.g. even most hugetlb
>> developers to use want_pmd_share() at all, because huge_pte_alloc() will be the
>> one that frequently got called.
>>
>> But yeah we can definitely put the check logic into huge_pmd_share() too.
>> Looking at above code it looks still worth a helper like want_pmd_share() or
>> with some other name.  Then... instead of making this complicated, how about I
>> mostly keep this patch but move want_pmd_share() call into huge_pmd_share()
>> instead?

When looking at this again, all I was suggesting was a single routine to
check for the possibility of pmd sharing.  That is what the version of
want_pmd_share in this patch does.

I have some patches for future optimizations that only take i_mmap_rwsem
in the fault path if sharing is possible.  This is before huge_pte_alloc.
want_pmd_share as defined in this patch would work for that.

Sorry for the noise.
-- 
Mike Kravetz