Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3262247pxb; Fri, 12 Feb 2021 13:37:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJxeMlVkHUFkV5Sbnn1GQyMohRm3PunMmDmDxP/q7VdWBRp6vGFJu3+JKEYHEjFL2PPlAykT X-Received: by 2002:aa7:c889:: with SMTP id p9mr5332472eds.224.1613165879358; Fri, 12 Feb 2021 13:37:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613165879; cv=none; d=google.com; s=arc-20160816; b=geKQ9LJaIIf6rpxnUUEwLDKi/HwbUQ24IJvenLxYHnH3ld2Mp+NGthXuJsNzxkjjcB f1hDLFUKy4Wc+ZbsFJMwlfy0Ghn/jNd/p3TcgS426RmzyI/F6OUmn5VwbtqsVBYFGBgG Hgd5BpaVToTKjgLklBztBxOTOmz3x2b/tz7s1bntI0R7oir95x1oPJd7KxtobrwLX3vF d741M2qEYO4P5+9yS7SfukloLnYMT6cXjAshbmaw+5hc8ywIwRTizqEdxl+aWzXhDkzm vQeTPyBKchVGj1xyOfF0aWWHm4jsXN1JbNBWCWRALbgnDAbyL6h41w/Crg4dmZSIT/PG Oaog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:thread-index:thread-topic :content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date; bh=0Ltr4Qw1afIRCs6NqsTBrgX3L6v3fg3czh1xxSEDMQY=; b=Pict2CKRfjh6icY/KwcibO+thVe4Wa1M0y3kpLgq5PAawgUwhH6ge1C0F5LxaaRzh9 rWYaeGmoXztVyujoKd7I1RUUss5rTbbOcXXy9ZiLx8ZDzIWRHSlaJqrEGCP/7vBISosl C03apauMBmVfm1yLPU+oj2nd+HpP1aXjEu4ByiSUKHucQ7cijPjAFHnRibVW0SvmrfWT Uf5rgzQO/b1E8+l33YzdBMuqJD15awbPc/pnyEdWzzRbUoWchLZrrX1VGy5m8DDfp7nd uzSZTQwmvrSJ8ZjfDxb79CpqeYXGbPDuCJA5un9fevXs241qoVJUKgBAI2AptL5Mmsm9 fzrQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e18si1824325ejr.403.2021.02.12.13.37.34; Fri, 12 Feb 2021 13:37:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231923AbhBLVfJ convert rfc822-to-8bit (ORCPT + 99 others); Fri, 12 Feb 2021 16:35:09 -0500 Received: from lithops.sigma-star.at ([195.201.40.130]:44796 "EHLO lithops.sigma-star.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230047AbhBLVe6 (ORCPT ); Fri, 12 Feb 2021 16:34:58 -0500 Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 06EBA6074007; Fri, 12 Feb 2021 22:34:16 +0100 (CET) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id JxTK92jQMiKS; Fri, 12 Feb 2021 22:34:15 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id B61FF6074009; Fri, 12 Feb 2021 22:34:15 +0100 (CET) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id PiaCTGFa5zf1; Fri, 12 Feb 2021 22:34:15 +0100 (CET) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id 96E216074007; Fri, 12 Feb 2021 22:34:15 +0100 (CET) Date: Fri, 12 Feb 2021 22:34:15 +0100 (CET) From: Richard Weinberger To: Andy Shevchenko Cc: Juergen Borleis , linux-kernel , linux-mtd , kernel , Steffen Trumtrar , Oleksij Rempel Message-ID: <2022320545.389724.1613165655531.JavaMail.zimbra@nod.at> In-Reply-To: References: <20210202124838.30805-1-jbe@pengutronix.de> Subject: Re: [PATCH] fs: ubifs: set s_uuid in super block to support ima/evm uuid options MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [195.201.40.130] X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF78 (Linux)/8.8.12_GA_3809) Thread-Topic: ubifs: set s_uuid in super block to support ima/evm uuid options Thread-Index: UM/rSZ/B5fIVI3kknwppOQ4RboI4wA== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andy, ----- Ursprüngliche Mail ----- >> + memcpy(&sb->s_uuid, &c->uuid, sizeof(c-> > Shouldn’t it be `import_uuid()`? Hmm, I didn't know that helper. The only user in fs/ seems to be zonefs, all other filesystems do a plain memcpy(). Do you want me do a patch that converts all users in fs/ to import_uuid()? Thanks, //richard