Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3274144pxb; Fri, 12 Feb 2021 14:02:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJypB5L0wEXNSwfyuCovWEq6rgkzyWVs9c5tEHr+3ZhhiBBIBF20dCBamUD4H4/g7kc/JZr6 X-Received: by 2002:a05:6402:11c7:: with SMTP id j7mr5424419edw.290.1613167358986; Fri, 12 Feb 2021 14:02:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613167358; cv=none; d=google.com; s=arc-20160816; b=lpTtRAZfGCSeI4pNjDKhmCNyGvs6Nex4TH/0Kmp6dMnBhqqqnEATadyLnZKN0uo+W1 umP/3zVrMvOji6VCD2v9N4l4fO80K29VDhptf5UDGeoiuf7LOiQ8JH9Dvp7dXX0150fT 2dQLb//p/yTrhTayBoybW1n84/3XvpkxstaTTExcEXEOPAcoFqXLXfu6b7KZ7sz9CJSd Y1SFL3VUk1OqXnLY4FNMarrD8PDV2cbhvke+Z/3OOjgNEtPk7gGi2pFSl32P7rDNXu3m QvI3q200jIgB4W4TdBh+Rdwqav8K6+vwSebI/mwIGWTBwWbO6nCkgBthjU79ztmIOCiD fpbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=i0DgEQQH/SbmsKCbiiKdiqulUZdp1ZngGrOiG2NIsIE=; b=kCeoaW2zSfaWCA/1gXhQJ/lsxCcwTy20/0ikuBZxr6WE9KJMzRvx4rZvmlY43xs6Cl Ndup8rXvYC6iUfey5JspG8tjGGBDrvxmnNMX1YvWKgELOJriqID1fw17KCY74B9rxQIr B44s2xev0X3Xd3cA5v/6ljjcn7JLniIDIymaY0dXGpsv/7T+fo4ogu4T+aP75kU56bHW LiI/fLtUR7gR1aHmt9JkQwjDukH41+MlfoDGdmT3ye+Uwsk/v8fLQhAC6dkWPIxfEap1 n1Vo9YUswhuFCvULuHTedGUtIba8yu8OlHJRrME71AJ0X7pyn/p84E4x6QhaGuT+NtjV z4BA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id fe6si6250821ejc.349.2021.02.12.14.02.11; Fri, 12 Feb 2021 14:02:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230393AbhBLWAX (ORCPT + 99 others); Fri, 12 Feb 2021 17:00:23 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:38060 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229660AbhBLWAW (ORCPT ); Fri, 12 Feb 2021 17:00:22 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lAgTK-005uvn-L1; Fri, 12 Feb 2021 22:59:30 +0100 Date: Fri, 12 Feb 2021 22:59:30 +0100 From: Andrew Lunn To: Florian Fainelli Cc: netdev@vger.kernel.org, Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski , Michael Chan , "open list:BROADCOM ETHERNET PHY DRIVERS" , open list , olteanv@gmail.com, michael@walle.cc Subject: Re: [PATCH net-next 0/3] net: phy: broadcom: APD improvements Message-ID: References: <20210212205721.2406849-1-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210212205721.2406849-1-f.fainelli@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 12, 2021 at 12:57:18PM -0800, Florian Fainelli wrote: > This patch series cleans up the brcmphy.h header and its numerous unused > phydev->dev_flags, fixes the RXC/TXC clock disabling bit and allows the > BCM54210E PHY to utilize APD. > > Thanks! Hi Florian I don't know the hardware, but the descriptions seem to fit the code, and i did not spot anything odd. Reviewed-by: Andrew Lunn Andrew