Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <daf1eeca2d1176bbd53a1f84b5289addb6381814.camel@perches.com>
Subject: Re: [PATCH] proc: Convert S_<FOO> permission uses to octal
From:   Joe Perches <joe@perches.com>
To:     "Eric W. Biederman" <ebiederm@xmission.com>,
        Matthew Wilcox <willy@infradead.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Alexey Dobriyan <adobriyan@gmail.com>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Date:   Fri, 12 Feb 2021 16:42:15 -0800
In-Reply-To: <m1ft20zw3j.fsf@fess.ebiederm.org>
References: <85ff6fd6b26aafdf6087666629bad3acc29258d8.camel@perches.com>
         <m1im6x0wtv.fsf@fess.ebiederm.org>
         <20210212221918.GA2858050@casper.infradead.org>
         <m1ft20zw3j.fsf@fess.ebiederm.org>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.38.1-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Fri, 2021-02-12 at 17:48 -0600, Eric W. Biederman wrote:
> Matthew Wilcox <willy@infradead.org> writes:
> > On Fri, Feb 12, 2021 at 04:01:48PM -0600, Eric W. Biederman wrote:
> > > Perhaps we can do something like:
> > > 
> > > #define S_IRWX 7
> > > #define S_IRW_ 6
> > > #define S_IR_X 5
> > > #define S_IR__ 4
> > > #define S_I_WX 3
> > > #define S_I_W_ 2
> > > #define S_I__X 1
> > > #define S_I___ 0
> > > 
> > > #define MODE(TYPE, USER, GROUP, OTHER) \
> > > 	(((S_IF##TYPE) << 9) | \
> > > ?????????((S_I##USER)  << 6) | \
> > > ?????????((S_I##GROUP) << 3) | \
> > > ?????????(S_I##OTHER))
> > > 
> > > Which would be used something like:
> > > MODE(DIR, RWX, R_X, R_X)
> > > MODE(REG, RWX, R__, R__)
> > > 
> > > Something like that should be able to address the readability while
> > > still using symbolic constants.
> > 
> > I think that's been proposed before.
> 
> I don't think it has ever been shot down.  Just no one care enough to
> implement it.

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Tue, 2 Aug 2016 16:58:29 -0400
Message-ID: <CA+55aFw5v23T-zvDZp-MmD_EYxF8WbafwwB59934FV7g21uMGQ@mail.gmail.com> (raw)

[ So I answered similarly to another patch, but I'll just re-iterate
and change the subject line so that it stands out a bit from the
millions of actual patches ]

On Tue, Aug 2, 2016 at 1:42 PM, Pavel Machek <pavel@ucw.cz> wrote:
>
> Everyone knows what 0644 is, but noone can read S_IRUSR | S_IWUSR |
> S_IRCRP | S_IROTH (*). Please don't do this.

Absolutely. It's *much* easier to parse and understand the octal
numbers, while the symbolic macro names are just random line noise and
hard as hell to understand. You really have to think about it.

So we should rather go the other way: convert existing bad symbolic
permission bit macro use to just use the octal numbers.

The symbolic names are good for the *other* bits (ie sticky bit, and
the inode mode _type_ numbers etc), but for the permission bits, the
symbolic names are just insane crap. Nobody sane should ever use them.
Not in the kernel, not in user space.