Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3353290pxb; Fri, 12 Feb 2021 16:46:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJyzivsypy7k+Wzaq2HapLbLCme+drP3QVDgcYhkzD7ZNkN0GoL+3y4602K3MQ1xxJ0rvsU2 X-Received: by 2002:a17:906:1c17:: with SMTP id k23mr5405225ejg.121.1613177194865; Fri, 12 Feb 2021 16:46:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613177194; cv=none; d=google.com; s=arc-20160816; b=ZLkNKl9CoccpciiH/oXyAT1Av2lXbWsLsZFFO1LFt/jh1Z4/jF25xKZkz3ClGL2Az3 9/Q16lVSXN3oY6Y7gix+diuIHUoBSUtuiWunuHp1Sw2KW6B8K+uMocwOiWOGwiRElq+t vGP+AW95cJ9Ubm5Cq5niRkSaICv56eAwB7xSGnEJIvH1Ke3PF/Zqhhm2iFWQVn5D2Hq1 MDotcdXmaSaVUWqYsV8SU/X0w2X0GWM4Ve2F4dusrAaJE1RJW+cTh5bymCiror/EP6w8 92sGlc27NnfOEYf4/Y+sMrA2L/4LMNsiZt2MEZu8cu6Uq+l0B+P5Q6l5QO5ZhTozFFNU DI1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:to:from:cc:in-reply-to:subject:date:dkim-signature; bh=dbhUzwqGfG1hKMLbbUj/LjjWuHYf51AvOfJj5/4HJUU=; b=YRMJMGs4kFMkyuz/Tjxmr3sVoAVAh/mtA9f9lPbccD8jT89Mw+5LCsTL4+uR8xmTf9 qNrU/p1u6o+Hrwuxgkd7OZSPyRJoMFndZX6+ATOoMsN094cYCETjHCmlhOjaLWOuUL1p iyDOot9ns1ZHbfMxgI9leC/t+q7etXfSbKlLE37I8j+7m+njSR3cUDByyY4OuvXuE5C2 AHqRmUs+TM/eDVfTg/KOEyp2YZnVOPE1+ixiSwsIDzvskD58Bj9fA75YdUOAebAwRESn vcxlvbAuIyKVboGl6UmUL9QoXR7iITYyEmui/bfEIIz2AIgutgoTTiyDm4kDGiuUARf5 u22A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@dabbelt-com.20150623.gappssmtp.com header.s=20150623 header.b=lOvDyZuC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn22si5828201edb.78.2021.02.12.16.46.11; Fri, 12 Feb 2021 16:46:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@dabbelt-com.20150623.gappssmtp.com header.s=20150623 header.b=lOvDyZuC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231883AbhBMAom (ORCPT + 99 others); Fri, 12 Feb 2021 19:44:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232080AbhBMAoh (ORCPT ); Fri, 12 Feb 2021 19:44:37 -0500 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D1A6C0613D6 for ; Fri, 12 Feb 2021 16:43:57 -0800 (PST) Received: by mail-pf1-x42e.google.com with SMTP id m6so567143pfk.1 for ; Fri, 12 Feb 2021 16:43:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20150623.gappssmtp.com; s=20150623; h=date:subject:in-reply-to:cc:from:to:message-id:mime-version :content-transfer-encoding; bh=dbhUzwqGfG1hKMLbbUj/LjjWuHYf51AvOfJj5/4HJUU=; b=lOvDyZuCcqdlGpIpZqJwhKAdJ8v2iA4ozRlURXedM0oL6iIOUvFhraAQSlkyBpqhx5 httUjscQ3/UM95/G0oBLqe5j5qxsxAJApYykpS3o/b+aNux4jCsg0Hhp4w4X68CAvGZo bhaXfGbLFlH+TqiuefsFSxAj9iMMm5ygvA6eyuulXQVvqpYVU0I8a/dkZ3e2T8e66Kem fPqXAX9NoXq1dac6LINFPFB5pxtnJV+H58P2Hqe5nxVSSiiQgIfjjNqDeoZPaR2vg04a 1uJPv+KC0h9T2OjiE0PLBt5DcSFIGdvNuAP3ZUMWEEk/WTSzkAuixeEmTzmvmvUeifz+ pL3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=dbhUzwqGfG1hKMLbbUj/LjjWuHYf51AvOfJj5/4HJUU=; b=ngxP2QVpRckjvUd3yixqOG1C2caErIyC1GOXujiI5sl7lABT0bT/5VKFy9klfWwf9r Z+hDyU/090a6KWRF3Jf1kh79jfg4lpi2bZuzoJZ3AM/n4/noIoN08VOh1AuKh+QujUUo HwGSurf3376rlRdSYR8V2/cYylMr1so2KX3dldMXRsrN4adXteBSJJ966rMb3u40TnWq aksBNxWfS6nG9BBVUZtgNvMD4hs3u9HgF41rKr8Cw+N0zCULtOi8W/J4Q5Ab4sZ1jHXB 8ZOW7SFe3tUs9oEilxoDqTmhWf4C5ZvM50iJj2dEDlzb4TJyEWlIv+7mv16bzKOpmFx8 Gedg== X-Gm-Message-State: AOAM531295gDvwA406/zPMw4JaI+1k6fU4b+Pj9OvM0Ok91VGjVgkLUS qCvyOA0sWRAlQ4+A5ZINZqqMcw== X-Received: by 2002:a63:1826:: with SMTP id y38mr5577270pgl.252.1613177036325; Fri, 12 Feb 2021 16:43:56 -0800 (PST) Received: from localhost (76-210-143-223.lightspeed.sntcca.sbcglobal.net. [76.210.143.223]) by smtp.gmail.com with ESMTPSA id n12sm9230574pff.29.2021.02.12.16.43.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Feb 2021 16:43:55 -0800 (PST) Date: Fri, 12 Feb 2021 16:43:55 -0800 (PST) X-Google-Original-Date: Fri, 12 Feb 2021 16:43:50 PST (-0800) Subject: Re: [PATCH] Revert "dts: phy: add GPIO number and active state used for phy reset" In-Reply-To: <877dngjdi1.fsf@igel.home> CC: devicetree@vger.kernel.org, aou@eecs.berkeley.edu, anup@brainfault.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, yash.shah@sifive.com, robh+dt@kernel.org, sagar.kadam@sifive.com, Paul Walmsley , linux-riscv@lists.infradead.org, kernel-team@android.com From: Palmer Dabbelt To: schwab@linux-m68k.org Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 10 Feb 2021 04:47:34 PST (-0800), schwab@linux-m68k.org wrote: > On Feb 04 2021, Palmer Dabbelt wrote: > >> From: Palmer Dabbelt >> >> VSC8541 phys need a special reset sequence, which the driver doesn't >> currentlny support. As a result enabling the reset via GPIO essentially >> guarnteees that the device won't work correctly. >> >> This reverts commit a0fa9d727043da2238432471e85de0bdb8a8df65. >> >> Fixes: a0fa9d727043 ("dts: phy: add GPIO number and active state used for phy reset") >> Cc: stable@vger.kernel.org >> Signed-off-by: Palmer Dabbelt > > This fixes ethernet on the HiFive Unleashed with 5.10.12. Thanks for testing. Looks like I forgot to reply, but it's in Linus' tree and should end up in stable.