Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 14 Feb 2021 03:18:49 +0100
User-Agent: K-9 Mail for Android
In-Reply-To: <20210214015733.tfodqglq4djj2h44@skbuf>
References: <20210214010405.32019-1-michael@walle.cc> <20210214010405.32019-3-michael@walle.cc> <20210214015733.tfodqglq4djj2h44@skbuf>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH net-next 2/2] net: phy: at803x: use proper locking in at803x_aneg_done()
To:     Vladimir Oltean <olteanv@gmail.com>
CC:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>
From:   Michael Walle <michael@walle.cc>
Message-ID: <4ABD9AA0-94A3-4417-B6B2-996D193FB670@walle.cc>
Precedence: bulk

Am 14=2E Februar 2021 02:57:33 MEZ schrieb Vladimir Oltean <olteanv@gmail=
=2Ecom>:
>Hi Michael,
>
>On Sun, Feb 14, 2021 at 02:04:05AM +0100, Michael Walle wrote:
>> at803x_aneg_done() checks if auto-negotiation is completed on the
>SGMII
>> side=2E This doesn't take the mdio bus lock and the page switching is
>> open-coded=2E Now that we have proper page support, just use
>> phy_read_paged()=2E Also use phydev->interface to check if we have an
>> SGMII link instead of reading the mode register and be a bit more
>> precise on the warning message=2E
>>
>> Signed-off-by: Michael Walle <michael@walle=2Ecc>
>> ---
>
>How did you test this patch?

I'm afraid it's just compile time tested=2E

-michael=20