Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Geethasowjanya Akula <gakula@marvell.com>
To:     "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Linu Cherian <lcherian@marvell.com>,
        "Jerin Jacob Kollanukkaran" <jerinj@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [EXT] [bug report] octeontx2-af: cn10k: Identical code for
 different branches
Thread-Topic: [EXT] [bug report] octeontx2-af: cn10k: Identical code for
 different branches
Thread-Index: AQHXAXnrJmqNgDgas0KO+JbsSOWr4apW8aLW
Date:   Sun, 14 Feb 2021 02:46:07 +0000
Message-ID: <DM6PR18MB2602C27CB4B042203861239FCD899@DM6PR18MB2602.namprd18.prod.outlook.com>
References: <20210212200129.GA281901@embeddedor>
In-Reply-To: <20210212200129.GA281901@embeddedor>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: fe05b1af-9a1b-4a94-3473-08d8d092add9
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2021 02:46:07.1492
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: i5nRhsd1EYOQgmJ2Gg1p48PQK2qC5ELVxcmZ4u6sDOYKBYH9MGvr29+khQO6qvfWm10tjWOgyFu6tWLLC/aPmg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR18MB1626
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.737
 definitions=2021-02-13_02:2021-02-12,2021-02-13 signatures=0
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Gustavo,=0A=
=0A=
Please see inline.=0A=
=0A=
=0A=
________________________________________=0A=
>From: Gustavo A. R. Silva <gustavoars@kernel.org>=0A=
>Sent: Saturday, February 13, 2021 1:31 AM=0A=
>To: Sunil Kovvuri Goutham; Linu Cherian; Geethasowjanya Akula; Jerin Jacob=
 >Kollanukkaran; Hariprasad Kelam; Subbaraya Sundeep Bhatta; David S. Mille=
r; Jakub >Kicinski=0A=
>Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Gustavo A. R. Si=
lva=0A=
>Subject: [EXT] [bug report] octeontx2-af: cn10k: Identical code for differ=
ent branches=0A=
=0A=
>External Email=0A=
=0A=
----------------------------------------------------------------------=0A=
Hi,=0A=
=0A=
>In file drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c, function =
rvu_dbg_init()=0A=
>the same code is executed for both branches:=0A=
=0A=
>2431         if (is_rvu_otx2(rvu))=0A=
>2432                 debugfs_create_file("rvu_pf_cgx_map", 0444, rvu->rvu_=
dbg.root,=0A=
>2433                                     rvu, &rvu_dbg_rvu_pf_cgx_map_fops=
);=0A=
>2434         else=0A=
>2435                 debugfs_create_file("rvu_pf_cgx_map", 0444, rvu->rvu_=
dbg.root,=0A=
>2436                                     rvu, &rvu_dbg_rvu_pf_cgx_map_fops=
);=0A=
=0A=
>This issue was introduced by commit 91c6945ea1f9 ("octeontx2-af: cn10k: Ad=
d RPM >MAC support")=0A=
=0A=
>What's the right solution for this?=0A=
Thanks Gustavo for pointing out.  below is the right cod for else conductio=
n.=0A=
=0A=
else=0A=
      debugfs_create_file("rvu_pf_rpm_map", 0444, rvu->rvu_dbg.root,=0A=
                                    rvu, &rvu_dbg_rvu_pf_cgx_map_fops);=0A=
=0A=
Thanks=0A=
---=0A=
Gustavo=0A=