Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964867AbWIYGyV (ORCPT ); Mon, 25 Sep 2006 02:54:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030184AbWIYGyS (ORCPT ); Mon, 25 Sep 2006 02:54:18 -0400 Received: from web31804.mail.mud.yahoo.com ([68.142.207.67]:664 "HELO web31804.mail.mud.yahoo.com") by vger.kernel.org with SMTP id S964869AbWIYGyR (ORCPT ); Mon, 25 Sep 2006 02:54:17 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Message-ID:Received:Date:From:Reply-To:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=errcHNptru2n6nWlvdL4y4Uwr4zqNwacdY7bXoIRf91yNpyQkNvqAm0BVmDECTsk0986zg3sv56DsEbeAc9Aws6ZV/ZV406xC/ZpYV8WoDNfiWpJd3tY23z2RqWN0l+TFRZhlNLEOWaBRqU63ptpvTpAXaY2PTnRoZ2auegW/t8= ; Message-ID: <20060925065416.76348.qmail@web31804.mail.mud.yahoo.com> Date: Sun, 24 Sep 2006 23:54:16 -0700 (PDT) From: Luben Tuikov Reply-To: ltuikov@yahoo.com Subject: Re: [PATCH] fix idiocy in asd_init_lseq_mdp() To: Al Viro , Linus Torvalds Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20060925015722.GF29920@ftp.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1732 Lines: 48 --- Al Viro wrote: > To whoever had written that code: > > a) priority of >> is higher than that of & > b) priority of typecast is higher than that of any binary operator > c) learn the fscking C "whoever" would be Bottomley or someone at LTC. My code in that spot has: asd_write_reg_dword(asd_ha, LmSEQ_INTEN_SAVE(lseq), (u32) LmM0INTEN_MASK); Luben > > Signed-off-by: Al Viro > --- > drivers/scsi/aic94xx/aic94xx_seq.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/scsi/aic94xx/aic94xx_seq.c b/drivers/scsi/aic94xx/aic94xx_seq.c > index d9b6da5..56e4b3b 100644 > --- a/drivers/scsi/aic94xx/aic94xx_seq.c > +++ b/drivers/scsi/aic94xx/aic94xx_seq.c > @@ -764,7 +764,7 @@ static void asd_init_lseq_mdp(struct asd > asd_write_reg_word(asd_ha, LmSEQ_FIRST_INV_SCB_SITE(lseq), > (u16)last_scb_site_no+1); > asd_write_reg_word(asd_ha, LmSEQ_INTEN_SAVE(lseq), > - (u16) LmM0INTEN_MASK & 0xFFFF0000 >> 16); > + (u16) ((LmM0INTEN_MASK & 0xFFFF0000) >> 16)); > asd_write_reg_word(asd_ha, LmSEQ_INTEN_SAVE(lseq) + 2, > (u16) LmM0INTEN_MASK & 0xFFFF); > asd_write_reg_byte(asd_ha, LmSEQ_LINK_RST_FRM_LEN(lseq), 0); > -- > 1.4.2.GIT > > - > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/