Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Geethasowjanya Akula <gakula@marvell.com>
To:     "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Linu Cherian <lcherian@marvell.com>,
        "Jerin Jacob Kollanukkaran" <jerinj@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [EXT] [bug report] octeontx2-af: cn10k: Uninitialized variables
Thread-Topic: [EXT] [bug report] octeontx2-af: cn10k: Uninitialized variables
Thread-Index: AQHXAW5oiLSqxT9BUEWNdGA6ybCpN6pW/3V6
Date:   Sun, 14 Feb 2021 03:33:24 +0000
Message-ID: <DM6PR18MB260244467263DDD91ECF0D9FCD899@DM6PR18MB2602.namprd18.prod.outlook.com>
References: <20210212183917.GA279621@embeddedor>
In-Reply-To: <20210212183917.GA279621@embeddedor>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: de93f634-fce2-49ee-eb8d-08d8d0994958
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2021 03:33:24.9944
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: A4TbG1EZXmpL4pq7epktcTb0iiLAXbL5fWe85R/5USshXrDa1Hi5McgLNoKWS+wZRBSWSOpbKaYww9AwfknWhw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2412
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.737
 definitions=2021-02-13_02:2021-02-12,2021-02-13 signatures=0
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Gustavo,=0A=
=0A=
please see inline.=0A=
=0A=
Thank you,=0A=
Geetha.=0A=
=0A=
=0A=
________________________________________=0A=
>From: Gustavo A. R. Silva <gustavoars@kernel.org>=0A=
>Sent: Saturday, February 13, 2021 12:09 AM=0A=
>To: Sunil Kovvuri Goutham; Linu Cherian; Geethasowjanya Akula; Jerin Jacob=
 >Kollanukkaran; Hariprasad Kelam; Subbaraya Sundeep Bhatta; David S. Mille=
r; Jakub >Kicinski=0A=
>Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Gustavo A. R. Si=
lva=0A=
>Subject: [EXT] [bug report] octeontx2-af: cn10k: Uninitialized variables=
=0A=
=0A=
>External Email=0A=
=0A=
----------------------------------------------------------------------=0A=
>Hi,=0A=
=0A=
>Variables cgx_id and lmac_id are being used uninitialized at lines 731=0A=
>and 733 in the following function:=0A=
=0A=
>723 static int rvu_cgx_config_intlbk(struct rvu *rvu, u16 pcifunc, bool en=
)=0A=
>724 {=0A=
>725         struct mac_ops *mac_ops;=0A=
>726         u8 cgx_id, lmac_id;=0A=
>727=0A=
>728         if (!is_cgx_config_permitted(rvu, pcifunc))=0A=
>729                 return -EPERM;=0A=
>730=0A=
>731         mac_ops =3D get_mac_ops(rvu_cgx_pdata(cgx_id, rvu));=0A=
>732=0A=
>733         return mac_ops->mac_lmac_intl_lbk(rvu_cgx_pdata(cgx_id, rvu),=
=0A=
>734                                           lmac_id, en);=0A=
735 }=0A=
=0A=
>This bug was introduced by commit 3ad3f8f93c81 ("octeontx2-af: cn10k: MAC =
internal >loopback support")=0A=
=0A=
>What's the right solution for this?=0A=
=0A=
Thanks Gustavo. Sorry I missed it. Below is the fix.=0A=
=0A=
 static int rvu_cgx_config_intlbk(struct rvu *rvu, u16 pcifunc, bool en)=0A=
 {=0A=
+        int pf =3D rvu_get_pf(pcifunc);=0A=
        struct mac_ops *mac_ops;=0A=
        u8 cgx_id, lmac_id;=0A=
=0A=
        if (!is_cgx_config_permitted(rvu, pcifunc))=0A=
                return -EPERM;=0A=
=0A=
+       rvu_get_cgx_lmac_id(rvu->pf2cgxlmac_map[pf], &cgx_id, &lmac_id);=0A=
        mac_ops =3D get_mac_ops(rvu_cgx_pdata(cgx_id, rvu));=0A=
=0A=
=0A=
Thanks=0A=
--=0A=
Gustavo=0A=