Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 14 Feb 2021 15:46:14 +0900
From:   William Breathitt Gray <vilhelm.gray@gmail.com>
To:     Syed Nayyar Waris <syednwaris@gmail.com>
Cc:     bgolaszewski@baylibre.com, andriy.shevchenko@linux.intel.com,
        michal.simek@xilinx.com, arnd@arndb.de, rrichter@marvell.com,
        linus.walleij@linaro.org, yamada.masahiro@socionext.com,
        akpm@linux-foundation.org, rui.zhang@intel.com,
        daniel.lezcano@linaro.org, amit.kucheria@verdurent.com,
        linux-arch@vger.kernel.org, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 2/3] gpio: thunderx: Utilize for_each_set_clump macro
Message-ID: <YCjHNgZt8vn1bTAQ@shinobu>
References: <cover.1613134924.git.syednwaris@gmail.com>
 <3fc5bd83322c94eb2a4f48677f6d762bf81d0652.1613134924.git.syednwaris@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="se7pS8+DlUJjaBax"
Content-Disposition: inline
In-Reply-To: <3fc5bd83322c94eb2a4f48677f6d762bf81d0652.1613134924.git.syednwaris@gmail.com>
Precedence: bulk


--se7pS8+DlUJjaBax
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 12, 2021 at 06:51:04PM +0530, Syed Nayyar Waris wrote:
> This patch reimplements the thunderx_gpio_set_multiple function in
> drivers/gpio/gpio-thunderx.c to use the new for_each_set_clump macro.
> Instead of looping for each bank in thunderx_gpio_set_multiple
> function, now we can skip bank which is not set and save cycles.
>=20
> Cc: William Breathitt Gray <vilhelm.gray@gmail.com>
> Cc: Robert Richter <rrichter@marvell.com>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Signed-off-by: Syed Nayyar Waris <syednwaris@gmail.com>

Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com>

> ---
>  drivers/gpio/gpio-thunderx.c | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
>=20
> diff --git a/drivers/gpio/gpio-thunderx.c b/drivers/gpio/gpio-thunderx.c
> index 9f66deab46ea..0398b2d2af4b 100644
> --- a/drivers/gpio/gpio-thunderx.c
> +++ b/drivers/gpio/gpio-thunderx.c
> @@ -16,7 +16,7 @@
>  #include <linux/pci.h>
>  #include <linux/spinlock.h>
>  #include <asm-generic/msi.h>
> -
> +#include "gpiolib.h"
> =20
>  #define GPIO_RX_DAT	0x0
>  #define GPIO_TX_SET	0x8
> @@ -275,12 +275,15 @@ static void thunderx_gpio_set_multiple(struct gpio_=
chip *chip,
>  				       unsigned long *bits)
>  {
>  	int bank;
> -	u64 set_bits, clear_bits;
> +	unsigned long set_bits, clear_bits, gpio_mask;
> +	unsigned long offset;
> +
>  	struct thunderx_gpio *txgpio =3D gpiochip_get_data(chip);
> =20
> -	for (bank =3D 0; bank <=3D chip->ngpio / 64; bank++) {
> -		set_bits =3D bits[bank] & mask[bank];
> -		clear_bits =3D ~bits[bank] & mask[bank];
> +	for_each_set_clump(offset, gpio_mask, mask, chip->ngpio, 64) {
> +		bank =3D offset / 64;
> +		set_bits =3D bits[bank] & gpio_mask;
> +		clear_bits =3D ~bits[bank] & gpio_mask;
>  		writeq(set_bits, txgpio->register_base + (bank * GPIO_2ND_BANK) + GPIO=
_TX_SET);
>  		writeq(clear_bits, txgpio->register_base + (bank * GPIO_2ND_BANK) + GP=
IO_TX_CLR);
>  	}
> --=20
> 2.29.0
>=20

--se7pS8+DlUJjaBax
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEk5I4PDJ2w1cDf/bghvpINdm7VJIFAmAoxzYACgkQhvpINdm7
VJIbiQ/+ICxmJVJ1eLuf5r+9JrFTo+uIbt9EDs9pQpW9l7BEjTsVQa4ALyElS9lH
8WUP2VX2ZeqVNV4UFRw8sW4BtUFaREdoaJMsfdHAHK+OfCJlyuMvNw+Jxa3Sl5AI
OWavxf8pUAaO1u+gGE7VwM/FxscUocTJQy859hx0DXVVNiqvo10a3bzzxHkuX+PT
UDVt1oB9Y7lc6WigV1uI6518Tcoi9VX59c/f10s01NJqfZnMhfOen9c5DTfZjkvC
fvbZRjkbQXdUln7yJrzTYIPzsmeqSRSDqh7y/GAmmy9ETUhS9KfeHHDQzuvy1gr9
XSfleyHM10pqVWo8ePEEPFxkJc8cSg4RpXaDJHQAhAELc354xPr6IEj2vfVVw/YO
Jjr09zLmB3+IsJVZFTml2AA5O6zQBPZxvvUa05Peet+C0mFTkxjqBg1adqJKvvVu
F2phAvkq2a+yKjQC+wHMdQj67grkSheE1x10R7lu+MB3UTDme/E1a8wbEogHwBv2
/iiweVQ6iY4Q+NJ85FH8vzvbovIvQJvR54JDKfiBLdkW+qONDGZ/aTl1kUs/wBXn
e4SgIun/pAIskTc1IiobPPeZYKZk2IpRNNpEeIwEt/oeD0hnZQ7oQIL+ZfDQM2Nh
j3/N2x4+mAptTomv9AacIBjCiwhMbJgenw8C82HltPv6IRAqgPU=
=ms+c
-----END PGP SIGNATURE-----

--se7pS8+DlUJjaBax--