Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] Fix typo in f_printer.c
To:     AristoChen <jj251510319013@gmail.com>, linux-kernel@vger.kernel.org
References: <20210214065354.5490-1-jj251510319013@gmail.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <8d5e7e34-b9ff-c1fa-1447-112bdbf6f2c7@infradead.org>
Date:   Sat, 13 Feb 2021 23:05:56 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.0
MIME-Version: 1.0
In-Reply-To: <20210214065354.5490-1-jj251510319013@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/13/21 10:53 PM, AristoChen wrote:
> In line 824, it is trying to open `out_ep`, so
> I believe in line 826, it should print `out_ep`
> instead of `in_ep`
> 
> Signed-off-by: AristoChen <jj251510319013@gmail.com>
> ---
>   drivers/usb/gadget/function/f_printer.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/function/f_printer.c b/drivers/usb/gadget/function/f_printer.c
> index 2f1eb2e81d30..a3b17ec00bf0 100644
> --- a/drivers/usb/gadget/function/f_printer.c
> +++ b/drivers/usb/gadget/function/f_printer.c
> @@ -823,7 +823,7 @@ set_printer_interface(struct printer_dev *dev)
>   
>   	result = usb_ep_enable(dev->out_ep);
>   	if (result != 0) {
> -		DBG(dev, "enable %s --> %d\n", dev->in_ep->name, result);
> +		DBG(dev, "enable %s --> %d\n", dev->out_ep->name, result);
>   		goto done;
>   	}
>   
> 

Hi,
The patch makes sense.
You should Cc: the USB gadget maintainer and the linux-usb mailing list.

Thanks.