Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 14 Feb 2021 10:53:44 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Bart Van Assche <bvanassche@acm.org>
Cc:     Arthur Simchaev <Arthur.Simchaev@sandisk.com>,
        "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        alim.akhtar@samsung.com, Bean Huo <beanhuo@micron.com>,
        Arthur Simchaev <arthur.simchaev@wdc.com>
Subject: Re: [PATCH] scsi: ufs: sysfs: add is_ascii_output entry
Message-ID: <YCjzKOEV9fUPf3Ja@kroah.com>
References: <1612954425-6705-1-git-send-email-Arthur.Simchaev@sandisk.com>
 <4bba4245-df01-f23d-65ba-4ff133cae0bc@acm.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4bba4245-df01-f23d-65ba-4ff133cae0bc@acm.org>
Precedence: bulk

On Wed, Feb 10, 2021 at 07:35:25PM -0800, Bart Van Assche wrote:
> On 2/10/21 2:53 AM, Arthur Simchaev wrote:
> > +static bool is_ascii_output = true;
> 
> [ ... ]
> 
> >  static const char *ufschd_uic_link_state_to_string(
> >  			enum uic_link_state state)
> >  {
> > @@ -693,7 +695,15 @@ static ssize_t _name##_show(struct device *dev,				\
> >  				      SD_ASCII_STD);			\
> >  	if (ret < 0)							\
> >  		goto out;						\
> > -	ret = sysfs_emit(buf, "%s\n", desc_buf);			\
> > +	if (is_ascii_output) {						\
> > +		ret = sysfs_emit(buf, "%s\n", desc_buf);		\
> > +	} else {							\
> > +		int i;							\
> > +									\
> > +		for (i = 0; i < desc_buf[0]; i++)			\
> > +			hex_byte_pack(buf + i * 2, desc_buf[i]);	\
> > +		ret = sysfs_emit(buf, "%s\n", buf);			\
> > +	}								\
> >  out:									\
> >  	pm_runtime_put_sync(hba->dev);					\
> >  	kfree(desc_buf);						\
> 
> Please do not introduce a mode variable but instead introduce a new
> attribute such that there is one attribute for the unicode output and
> one attribute for the ASCII output. Mode variables are troublesome when
> e.g. two scripts try to set the mode attribute concurrently.

Agreed, just make a new sysfs file, please never change the output of an
existing sysfs file, that way will guarantee confusion in userspace.

thanks,

greg k-h