Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp4286326pxb; Sun, 14 Feb 2021 05:25:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJwFBVHmViaexdrzHrcrq7/dvFg8PsHp+TkSRZF4lWvXkpoUf1GrnvG/L71H2/8bvEHkpY6u X-Received: by 2002:a05:6402:1118:: with SMTP id u24mr11569133edv.386.1613309127207; Sun, 14 Feb 2021 05:25:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613309127; cv=none; d=google.com; s=arc-20160816; b=jkYePzOjYDumSdvbZSh5kwMAYB6Nwfax3nEJBLrtIveilvyuQWu/6UVpWSXCiThCLI cvevpIw6muo7TJTSpf38mYCiPxJokP9/VLhvodwDcVZvNUsMptOguS/X5cbqkgXhGnpB KRDYHaWdXDSjwu72GqViDf5Jq7frjsWPs+Ufv/+LdqyPzLkKOdq3MVaFaNYcsUlI5gDP G2dbvdKnaHcjdSlP8vPjJKHXCy5DGMsDTnCKb1utIgBpWpuJEYx6KUNK8YzQdYSer3Zx TULF/wK9zKC4V0VarpS9ICE6oz9feFijmAyN5t0YS/6qNc6xh5RrkwdiX45S/TrvsDDJ GrFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=E6mT1eLy2BbvLR20EYpVVGUzTe4X8rj8sSx2cY7U1BQ=; b=SQDs9ybQyna6RQS7IOwzL+PbY5r/Crt4OY8LLwJBdvSUKg5hCUTthn5smzFH3rLCFI 9yUZP06j8aOH/r3jU6HeYrVh66HYqR9L/XHXVzuMuiLfT8U0haR5iSiKZWxz3+g1XPSW hnx2sGOVw8UMhs93FPag2H7f5Sl3f3Hd5+oHTwCHrvQqrd3LJi06pXBX4CKig4ABBSLu PPnUjnmOHjXZuAUPb4UmlidOSxEqfyA2ZdTSSMMvShr8s9KaQVlQub5pBaxztjJB4m9T J+jrysvADs7jfzyIJnYy1hCivKvAIfjiuw/KkVmXu/j0Ue5aGuoE/FDmPZLlbvH6jMtI LQJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@libero.it header.s=s2014 header.b=ZpAmYi+I; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=libero.it Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id fy13si9935940ejb.62.2021.02.14.05.25.04; Sun, 14 Feb 2021 05:25:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@libero.it header.s=s2014 header.b=ZpAmYi+I; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=libero.it Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229788AbhBNNYY (ORCPT + 99 others); Sun, 14 Feb 2021 08:24:24 -0500 Received: from smtp-17.italiaonline.it ([213.209.10.17]:39339 "EHLO libero.it" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229741AbhBNNYW (ORCPT ); Sun, 14 Feb 2021 08:24:22 -0500 X-Greylist: delayed 382 seconds by postgrey-1.27 at vger.kernel.org; Sun, 14 Feb 2021 08:24:22 EST Received: from passgat-Modern-14-A10M.homenet.telecomitalia.it ([87.20.116.197]) by smtp-17.iol.local with ESMTPA id BHGzlGzOglChfBHH2lSOc0; Sun, 14 Feb 2021 14:17:18 +0100 x-libjamoibt: 1601 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=libero.it; s=s2014; t=1613308638; bh=E6mT1eLy2BbvLR20EYpVVGUzTe4X8rj8sSx2cY7U1BQ=; h=From; b=ZpAmYi+IKCWgHyj28z6lIn5HVGK9sxHytuyDiudYb43ITPihegRI1MRIRM6maa9Bh G6HjbgVTEtUX72n0XTVEBXRZ/igelUyzADGaKGFzKaylFr0ODvv6A0krtp4Rgacwnq uByYETt7a33t3e7vMhI7xZw0hIrlHOdK4iFh9pvzrdw4GXJIsKGxxydJ0DAVOnOQAZ +/NxqqeprMWMoGHI1Z07AySxQ6bhRbbzqik2lClJYBbaaI3pVjWjG6SxzquyfydkPV QI63zqXI/JhAAAF2ZJQFmwRup+B+WSEQizn7CO92CkDsF1H5GOQb9Uy//62GqQJbjM rFODGn0aQ3T+w== X-CNFS-Analysis: v=2.4 cv=S6McfKgP c=1 sm=1 tr=0 ts=602922de cx=a_exe a=AVqmXbCQpuNSdJmApS5GbQ==:117 a=AVqmXbCQpuNSdJmApS5GbQ==:17 a=toUk0IfjeMrTqMqL6ioA:9 From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Dario Binacchi , Daniel Vetter , David Airlie , Jyri Sarha , Tomi Valkeinen , dri-devel@lists.freedesktop.org Subject: [PATCH] drm/tilcdc: fix raster control register setting Date: Sun, 14 Feb 2021 14:16:33 +0100 Message-Id: <20210214131633.8742-1-dariobin@libero.it> X-Mailer: git-send-email 2.17.1 X-CMAE-Envelope: MS4xfMWdaqhQ+nSGvZCap5fuCPf8jL9YHqt+DWi5pPLGDMgmPnom2IIJHhAhuxJSRQZJmBSK2X3uzoM7Qmktkqz0w7y1AmIsrLflB2ipm2vuEsbsNyYTJ/vp 5tV6EgywFwK0mibn6E+Ey77YTfpCyNr0s1hzC15RekyHEBqHm/kOZzgfvUhHjMJMRHF1XLM0vMIqGDPrn2A4RswurykyjdR4PvictSH6FoKyZu3bcp+ejMsS 0OZCGPQ9pwEi0ulA3BoZI5qKse7C1QS9F29QWzQOz8SMw1QvZ53VcCE8ZImPdbmXdKdThVhMomCecDKXPNCzs6UgiAiWcGbIzezeMEqP3xm8UbyxGUFnX1Kf RxxejY4AKuoY78Id2sL7gJRlc/Ah2TLOlMPZotJyN/LLPJDY50gNSRg/tM6deA0PwIU/s9bi Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The fdd property of the tilcdc_panel_info structure must set the reqdly bit field (bit 12 to 19) of the raster control register. The previous statement set the least significant bit instead. Signed-off-by: Dario Binacchi --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c index 30213708fc99..238068e28729 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c @@ -393,7 +393,7 @@ static void tilcdc_crtc_set_mode(struct drm_crtc *crtc) return; } } - reg |= info->fdd < 12; + reg |= info->fdd << 12; tilcdc_write(dev, LCDC_RASTER_CTRL_REG, reg); if (info->invert_pxl_clk) -- 2.17.1