Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 14 Feb 2021 21:18:10 +0000
From:   Al Viro <viro@zeniv.linux.org.uk>
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [git pull] sendfile fixes
Message-ID: <YCmTkg0vJWc8Ncam@zeniv-ca.linux.org.uk>
References: <YCk/f0efY5OhibCn@zeniv-ca.linux.org.uk>
 <CAHk-=wiyaja6TKL1+HGXMXNE2EkqfjjKV6oQAOKfTTacc=mq5Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHk-=wiyaja6TKL1+HGXMXNE2EkqfjjKV6oQAOKfTTacc=mq5Q@mail.gmail.com>
Sender: Al Viro <viro@ftp.linux.org.uk>
Precedence: bulk

On Sun, Feb 14, 2021 at 11:35:36AM -0800, Linus Torvalds wrote:

> Just to clarify: this says "fixes", but I get the feeling that you
> meant for me to pull tomorrow in the 5.12 merge window?
> 
> I like the patches, but they don't seem to be anything hugely urgent.
> They should make "sendfile to pipe" more efficient, but the current
> hack is _workable_ (and not any worse than what we historically did)
> even if it's not optimal.
> 
> Right?

Yes.  It allows to drop the current hack, but it's not urgent.

> Oh, and it looks like the first line of the commit message of
> 313d64a35d36 ("do_splice_to(): move the logics for limiting the read
> length in") got truncated somehow..

	Offense against style, actually - preposition torn from object and
moved to the very end of sentence...  "[splice] move the logics for limiting
the read length into do_splice_to()" would probably be better.